Github user Harbs commented on the pull request:
https://github.com/apache/flex-sdk/pull/18#issuecomment-157861022
Using Proxy as a base class for ArrayList will likely have a significant
performance hit. It seems questionable as to whether the benefits of using for
each loops outweig
Github user tomforster commented on the pull request:
https://github.com/apache/flex-sdk/pull/18#issuecomment-131120010
+1 this would be nice to have and a clear improvement to a common use case.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user roberthunt commented on the pull request:
https://github.com/apache/flex-sdk/pull/18#issuecomment-131119385
I would appreciate this being merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Yes, double bump.
Can someone please take a look at this?
EdB
On Wed, Jun 10, 2015 at 10:41 AM, Dretch wrote:
> Github user Dretch commented on the pull request:
>
> https://github.com/apache/flex-sdk/pull/18#issuecomment-110656554
>
> Bump. Could this pull request be considered?
>
>
Github user Dretch commented on the pull request:
https://github.com/apache/flex-sdk/pull/18#issuecomment-110656554
Bump. Could this pull request be considered?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Hi Fréd, thanks for your suggestion. (I responded inline.)
> I have to admit I'm not very keen to see an already overly complex class to
> become even more complex adding complex field managment.
Me neither, I agree. I was thinking to add the field watcher as an
optional constructor parameter / s
Github user Dretch commented on the pull request:
https://github.com/apache/flex-sdk/pull/18#issuecomment-107212393
I have moved the test to the framework project, where it is now called by
the build. I have also added a warning to the documentation about how slow
array access notatio
> Me? I generally tried to avoid being on the naming committees.
Naming committees? I lol'ed at the idea, and then at the multiple...
And the best they could come up with was
"frameworks/projects/framework"? No wonder FB cost so much!
:-P
EdB
--
Ix Multimedia Software
Jan Luykenstraat 27
3
On 5/29/15, 12:34 AM, "Erik de Bruin" wrote:
>Gareth,
>
>> 1. The logical project for my test (i.e. the project containing
>> mx.collections.ArrayList) seems to be the "framework" project. I am
>>confused
>> by the name of this project being "framework"... it lives in a folder
>>called
>> "fram
k
already complex.
Thought ?
Frédéric THOMAS
> From: mihai.ch...@gmail.com
> Date: Fri, 29 May 2015 11:55:24 +0200
> Subject: Re: [GitHub] flex-sdk pull request: Fix FLEX-15159 by making
> ArrayList extend P...
> CC: dev@flex.apache.org
>
> >> 2. I have added my test
>> 2. I have added my test to the "framework" project according to the wiki,
>> and it works! Except that there was already a
>> "frameworks/projects/framework/tests/ folder", and it already contained a
>> test (ListCollectionView_FLEX_34837_Tests.as). I suppose that this test was
>> not being run
Gareth,
> 1. The logical project for my test (i.e. the project containing
> mx.collections.ArrayList) seems to be the "framework" project. I am confused
> by the name of this project being "framework"... it lives in a folder called
> "frameworks/projects/framework/" - what is the meaning of this?
Hi Erik,
Thanks for your help.
I have setup the tests according to the wiki page, but I have a few
questions:
1. The logical project for my test (i.e. the project containing
mx.collections.ArrayList) seems to be the "framework" project. I am
confused by the name of this project being "frame
Hi,
While we wait for the performance discussion to die down (I'd say
"commit THEN review", but who am I ;-)), I'll give you this:
https://cwiki.apache.org/confluence/display/FLEX/Add+FlexUnit+tests+to+SDK+projects
If that doesn't do it for you, I'll be glad to help to get you run as
part of the
GitHub user Dretch opened a pull request:
https://github.com/apache/flex-sdk/pull/18
Fix FLEX-15159 by making ArrayList extend Proxy.
This fixes https://issues.apache.org/jira/browse/FLEX-15159.
Notes:
- This is more-or-less a copy-paste job with code taken from
`L
15 matches
Mail list logo
