Re: Build failed in Jenkins: flex-sdk_mustella #258

2013-08-15 Thread Justin Mclean
Hi, Never mind, I found the thread where you're discussing this. Read first, complain later ;-) No issue - changes have been reverted so it should be good now. Mean those RTE still exist but it's an edge case. Thanks, Justin

Re: Build failed in Jenkins: flex-sdk_mustella #258

2013-08-14 Thread Erik de Bruin
I'm sorry to keep harassing you about this, but there are still 4 tests failing :-( EdB On Tue, Aug 13, 2013 at 1:06 PM, Justin Mclean jus...@classsoftware.com wrote: Hi, I'll sort this out and either fix or revert today. Thanks, Justin -- Ix Multimedia Software Jan Luykenstraat 27

Re: Build failed in Jenkins: flex-sdk_mustella #258

2013-08-14 Thread Erik de Bruin
Never mind, I found the thread where you're discussing this. Read first, complain later ;-) My bad. EdB On Thu, Aug 15, 2013 at 7:40 AM, Erik de Bruin e...@ixsoftware.nl wrote: I'm sorry to keep harassing you about this, but there are still 4 tests failing :-( EdB On Tue, Aug 13, 2013

Re: Build failed in Jenkins: flex-sdk_mustella #258

2013-08-13 Thread Justin Mclean
Hi, I'll sort this out and either fix or revert today. Thanks, Justin

Re: Build failed in Jenkins: flex-sdk_mustella #258

2013-08-10 Thread Alex Harui
Justin, The commits look like you reverted the ObjectUtil change, then checked in the editable item code instead of tweaking the creation of the empty column when there are no columns at the time that generateCols gets called. Was that intentional? -Alex On 8/9/13 5:01 PM, Justin Mclean

Re: Build failed in Jenkins: flex-sdk_mustella #258

2013-08-10 Thread Justin Mclean
Hi, The commits look like you reverted the ObjectUtil change, Yep. then checked in the editable item code instead of tweaking the creation of the empty column I checked in both tweaking the creation of the empty column (see that length property is excluded if the data is a String). Justin

Re: Build failed in Jenkins: flex-sdk_mustella #258

2013-08-10 Thread Alex Harui
On 8/10/13 5:28 AM, Justin Mclean jus...@classsoftware.com wrote: Hi, The commits look like you reverted the ObjectUtil change, Yep. then checked in the editable item code instead of tweaking the creation of the empty column I checked in both tweaking the creation of the empty column (see

Re: Build failed in Jenkins: flex-sdk_mustella #258

2013-08-09 Thread Erik de Bruin
And now, after all the slack has run out, a gentle 'bump'... :-) EdB On Mon, Aug 5, 2013 at 4:33 PM, Erik de Bruin e...@ixsoftware.nl wrote: +1 on the slack cutting :-) EdB On Mon, Aug 5, 2013 at 4:29 PM, Alex Harui aha...@adobe.com wrote: Not surprising. Without looking it appears

Re: Build failed in Jenkins: flex-sdk_mustella #258

2013-08-09 Thread Justin Mclean
Hi, And now, after all the slack has run out, a gentle 'bump'... Should of been fixed this morning, one if the fixes was revered and the other should now be more test friendly. Justin

Re: Build failed in Jenkins: flex-sdk_mustella #258

2013-08-05 Thread Erik de Bruin
FYI, the tests fails in all three configurations. EdB On Sun, Aug 4, 2013 at 4:20 PM, Justin Mclean jus...@classsoftware.com wrote: Hi I think the latest commits really broke a few tests... Quite likely there an issue with the tests. I'm not going to be able to look at it today but can

Re: Build failed in Jenkins: flex-sdk_mustella #258

2013-08-05 Thread Alex Harui
Not surprising. Without looking it appears the tests are failing in response to the one change to DataGrid, but it isn't obvious why. At Adobe, the rule was you had to revert so others could check in, and only re-check in when you also had repaired tests to go with them. But I don't have

Re: Build failed in Jenkins: flex-sdk_mustella #258

2013-08-05 Thread Erik de Bruin
+1 on the slack cutting :-) EdB On Mon, Aug 5, 2013 at 4:29 PM, Alex Harui aha...@adobe.com wrote: Not surprising. Without looking it appears the tests are failing in response to the one change to DataGrid, but it isn't obvious why. At Adobe, the rule was you had to revert so others could

Re: Build failed in Jenkins: flex-sdk_mustella #258

2013-08-04 Thread Erik de Bruin
I think the latest commits really broke a few tests... EdB On Sun, Aug 4, 2013 at 9:08 AM, flex.muste...@gmail.com wrote: See http://localhost:8080/job/flex-sdk_mustella/258/changes Changes: [jmclean] updated to reflect recent changes [jmclean] Date updated for Apache Flex 4.10 RC4

Re: Build failed in Jenkins: flex-sdk_mustella #258

2013-08-04 Thread Justin Mclean
Hi I think the latest commits really broke a few tests... Quite likely there an issue with the tests. I'm not going to be able to look at it today but can tomorrow. Thanks, Justin