Re: Mustella data grid test failing

2013-05-15 Thread Justin Mclean
Hi, > Looks like you've found a way to detect that someone set sort=null without > calling refresh, which is good, but it seems like the ListCollectionView > is in an unsupported state at this point. I think the state is OK, and IMO you should be able to continue to add or remove items before cal

Re: Mustella data grid test failing

2013-05-15 Thread Alex Harui
OK, saw your changes. Looks like you've found a way to detect that someone set sort=null without calling refresh, which is good, but it seems like the ListCollectionView is in an unsupported state at this point. I'm just worried that there are other errors waiting to be found when in this state.

Re: Mustella data grid test failing

2013-05-15 Thread Justin Mclean
Hi, > So is your goal to restore Flex 2 behavior? No of course not. I was just pointing it out why some people did expect that sort = null should behave this way. It's not entirely unreasonable to expect that setting sort to null without a refresh would remove the sort but let keep it so a re

Re: Mustella data grid test failing

2013-05-15 Thread Alex Harui
Hi Justin, So is your goal to restore Flex 2 behavior? Honestly, I don't recall if refresh was required back then or not, but I think the code paths that require a call to refresh() after sort=null have been around as several releases. I'd rather just make sure that there is no undesirable behav

Re: Mustella data grid test failing

2013-05-15 Thread Justin Mclean
Hi, > But first, let's nail this sort=null thing. I can look into it if you > want. Just looking at it now. I've written a couple of dozen unit tests and have 3 failing in both ApacheFlex 4.10 that I think should pass. Leave it with me but so you get an idea this fails with an RTE:

Re: Mustella data grid test failing

2013-05-15 Thread Alex Harui
IMO, the DG is doing some serious cheating. One has to worry about others relying on this undocumented behavior. I don't like changing behavior on our customers, but I'm not sure everyone wants this behavior. But first, let's nail this sort=null thing. I can look into it if you want. On 5/15/1

Re: Mustella data grid test failing

2013-05-15 Thread Justin Mclean
Hi, > Yup, that's the one we discussed last night. The localIndex=null in the > sort setter is busting that test because the DG is counting on setting > sort to null and restoring it without calling refresh(). That explains it. I've looked into it and think you're correct in that refresh should

Re: Mustella data grid test failing

2013-05-15 Thread Alex Harui
Yup, that's the one we discussed last night. The localIndex=null in the sort setter is busting that test because the DG is counting on setting sort to null and restoring it without calling refresh(). Interestingly, I took out that sort hack and that test passed. I have those changes on my comput

Mustella data grid test failing

2013-05-15 Thread Justin Mclean
Hi, I'm getting this test failing - anyone confirm? gumbo/components/DataGrid/Properties/DataGrid_Properties_sortable column_withEditor_test002 Failed AssertMethodValue (method cannot be shown)(body:step 13) method returned AntFN, expected WilFN Thanks, Justin