Re: Quickstart POMs

2015-06-18 Thread Ufuk Celebi
On Thursday, June 18, 2015, Robert Metzger wrote: > Hi, > > I'm against cancelling a release for something that is not nice ;) It has > to be at least broken to cancel :) See vote thread +1. This was not about canceling but clearification. ;) > I agree that the pom looks complicated and I wou

Re: Quickstart POMs

2015-06-18 Thread Stephan Ewen
I remember we had a similar discussion a while back. The current solution is the best out-of-the-box experience for the quickstarts across Eclipse, IntelliJ, and command-line Maven. This is more important that nice and compact POM files, IMHO. On Thu, Jun 18, 2015 at 11:26 AM, Robert Metzger w

Re: Use bloom filter to improve hybrid hash join performance

2015-06-18 Thread Stephan Ewen
Hi! That is a very nice idea and a well proven optimization to the hybrid hash join. It would be a great if you could contribute that. The memory allocated for the hash buckets (holding hash codes and pointers) is currently wasted for those buckets where the partition of the bucket is spilled. Pu

Re: Quickstart POMs

2015-06-18 Thread Robert Metzger
Hi, I'm against cancelling a release for something that is not nice ;) It has to be at least broken to cancel :) I agree that the pom looks complicated and I would love to do it better, but in my opinion the current approach is giving our users the best out of the box experience. The right appro

Re: Quickstart POMs

2015-06-18 Thread Chiwan Park
Is it okay when the user runs the built jar in LocalEnvironment? (Just run with `java -jar` command.) I know that it is special case but it is a possible scenario for local testing. If we change Quickstart POM to use provided scope for dependencies, we should add a guide about this into document

Re: Quickstart POMs

2015-06-18 Thread Aljoscha Krettek
I'm also for simplification but let's hear what those who put the build-jar profile there have to say about it.? On Thu, 18 Jun 2015 at 17:25 Ufuk Celebi wrote: > > On 18 Jun 2015, at 16:58, Fabian Hueske wrote: > > > Why? > > > > mvn package > > > > builds the program correctly, no? > > Yes, b

Re: Quickstart POMs

2015-06-18 Thread Ufuk Celebi
On 18 Jun 2015, at 16:58, Fabian Hueske wrote: > Why? > > mvn package > > builds the program correctly, no? Yes, but: - Dependencies not specified by the user may be included (Metrics, javaassist) - Dependencies specified by the user may be excluded - If you use the build-jar profile you hav

[jira] [Created] (FLINK-2242) Deprecate RemoteCollector

2015-06-18 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-2242: -- Summary: Deprecate RemoteCollector Key: FLINK-2242 URL: https://issues.apache.org/jira/browse/FLINK-2242 Project: Flink Issue Type: Improvement Compone

Re: Quickstart POMs

2015-06-18 Thread Fabian Hueske
Why? mvn package builds the program correctly, no? On Jun 18, 2015 16:53, "Ufuk Celebi" wrote: > > On 18 Jun 2015, at 16:49, Fabian Hueske wrote: > > > I don't think that many users care about the internals of the quickstart > > pom file and are just happy if it works. > > I agree with this. T

Re: Quickstart POMs

2015-06-18 Thread Ufuk Celebi
On 18 Jun 2015, at 16:49, Fabian Hueske wrote: > I don't think that many users care about the internals of the quickstart > pom file and are just happy if it works. I agree with this. That's exactly why I think it's better to keep it clean; with the current pom you actually do have to worry ab

Re: Quickstart POMs

2015-06-18 Thread Fabian Hueske
I don't think that many users care about the internals of the quickstart pom file and are just happy if it works. I would not cancel the ongoing vote for that. We might fix it if the vote is canceled, but it has no priority, IMO. 2015-06-18 15:32 GMT+02:00 Ufuk Celebi : > Hey all, > > looking at

Re: [VOTE] Release Apache Flink 0.9.0 (release-0.9.0-rc4)

2015-06-18 Thread Ufuk Celebi
+1 Overall, I'm +1, but I'm wondering whether the quickstart poms need a clean up (I've started a discussion about this). My main concern is that they might confuse new users (two ways of doing essentially the same thing). Verified: # Legal - Check if checksums and GPG files match the corresp

Quickstart POMs

2015-06-18 Thread Ufuk Celebi
Hey all, looking at the quickstarts for the upcoming release, I am a little confused: We use the shade plugin to build a fat jar and exclude some of Flink's dependencies (actual and transitive). Then we have a build profile (build-jar), which sets the Flink dependencies to provided. 1. Is ther

Re: [VOTE] Release Apache Flink 0.9.0 (release-0.9.0-rc4)

2015-06-18 Thread Aljoscha Krettek
+1 I tested each of the previous RCs, as can be read in our Google Doc release documents. Now, I also ran tests with Kafka/Checkpointing on a GCE cluster. Checkpoints are correctly restored when a Job fails. I killed task managers, the job restarted and checkpoints were restored. I killed Kafka Br

[VOTE] Release Apache Flink 0.9.0 (release-0.9.0-rc4)

2015-06-18 Thread Maximilian Michels
Please vote on releasing the following candidate as Apache Flink version 0.9.0. - The commit to be voted on: 0a35271dba4675311eb3094d8669a876efd285a9 Branch: release-0.9.0-rc4 ( https://git1-us-west.apache.org/repos/asf/flink/?p=flink.gi

Use bloom filter to improve hybrid hash join performance

2015-06-18 Thread Li, Chengxiang
Hi, flink developers I read the flink hybrid hash join documents and implementation, very nice job. For the case of small table does not all fit into memory, I think we may able to improve the performance better. Currently in hybrid hash join, while small table does not fit into memory, part o

[jira] [Created] (FLINK-2241) Use BloomFilter to minmize build side records which spilled to disk in Hybrid-Hash-Join

2015-06-18 Thread Chengxiang Li (JIRA)
Chengxiang Li created FLINK-2241: Summary: Use BloomFilter to minmize build side records which spilled to disk in Hybrid-Hash-Join Key: FLINK-2241 URL: https://issues.apache.org/jira/browse/FLINK-2241

[jira] [Created] (FLINK-2240) Use BloomFilter to minmize build side records which spilled to disk in Hybrid-Hash-Join

2015-06-18 Thread Chengxiang Li (JIRA)
Chengxiang Li created FLINK-2240: Summary: Use BloomFilter to minmize build side records which spilled to disk in Hybrid-Hash-Join Key: FLINK-2240 URL: https://issues.apache.org/jira/browse/FLINK-2240

[VOTE] [CANCELLED] Release Apache Flink 0.9.0 (release-0.9.0-rc3)

2015-06-18 Thread Maximilian Michels
Due to concerns raised about the quality of the release candidate, I cancel the vote for "release-0.9.0-rc3". On Thu, Jun 18, 2015 at 10:24 AM, Till Rohrmann wrote: > +1 for reverting. > > On Thu, Jun 18, 2015 at 10:11 AM Aljoscha Krettek > wrote: > > > +1 I also think it's the cleanest solutio

[jira] [Created] (FLINK-2239) print() on DataSet: stream results and print incrementally

2015-06-18 Thread Maximilian Michels (JIRA)
Maximilian Michels created FLINK-2239: - Summary: print() on DataSet: stream results and print incrementally Key: FLINK-2239 URL: https://issues.apache.org/jira/browse/FLINK-2239 Project: Flink

[jira] [Created] (FLINK-2238) Scala ExecutionEnvironment.fromCollection does not work with Sets

2015-06-18 Thread Fabian Hueske (JIRA)
Fabian Hueske created FLINK-2238: Summary: Scala ExecutionEnvironment.fromCollection does not work with Sets Key: FLINK-2238 URL: https://issues.apache.org/jira/browse/FLINK-2238 Project: Flink

Re: [VOTE] Release Apache Flink 0.9.0 (release-0.9.0-rc3)

2015-06-18 Thread Till Rohrmann
+1 for reverting. On Thu, Jun 18, 2015 at 10:11 AM Aljoscha Krettek wrote: > +1 I also think it's the cleanest solution for now. The table API still > works, just without support for null values. > > On Thu, 18 Jun 2015 at 10:08 Maximilian Michels wrote: > > > I also vote for reverting the Tabl

Re: [VOTE] Release Apache Flink 0.9.0 (release-0.9.0-rc3)

2015-06-18 Thread Aljoscha Krettek
+1 I also think it's the cleanest solution for now. The table API still works, just without support for null values. On Thu, 18 Jun 2015 at 10:08 Maximilian Michels wrote: > I also vote for reverting the Table API changes. > > On Wed, Jun 17, 2015 at 6:16 PM, Ufuk Celebi wrote: > > > > > On 17

Re: [VOTE] Release Apache Flink 0.9.0 (release-0.9.0-rc3)

2015-06-18 Thread Maximilian Michels
I also vote for reverting the Table API changes. On Wed, Jun 17, 2015 at 6:16 PM, Ufuk Celebi wrote: > > On 17 Jun 2015, at 18:05, Aljoscha Krettek wrote: > > > -1 > > > > There is a bug in the newly introduced Null-Value support in > RowSerializer: > > The serializer was changed to write boole

Re: Shading artifact name

2015-06-18 Thread Maximilian Michels
Yes, or TO_BE_REPLACED. On Thu, Jun 18, 2015 at 7:58 AM, Henry Saputra wrote: > Like with REPLACE_ME ? > > On Tue, Jun 16, 2015 at 4:57 AM, Maximilian Michels > wrote: > > We could replace the placeholder "error" with something more meaningful > > though... > > > > On Tue, Jun 16, 2015 at 1:27