Re: Static code analysis for Flink project

2018-06-14 Thread Till Rohrmann
Looking at some of the bugs then these things are all valid problems. For example, the RowTypeInfo does override hashCode but not equals. Or the RocksDBKeyedStateBackend tries to close streams which might be null in case of an exception. I agree that we won't fix all the problems at once and it wil

Re: [DISCUSS] Long-term goal of making flink-table Scala-free

2018-06-14 Thread Till Rohrmann
I think that is a noble and honorable goal and we should strive for it. This, however, must be an iterative process given the sheer size of the code base. I like the approach to define common Java modules which are used by more specific Scala modules and slowly moving classes from Scala to Java. Th

[jira] [Created] (FLINK-9584) Unclosed streams in Bucketing-/RollingSink

2018-06-14 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-9584: --- Summary: Unclosed streams in Bucketing-/RollingSink Key: FLINK-9584 URL: https://issues.apache.org/jira/browse/FLINK-9584 Project: Flink Issue Type: Bu

[jira] [Created] (FLINK-9585) Logger in ZooKeeperStateHandleStore is public and non-final

2018-06-14 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-9585: --- Summary: Logger in ZooKeeperStateHandleStore is public and non-final Key: FLINK-9585 URL: https://issues.apache.org/jira/browse/FLINK-9585 Project: Flink

[jira] [Created] (FLINK-9586) Make collection sources parallelisable

2018-06-14 Thread Sina Madani (JIRA)
Sina Madani created FLINK-9586: -- Summary: Make collection sources parallelisable Key: FLINK-9586 URL: https://issues.apache.org/jira/browse/FLINK-9586 Project: Flink Issue Type: Wish C

Re: Static code analysis for Flink project

2018-06-14 Thread Joern Kottmann
Hello, we introduced static code analysis 2 years back at Apache OpenNLP. To make this work with our also not perfect code base we added the checker to the build to make the build fail, then we disabled all checks which caused failures (or fixed them), afterwards we worked on resolving the issues,

[jira] [Created] (FLINK-9587) ContinuousFileMonitoringFunction crashes on short living files

2018-06-14 Thread Andrei Shumanski (JIRA)
Andrei Shumanski created FLINK-9587: --- Summary: ContinuousFileMonitoringFunction crashes on short living files Key: FLINK-9587 URL: https://issues.apache.org/jira/browse/FLINK-9587 Project: Flink

Re: Static code analysis for Flink project

2018-06-14 Thread Chesnay Schepler
Note that we attempted the same thing with spotbugs in the past but no one actually enabled more checks and fixed issues. This isn't an argument against trying it again, but to anyone who wants to introduce static checks again: Please be aware that you may end up pretty much on your own in rega

Re: Static code analysis for Flink project

2018-06-14 Thread Joern Kottmann
I personally wouldn't mind digging a bit through the code and help a with fixing things. If there are some checks people feel are particular important let me know, happy to send a PR. Jörn On Thu, Jun 14, 2018 at 12:45 PM, Chesnay Schepler wrote: > Note that we attempted the same thing with spo

Re: [DISCUSS] Long-term goal of making flink-table Scala-free

2018-06-14 Thread Fabian Hueske
Hi, In general, I think this is a good effort. However, it won't be easy and I think we have to plan this well. I don't like the idea of having the whole code base fragmented into Java and Scala code for too long. I think we should do this one step at a time and focus on migrating one module at a

[jira] [Created] (FLINK-9588) Reuse the same conditionContext with in a same computationState

2018-06-14 Thread aitozi (JIRA)
aitozi created FLINK-9588: - Summary: Reuse the same conditionContext with in a same computationState Key: FLINK-9588 URL: https://issues.apache.org/jira/browse/FLINK-9588 Project: Flink Issue Type:

[ANNOUNCE] Registration for Flink Forward Berlin is open

2018-06-14 Thread Fabian Hueske
Hi everyone, *Flink Forward Berlin 2018 will take place from September 3rd to 5th.* The conference will start with one day of training and continue with two days of keynotes and talks. *The registration for Flink Forward Berlin 2018 is now open!* A limited amount of early-bird passes is available

[jira] [Created] (FLINK-9589) PythonOperationInfo should be immutable

2018-06-14 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-9589: --- Summary: PythonOperationInfo should be immutable Key: FLINK-9589 URL: https://issues.apache.org/jira/browse/FLINK-9589 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-9590) HistogramDump should be immutable

2018-06-14 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-9590: --- Summary: HistogramDump should be immutable Key: FLINK-9590 URL: https://issues.apache.org/jira/browse/FLINK-9590 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-9591) Remove remnants of distributed-cache logic

2018-06-14 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-9591: --- Summary: Remove remnants of distributed-cache logic Key: FLINK-9591 URL: https://issues.apache.org/jira/browse/FLINK-9591 Project: Flink Issue Type: Bu

[jira] [Created] (FLINK-9592) Notify on moving into pending/ final state

2018-06-14 Thread Rinat Sharipov (JIRA)
Rinat Sharipov created FLINK-9592: - Summary: Notify on moving into pending/ final state Key: FLINK-9592 URL: https://issues.apache.org/jira/browse/FLINK-9592 Project: Flink Issue Type: New Fe