Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-17 Thread 陈梓立
Hi all interested, Within the document there is a heated discussion about how the PR template/review template should be. Here share my opinion: 1. For the review template, actually we don't need comment a review template at all. GitHub has a tag system and only committer could add tags, which

[jira] [Created] (FLINK-10360) support timeout in savepoint REST api

2018-09-17 Thread Steven Zhen Wu (JIRA)
Steven Zhen Wu created FLINK-10360: -- Summary: support timeout in savepoint REST api Key: FLINK-10360 URL: https://issues.apache.org/jira/browse/FLINK-10360 Project: Flink Issue Type:

Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-17 Thread Rong Rong
Thanks for putting the review contribution doc together, Stephan! This will definitely help the community to make the review process better. >From my experience this will benefit on both contributors and reviewers side! Thus +1 for putting into practice as well. -- Rong On Mon, Sep 17, 2018 at

[jira] [Created] (FLINK-10359) Scala example in DataSet docs is broken

2018-09-17 Thread Fabian Hueske (JIRA)
Fabian Hueske created FLINK-10359: - Summary: Scala example in DataSet docs is broken Key: FLINK-10359 URL: https://issues.apache.org/jira/browse/FLINK-10359 Project: Flink Issue Type: Bug

Re: [DISCUSS] Release Flink 1.5.4 and 1.6.1

2018-09-17 Thread Elias Levy
Probably. I was hesitant to move to 1.5 without significant testing, as we run in standalone mode and 1.5 introduced significant changes as a result of FLIP-6. But if the community hasn't seen major regressions in 1.5 running in legacy mode, then that may be feasible. On Mon, Sep 17, 2018 at

Re: CEP & checkpoints/savepoints

2018-09-17 Thread Fabian Hueske
Hi Ron, The CEP library is built on top of the DataStream / ProcessFunction API and holds all necessary state (the state of the pattern matching state machine) in regular keyed MapState. Hence, CEP does not require a dedicated configuration for checkpoints and savepoints, besides the regular

[jira] [Created] (FLINK-10358) Flink kinesis connector could throw NPE during getRecords() call

2018-09-17 Thread Ying Xu (JIRA)
Ying Xu created FLINK-10358: --- Summary: Flink kinesis connector could throw NPE during getRecords() call Key: FLINK-10358 URL: https://issues.apache.org/jira/browse/FLINK-10358 Project: Flink

Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-17 Thread Stephan Ewen
Hi! Thanks you for the encouraging feedback so far. The overall goal is definitely to make the contribution process better and get fewer pull requests that are disregarded. There are various reasons for the disregarded pull requests, one being that fewer committers really participate in reviews

CEP & checkpoints/savepoints

2018-09-17 Thread Ron Crocker
I’m working with CEP to detect when something stops reporting (which is very simple), but I need to show the team that the jobs will survive being shutdown and restarted without either a) declaring that everything stopped reporting (false positives) or b) missing things that have indeed stopped

[jira] [Created] (FLINK-10357) Streaming File Sink end-to-end test failed with mismatch

2018-09-17 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-10357: - Summary: Streaming File Sink end-to-end test failed with mismatch Key: FLINK-10357 URL: https://issues.apache.org/jira/browse/FLINK-10357 Project: Flink

[ANNOUNCE] Weekly community update #38

2018-09-17 Thread Till Rohrmann
Dear community, this is the weekly community update thread #38. Please post any news and updates you want to share with the community to this thread. # Release vote for Flink 1.6.1 and 1.5.4 The community is currently voting on the next bug fix releases Flink 1.6.1 [1] and Flink 1.5.4 [2].

[jira] [Created] (FLINK-10356) Add sanity checks to SpillingAdaptiveSpanningRecordDeserializer

2018-09-17 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-10356: --- Summary: Add sanity checks to SpillingAdaptiveSpanningRecordDeserializer Key: FLINK-10356 URL: https://issues.apache.org/jira/browse/FLINK-10356 Project: Flink

[jira] [Created] (FLINK-10355) The order of the column should start from 1.

2018-09-17 Thread lihongli (JIRA)
lihongli created FLINK-10355: Summary: The order of the column should start from 1. Key: FLINK-10355 URL: https://issues.apache.org/jira/browse/FLINK-10355 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-10354) Savepoints should be counted as retained checkpoints

2018-09-17 Thread Dawid Wysakowicz (JIRA)
Dawid Wysakowicz created FLINK-10354: Summary: Savepoints should be counted as retained checkpoints Key: FLINK-10354 URL: https://issues.apache.org/jira/browse/FLINK-10354 Project: Flink

[jira] [Created] (FLINK-10353) Restoring a KafkaProducer with Semantic.EXACTLY_ONCE from a savepoint written with Semantic.AT_LEAST_ONCE fails with NPE

2018-09-17 Thread Konstantin Knauf (JIRA)
Konstantin Knauf created FLINK-10353: Summary: Restoring a KafkaProducer with Semantic.EXACTLY_ONCE from a savepoint written with Semantic.AT_LEAST_ONCE fails with NPE Key: FLINK-10353 URL:

回复:[PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-17 Thread Zhijiang(wangzhijiang999)
From my personal experience as a contributor for three years, I feel better experience in contirbuting or reviewing than before, although we still have some points for further progress. I reviewed the proposal doc, and it gives very constructive and meaningful guides which could help both

[jira] [Created] (FLINK-10352) Bind Task's URLClassLoader to TaskExecutor's slot

2018-09-17 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-10352: - Summary: Bind Task's URLClassLoader to TaskExecutor's slot Key: FLINK-10352 URL: https://issues.apache.org/jira/browse/FLINK-10352 Project: Flink Issue

Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-17 Thread 陈梓立
Hi Stephan, Thanks for raising this discussion and the previous work! I strongly support effort to improve the process of contributions and reviews. As you mentioned above, Flink community responses to contributions a bit inefficiently, both for latency and quality. In my opinion the most

Re: [DISCUSS] Release Flink 1.5.4 and 1.6.1

2018-09-17 Thread Till Rohrmann
Would you be able to upgrade to Flink 1.5.4 or 1.6.1 using Flink's legacy mode @Elias? The legacy mode should have the same behaviour as Flink 1.4-SNAPSHOT and thus a potential Flink 1.4.3. I'm a bit hesitant to make another 1.4 release, because in 1.4 we didn't have many automated e2e tests.

Re: [PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-17 Thread Till Rohrmann
Thanks for writing this up Stephan. I like the steps and hope that it will help the community to make the review process better. Thus, +1 for putting your proposal to practice. Cheers, Till On Mon, Sep 17, 2018 at 10:00 AM Stephan Ewen wrote: > Hi Flink community members! > > As many of you

Re: spring boot application load to flink 1.5.1

2018-09-17 Thread Till Rohrmann
Hi, please provide a little bit more context (logs, full exception stack trace). Otherwise we won't be able to help you. It would be good to post these kind of questions on u...@flink.apache.org because dev@flink is intended to be used for Flink development discussions. Cheers, Till On Mon,

[PROPOSAL] [community] A more structured approach to reviews and contributions

2018-09-17 Thread Stephan Ewen
Hi Flink community members! As many of you will have noticed, the Flink project activity has gone up again quite a bit. There are many more contributions, which is an absolutely great thing to have :-) However, we see a continuously growing backlog of pull requests and JIRA issues. To make sure

spring boot application load to flink 1.5.1

2018-09-17 Thread flink-stgo-qba
dear friends: in my job is installed the flink 1.5.1 and publish web in http://:8081 i build a spring boot application and use a custom properties with my data. when submit muy job the web how this error *We're sorry,