Re: [DISCUSS] FLIP-35: Support Chinese Documents & Website and Improve Translation Specification

2019-02-22 Thread Jark Wu
Hi, Thank you all for the feedback on the translation specifications. I have moved the google doc into wiki page: https://cwiki.apache.org/confluence/display/FLINK/Flink+Translation+Specifications Please feel free to continue give feedback in the google doc. I will update it to wiki regularly.

Re: Where does RocksDB's mem allocation occur

2019-02-22 Thread Yun Tang
Hi Roshan >From our experience, RocksDB memory allocation actually cannot be controlled >well from Flink's side. The option containerized.heap-cutoff-ratio is mainly used to calculate JVM heap size, and the left part is treated as off-heap size. In perfect situation, RocksDB's memory should dep

[jira] [Created] (FLINK-11732) Add a language switch to the sidebar for Flink documents

2019-02-22 Thread Jark Wu (JIRA)
Jark Wu created FLINK-11732: --- Summary: Add a language switch to the sidebar for Flink documents Key: FLINK-11732 URL: https://issues.apache.org/jira/browse/FLINK-11732 Project: Flink Issue Type: Su

Where does RocksDB's mem allocation occur

2019-02-22 Thread Roshan Naik
For yarn deployments,  Lets say you have  lets say the container size = 10 GB containerized.heap-cutoff-ratio = 0.3  ( = 3GB) That means 7GB is available for Flinks various subsystems which include,= jvm heap, and all the DirectByteBufferAllocatins (netty + netw buff + .. ) and Java metadata.  I

[jira] [Created] (FLINK-11731) Make DefaultOperatorStateBackend follow the builder pattern

2019-02-22 Thread Yu Li (JIRA)
Yu Li created FLINK-11731: - Summary: Make DefaultOperatorStateBackend follow the builder pattern Key: FLINK-11731 URL: https://issues.apache.org/jira/browse/FLINK-11731 Project: Flink Issue Type: Su

[jira] [Created] (FLINK-11730) Make HeapKeyedStateBackend follow the builder pattern

2019-02-22 Thread Yu Li (JIRA)
Yu Li created FLINK-11730: - Summary: Make HeapKeyedStateBackend follow the builder pattern Key: FLINK-11730 URL: https://issues.apache.org/jira/browse/FLINK-11730 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-11729) Make all state backends follow builder pattern

2019-02-22 Thread Yu Li (JIRA)
Yu Li created FLINK-11729: - Summary: Make all state backends follow builder pattern Key: FLINK-11729 URL: https://issues.apache.org/jira/browse/FLINK-11729 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-11728) Deprecate CalciteConfig temporarily

2019-02-22 Thread Timo Walther (JIRA)
Timo Walther created FLINK-11728: Summary: Deprecate CalciteConfig temporarily Key: FLINK-11728 URL: https://issues.apache.org/jira/browse/FLINK-11728 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-11727) JSON row format is not serializable

2019-02-22 Thread Timo Walther (JIRA)
Timo Walther created FLINK-11727: Summary: JSON row format is not serializable Key: FLINK-11727 URL: https://issues.apache.org/jira/browse/FLINK-11727 Project: Flink Issue Type: Bug

Re: Apply for contributor permission

2019-02-22 Thread Fabian Hueske
Hi, Welcome to the Flink community! I've given you contributor permissions for Jira. Best, Fabian Am Fr., 22. Feb. 2019 um 07:05 Uhr schrieb derek.wu : > Hi, > > I want to contribute to Apache Flink. > Would you please give me the contributor permission? > My JIRA ID is derek.wq > > > Derek Wu

Re: [DISCUSS] Improve the flinkbot

2019-02-22 Thread Robert Metzger
Ah, I didn't get that. I thought you only wanted to show ❓ instead of ❌. Maybe the "disapprove" command is also a bit misleading. What it actually means is just "remove approval". On Fri, Feb 22, 2019 at 2:29 PM Chesnay Schepler wrote: > 3 states for each step is effectively what I've been sug

Re: [DISCUSS] FLIP-33: Standardize connector metrics

2019-02-22 Thread Chesnay Schepler
Re: over complication of implementation. I think I get understand better know what you're shooting for, effectively something like the OperatorIOMetricGroup. But still, re-define setupConnectorMetrics() to accept a set of flags for counters/meters(ans _possibly_ histograms) along with a set of

Re: [DISCUSS] Improve the flinkbot

2019-02-22 Thread Chesnay Schepler
3 states for each step is effectively what I've been suggesting at the very start. (initialize with question mark instead of red cross) On 22.02.2019 14:19, Robert Metzger wrote: I will try to deploy the first version using labels today. Here are my responses to your comments: The emojis

Re: [DISCUSS] Improve the flinkbot

2019-02-22 Thread Dawid Wysakowicz
Wasn't Chesnay's comment suggesting 3 states as well?: > 1) By default the bot shows a big red X next to every item; I'd prefer a > question mark here as this allows us to differentiate between rejected > and unaddressed points. It's also a bit nicer for contributors imo as it > does not have such

Re: [DISCUSS] Improve the flinkbot

2019-02-22 Thread Robert Metzger
I will try to deploy the first version using labels today. Here are my responses to your comments: The emojis seem unnecessary, the approved label could be shorted to > "Approved"; the > review prefix isn't necessary here imo. My idea was that each system (review bot, component labeler, size es

Re: [DISCUSS] FLIP-33: Standardize connector metrics

2019-02-22 Thread Becket Qin
Hi Chesnay, Thanks for the explanation. ** Re: FLIP I might have misunderstood this, but it seems that "major changes" are well defined in FLIP. The full contents is following: What is considered a "major change" that needs a FLIP? Any of the following should be considered a major change: -

Re: [DISCUSS] Improve the flinkbot

2019-02-22 Thread Chesnay Schepler
The bot could check the diff and tag pull requests that only touch the docs as "Documentation". Many of these are easy to review and usually don't require a deeper understanding of Flink. On 13.02.2019 10:29, Robert Metzger wrote: Hey all, the flinkbot has been active for a week now, and I ho

Re: [DISCUSS] Releasing Flink 1.8 / Feature Freeze

2019-02-22 Thread Robert Metzger
Hey, are we doing a feature freeze today? On Mon, Feb 18, 2019 at 9:52 AM Tzu-Li (Gordon) Tai wrote: > Hi Robert, > > Regarding FLINK-10776 - Update migration tests for Flink 1.7: > There's still one last test class that needs to be migrated (progress > reflected in the list of subtasks of FLINK

[jira] [Created] (FLINK-11726) Refactor the creation of ResultPartition and InputGate into NetworkEnvironment

2019-02-22 Thread zhijiang (JIRA)
zhijiang created FLINK-11726: Summary: Refactor the creation of ResultPartition and InputGate into NetworkEnvironment Key: FLINK-11726 URL: https://issues.apache.org/jira/browse/FLINK-11726 Project: Flink

[ANNOUNCE] Checkstyle bump

2019-02-22 Thread Chesnay Schepler
Hello all, the checkstyle version has been bumped to 8.12. If you're checkstyle in IntelliJ (according to out guide ) then you also have to manually set the version in IntelliJ to 8.12, as desc

[jira] [Created] (FLINK-11725) use flink cli when {{-yn}} * {{-ys}} < {{-p}}, the applied resources are erratic

2019-02-22 Thread shengjk1 (JIRA)
shengjk1 created FLINK-11725: Summary: use flink cli when {{-yn}} * {{-ys}} < {{-p}}, the applied resources are erratic Key: FLINK-11725 URL: https://issues.apache.org/jira/browse/FLINK-11725 Project: F

Re: [DISCUSS] FLIP-33: Standardize connector metrics

2019-02-22 Thread Chesnay Schepler
Re: Flip The very first line under both the main header and Purpose section describe Flips as "major changes", which this isn't. Re: complication I'm not arguing against standardization, but again an over-complicated implementation when a static utility method would be sufficient. public stati

[jira] [Created] (FLINK-11724) Improve MemorySegment

2019-02-22 Thread Jingsong Lee (JIRA)
Jingsong Lee created FLINK-11724: Summary: Improve MemorySegment Key: FLINK-11724 URL: https://issues.apache.org/jira/browse/FLINK-11724 Project: Flink Issue Type: Improvement Compo