Re: [DISCUSS] FLIP-171: Async Sink

2021-06-29 Thread Piotr Nowojski
Thanks for addressing this issue :) Best, Piotrek wt., 29 cze 2021 o 17:58 Hausmann, Steffen napisał(a): > Hey Poitr, > > I've just adapted the FLIP and changed the signature for the > `submitRequestEntries` method: > > protected abstract void submitRequestEntries(List > requestEntries, ResultF

Re: [DISCUSS] Do not merge PRs with "unrelated" test failures.

2021-06-29 Thread tison
Hi, There are a number of PRs modifying docs only, but we still require all tests passed on that. It is a good proposal we avoid merge PR with "unrelated" failure, but can we improve the case where the contributor only works for docs? For example, base on the file change set, run doc tests only.

Re: [DISCUSS] Do not merge PRs with "unrelated" test failures.

2021-06-29 Thread godfrey he
+1 for the proposal. Thanks Xintong! Best, Godfrey Rui Li 于2021年6月30日周三 上午11:36写道: > Thanks Xintong. +1 to the proposal. > > On Tue, Jun 29, 2021 at 11:05 AM 刘建刚 wrote: > > > +1 for the proposal. Since the test time is long and environment may > vary, > > unstable tests are really annoying f

[jira] [Created] (FLINK-23190) Make task-slot allocation much more evenly

2021-06-29 Thread loyi (Jira)
loyi created FLINK-23190: Summary: Make task-slot allocation much more evenly Key: FLINK-23190 URL: https://issues.apache.org/jira/browse/FLINK-23190 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-23189) Count and fail the task when the disk is error on JobManager

2021-06-29 Thread zlzhang0122 (Jira)
zlzhang0122 created FLINK-23189: --- Summary: Count and fail the task when the disk is error on JobManager Key: FLINK-23189 URL: https://issues.apache.org/jira/browse/FLINK-23189 Project: Flink I

Re: [DISCUSS] Do not merge PRs with "unrelated" test failures.

2021-06-29 Thread Rui Li
Thanks Xintong. +1 to the proposal. On Tue, Jun 29, 2021 at 11:05 AM 刘建刚 wrote: > +1 for the proposal. Since the test time is long and environment may vary, > unstable tests are really annoying for developers. The solution is welcome. > > Best > liujiangang > > Jingsong Li 于2021年6月29日周二 上午10:31

?????? [DISCUSS] FLIP-171: Async Sink

2021-06-29 Thread 123052475
--  -- ??: "Hausmann, Steffen"mailto:trohrm...@apache.org>>; napisa?0?0(a):     Adding the InterruptException to the write method would make it explicit that the write call can block but must react to interruptions (e.g. when Flink wants to can

[jira] [Created] (FLINK-23188) Unsupported function definition: IFNULL. Only user defined functions are supported as inline functions

2021-06-29 Thread xiaojin.wy (Jira)
xiaojin.wy created FLINK-23188: -- Summary: Unsupported function definition: IFNULL. Only user defined functions are supported as inline functions Key: FLINK-23188 URL: https://issues.apache.org/jira/browse/FLINK-23188

Re: [DISCUSS] Feedback Collection Jira Bot

2021-06-29 Thread Stephan Ewen
Being a bit late to the party, and don't want to ask to change everything, just maybe some observation. My main observation and concern is still that this puts pressure and confusion on contributors, which are mostly blocked on committers for reviews, or are taking tickets as multi-week projects.

[jira] [Created] (FLINK-23187) [Documentation] PubSubSink should use "withTopicName" rather than "withSubscriptionName"

2021-06-29 Thread Jared Wasserman (Jira)
Jared Wasserman created FLINK-23187: --- Summary: [Documentation] PubSubSink should use "withTopicName" rather than "withSubscriptionName" Key: FLINK-23187 URL: https://issues.apache.org/jira/browse/FLINK-23187

Re: [DISCUSS] Dashboard/HistoryServer authentication

2021-06-29 Thread Austin Cawley-Edwards
Hi all, Thanks for the updated proposal. I have a few questions about the API, please see below. * What stability semantics do you envision for this API? * Does Flink expose dependencies’ APIs in other places? Since this exposes the Netty API, will this make it difficult to upgrade Netty? * I sha

[jira] [Created] (FLINK-23186) Update "Local Installation" page

2021-06-29 Thread Daisy Tsang (Jira)
Daisy Tsang created FLINK-23186: --- Summary: Update "Local Installation" page Key: FLINK-23186 URL: https://issues.apache.org/jira/browse/FLINK-23186 Project: Flink Issue Type: Improvement

Re: [DISCUSS] FLIP-171: Async Sink

2021-06-29 Thread Hausmann, Steffen
Hey Poitr, I've just adapted the FLIP and changed the signature for the `submitRequestEntries` method: protected abstract void submitRequestEntries(List requestEntries, ResultFuture requestResult); In addition, we are likely to use an AtomicLong to track the number of outstanding requests, as

[jira] [Created] (FLINK-23185) REST API docs refer to removed rescaling endpoints

2021-06-29 Thread Juha (Jira)
Juha created FLINK-23185: Summary: REST API docs refer to removed rescaling endpoints Key: FLINK-23185 URL: https://issues.apache.org/jira/browse/FLINK-23185 Project: Flink Issue Type: Bug

Re: [DISCUSS] Moving to JUnit5

2021-06-29 Thread Arvid Heise
Hi Qingsheng, I like the idea of enforcing JUnit5 tests with checkstyle. I'm assuming JUnit4 will bleed from time to time into the test classpath. Obviously, we can only do that after all tests are migrated and we are confident that no small change would require a contributor to do the migration

Re: [DISCUSS] Dashboard/HistoryServer authentication

2021-06-29 Thread Márton Balassi
Hi all, I commend Konstantin and Till when it comes to standing up for the community values. Based on your feedback we are withdrawing the original proposal and attaching a more general custom netty handler API proposal [1] written by G. The change necessary to the Flink repository is approximate

[jira] [Created] (FLINK-23184) CompileException Assignment conversion not possible from type "int" to type "short"

2021-06-29 Thread xiaojin.wy (Jira)
xiaojin.wy created FLINK-23184: -- Summary: CompileException Assignment conversion not possible from type "int" to type "short" Key: FLINK-23184 URL: https://issues.apache.org/jira/browse/FLINK-23184 Proje

[jira] [Created] (FLINK-23183) Lost ACKs for redelivered messages in RMQSource

2021-06-29 Thread Jira
Michał Ciesielczyk created FLINK-23183: -- Summary: Lost ACKs for redelivered messages in RMQSource Key: FLINK-23183 URL: https://issues.apache.org/jira/browse/FLINK-23183 Project: Flink

[jira] [Created] (FLINK-23182) Connection leak in RMQSource

2021-06-29 Thread Jira
Michał Ciesielczyk created FLINK-23182: -- Summary: Connection leak in RMQSource Key: FLINK-23182 URL: https://issues.apache.org/jira/browse/FLINK-23182 Project: Flink Issue Type: Sub-tas

Re: [DISCUSS] Moving to JUnit5

2021-06-29 Thread Qingsheng Ren
Thanks for wrapping things up and effort on the migration Arvid! I’m +1 for the migration plan. To summarize the migration path proposed by Arvid: 1. Remove JUnit 4 dependency and introduce junit5-vintage-engine in the project (all existing cases will still work) 2. Rewrite JUnit 4 rules in JUn

[jira] [Created] (FLINK-23181) Add support for multi hop window

2021-06-29 Thread Aitozi (Jira)
Aitozi created FLINK-23181: -- Summary: Add support for multi hop window Key: FLINK-23181 URL: https://issues.apache.org/jira/browse/FLINK-23181 Project: Flink Issue Type: New Feature Compo

[jira] [Created] (FLINK-23180) Initialize checkpoint location lazily in DataStream Batch Jobs

2021-06-29 Thread Jiayi Liao (Jira)
Jiayi Liao created FLINK-23180: -- Summary: Initialize checkpoint location lazily in DataStream Batch Jobs Key: FLINK-23180 URL: https://issues.apache.org/jira/browse/FLINK-23180 Project: Flink I

[jira] [Created] (FLINK-23179) Support PIVOT and UNPIVOT

2021-06-29 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-23179: Summary: Support PIVOT and UNPIVOT Key: FLINK-23179 URL: https://issues.apache.org/jira/browse/FLINK-23179 Project: Flink Issue Type: New Feature

[jira] [Created] (FLINK-23178) Raise an error for writing stream data into partitioned hive/FS tables without a partition committer

2021-06-29 Thread Rui Li (Jira)
Rui Li created FLINK-23178: -- Summary: Raise an error for writing stream data into partitioned hive/FS tables without a partition committer Key: FLINK-23178 URL: https://issues.apache.org/jira/browse/FLINK-23178

Re: Flink 1.14. Bi-weekly 2021-06-22

2021-06-29 Thread Yu Li
Thanks for taking care of this, Joe! The information is very helpful! Best Regards, Yu On Mon, 28 Jun 2021 at 18:40, Till Rohrmann wrote: > Thanks a lot for the update, Joe. This is very helpful! > > Cheers, > Till > > On Mon, Jun 28, 2021 at 10:10 AM Xintong Song > wrote: > > > Thanks for th