Re: [VOTE] FLIP-224: Blocklist Mechanism

2022-05-26 Thread Chesnay Schepler
-1 to put a lid on things for now, because I'm not quite done yet with the discussion. On 27/05/2022 05:25, Yangze Guo wrote: +1 (binding) Best, Yangze Guo On Thu, May 26, 2022 at 3:54 PM Yun Gao wrote: Thanks Lijie and Zhu for driving the FLIP! The blocked list functionality helps reduce

Re: [DISCUSS] FLIP-232: Add Retry Support For Async I/O In DataStream API

2022-05-26 Thread Jark Wu
Thanks, Lincoln, the updated comments look good to me. Best, Jark On Fri, 27 May 2022 at 14:21, Lincoln Lee wrote: > Hi Jark & developers, > > I'm fine with this, and minor changes: > > "timeout from first invoke to final completion of asynchronous operation, > may include multiple retries, and

Re: [DISCUSS] FLIP-232: Add Retry Support For Async I/O In DataStream API

2022-05-26 Thread Lincoln Lee
Hi Jark & developers, I'm fine with this, and minor changes: "timeout from first invoke to final completion of asynchronous operation, may include multiple retries, and will be reset in case of failover" The FLIP[1] was updated including two changes: 1. generic type naming, use OUT instead of T

Re: [DISCUSS] FLIP-234: Support Retryable Lookup Join To Solve Delayed Updates Issue In External Systems

2022-05-26 Thread Jingsong Li
Thanks Lincoln for your proposal. Take a look at `strategy: fixed-delay delay: duration, e.g., 10s max-attempts: integer, e.g., 3`. Are these options only for async? It looks like normal lookups work too? One thing is: most of the lookup functions seem to be synchronous now? There are not so man

Re: [VOTE] FLIP-224: Blocklist Mechanism

2022-05-26 Thread Yangze Guo
+1 (binding) Best, Yangze Guo On Thu, May 26, 2022 at 3:54 PM Yun Gao wrote: > > Thanks Lijie and Zhu for driving the FLIP! > > The blocked list functionality helps reduce the complexity in maintenance > and the currently design looks good to me, thus +1 from my side (binding). > > > Best, > Yun

Re: [VOTE] FLIP-235: Hybrid Shuffle Mode

2022-05-26 Thread Yangze Guo
+1 Best, Yangze Guo On Thu, May 26, 2022 at 4:42 PM Xintong Song wrote: > > +1 > > Best, > > Xintong > > > > On Thu, May 26, 2022 at 3:47 PM weijie guo > wrote: > > > Hi everyone, > > > > Thanks for the feedback for FLIP-235: Hybrid Shuffle Mode[1] on the > > discussion thread [2] > > > > I'd l

Re: [VOTE] FLIP-168: Speculative Execution for Batch Job

2022-05-26 Thread Guowei Ma
+1 (binding) Best, Guowei On Fri, May 27, 2022 at 12:41 AM Shqiprim Bunjaku wrote: > +1 (non-binding) > > Best Regards > Shqiprim > > On Thu, May 26, 2022 at 6:22 PM rui fan <1996fan...@gmail.com> wrote: > > > Hi > > > > +1(non-binding), it’s very useful for batch job stability. > > > > Best wi

Re: [DISCUSS] FLIP-221 Abstraction for lookup source cache and metric

2022-05-26 Thread Jingsong Li
Thanks Qingsheng and all for your discussion. Very sorry to jump in so late. Maybe I missed something? My first impression when I saw the cache interface was, why don't we provide an interface similar to guava cache [1], on top of guava cache, caffeine also makes extensions for asynchronous calls

[jira] [Created] (FLINK-27807) The improvement of addBatch is empty when jdbc batch submit

2022-05-26 Thread shmily (Jira)
shmily created FLINK-27807: -- Summary: The improvement of addBatch is empty when jdbc batch submit Key: FLINK-27807 URL: https://issues.apache.org/jira/browse/FLINK-27807 Project: Flink Issue Type:

[jira] [Created] (FLINK-27806) Datagen add binary & varbinary type support

2022-05-26 Thread Ran Tao (Jira)
Ran Tao created FLINK-27806: --- Summary: Datagen add binary & varbinary type support Key: FLINK-27806 URL: https://issues.apache.org/jira/browse/FLINK-27806 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-27805) Bump ORC version to 1.7.2

2022-05-26 Thread jia liu (Jira)
jia liu created FLINK-27805: --- Summary: Bump ORC version to 1.7.2 Key: FLINK-27805 URL: https://issues.apache.org/jira/browse/FLINK-27805 Project: Flink Issue Type: Improvement Components:

Re: [VOTE] Apache Flink Kubernetes Operator Release 1.0.0, release candidate #2

2022-05-26 Thread Yang Wang
Thanks Jim for the testing. Could you please share the docker version you are using to build the image? It works well for "20.10.8". *COPY *.git ./.git* The above copy command should ignore the .git directory if it does not exist. Best, Yang Jim Busche 于2022年5月27日周五 02:57写道: > Hi Yang, > > >

Re: [VOTE] Apache Flink Kubernetes Operator Release 1.0.0, release candidate #2

2022-05-26 Thread Jim Busche
Hi Yang, I still see the git issue when trying to build from source: [1/2] STEP 16/19: COPY *.git ./.git Error: error building at STEP "COPY *.git ./.git": checking on sources under "/root/FLINK/release-1.0-rc2/flink-kubernetes-operator-1.0.0": Rel: can't make relative to /root/FLINK/release

Re: [VOTE] FLIP-168: Speculative Execution for Batch Job

2022-05-26 Thread Shqiprim Bunjaku
+1 (non-binding) Best Regards Shqiprim On Thu, May 26, 2022 at 6:22 PM rui fan <1996fan...@gmail.com> wrote: > Hi > > +1(non-binding), it’s very useful for batch job stability. > > Best wishes > fanrui > > On Thu, May 26, 2022 at 15:56 Zhu Zhu wrote: > > > Hi everyone, > > > > Thanks for the fe

Re: [VOTE] FLIP-168: Speculative Execution for Batch Job

2022-05-26 Thread rui fan
Hi +1(non-binding), it’s very useful for batch job stability. Best wishes fanrui On Thu, May 26, 2022 at 15:56 Zhu Zhu wrote: > Hi everyone, > > Thanks for the feedback for FLIP-168: Blocklist Mechanism [1] on the > discussion thread [2]. > > I'd like to start a vote for it. The vote will last

[jira] [Created] (FLINK-27804) Do not observe cluster/job mid upgrade

2022-05-26 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-27804: -- Summary: Do not observe cluster/job mid upgrade Key: FLINK-27804 URL: https://issues.apache.org/jira/browse/FLINK-27804 Project: Flink Issue Type: Improvement

Re: [DISCUSS] FLIP-221 Abstraction for lookup source cache and metric

2022-05-26 Thread Jark Wu
After looking at the new introduced ReloadTime and Becket's comment, I agree with Becket we should have a pluggable reloading strategy. We can provide some common implementations, e.g., periodic reloading, and daily reloading. But there definitely be some connector- or business-specific reloading s

Re: [DISCUSS] FLIP-232: Add Retry Support For Async I/O In DataStream API

2022-05-26 Thread Jark Wu
Hi Lincoln, What do you think about "timeout for the asynchronous operation from the first invoke to finally complete, which may across multiple retry attempts". Best, Jark On Wed, 25 May 2022 at 20:29, Lincoln Lee wrote: > Hi Jark, > > Thanks for your feedback! > > for 2) good advice for the

[jira] [Created] (FLINK-27803) Unable to write to s3 with Hudi format via Flink - Scala

2022-05-26 Thread sathyan sethumadhavan (Jira)
sathyan sethumadhavan created FLINK-27803: - Summary: Unable to write to s3 with Hudi format via Flink - Scala Key: FLINK-27803 URL: https://issues.apache.org/jira/browse/FLINK-27803 Project: Fl

Re: [VOTE] FLIP-227: Support overdraft buffer

2022-05-26 Thread David Morávek
+1 (binding) On Thu, May 26, 2022 at 11:55 AM Dawid Wysakowicz wrote: > +1 (binding) > > On Thu, 26 May 2022, 11:21 Piotr Nowojski, wrote: > > > Yes, it will be a good improvement :) > > > > +1 (binding) > > > > Piotrek > > > > czw., 26 maj 2022 o 10:26 Anton Kalashnikov > > napisał(a): > > >

[jira] [Created] (FLINK-27802) Job submission errors are swallowed for Flink 1.15 + HA

2022-05-26 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-27802: -- Summary: Job submission errors are swallowed for Flink 1.15 + HA Key: FLINK-27802 URL: https://issues.apache.org/jira/browse/FLINK-27802 Project: Flink Issue Typ

[jira] [Created] (FLINK-27801) Disable flushing stream when call Jackson's writeValue() method for CsvBulkWriter

2022-05-26 Thread luoyuxia (Jira)
luoyuxia created FLINK-27801: Summary: Disable flushing stream when call Jackson's writeValue() method for CsvBulkWriter Key: FLINK-27801 URL: https://issues.apache.org/jira/browse/FLINK-27801 Project: Fl

[jira] [Created] (FLINK-27800) addInEdge check state error

2022-05-26 Thread Licho sun (Jira)
Licho sun created FLINK-27800: - Summary: addInEdge check state error Key: FLINK-27800 URL: https://issues.apache.org/jira/browse/FLINK-27800 Project: Flink Issue Type: Bug Components: A

Re: [VOTE] FLIP-227: Support overdraft buffer

2022-05-26 Thread Dawid Wysakowicz
+1 (binding) On Thu, 26 May 2022, 11:21 Piotr Nowojski, wrote: > Yes, it will be a good improvement :) > > +1 (binding) > > Piotrek > > czw., 26 maj 2022 o 10:26 Anton Kalashnikov > napisał(a): > > > Hi. > > > > Thanks Fanrui for this FLIP. I think it will be useful thing for us. > > > > +1(non

[jira] [Created] (FLINK-27799) Version 1.13.5 is not compatible with version 1.10 UDF

2022-05-26 Thread Yichao Yang (Jira)
Yichao Yang created FLINK-27799: --- Summary: Version 1.13.5 is not compatible with version 1.10 UDF Key: FLINK-27799 URL: https://issues.apache.org/jira/browse/FLINK-27799 Project: Flink Issue Ty

Re: [VOTE] FLIP-227: Support overdraft buffer

2022-05-26 Thread Piotr Nowojski
Yes, it will be a good improvement :) +1 (binding) Piotrek czw., 26 maj 2022 o 10:26 Anton Kalashnikov napisał(a): > Hi. > > Thanks Fanrui for this FLIP. I think it will be useful thing for us. > > +1(non-binding) > > -- > > Best regards, > Anton Kalashnikov > > 26.05.2022 06:00, rui fan пишет

Re: [VOTE] FLIP-235: Hybrid Shuffle Mode

2022-05-26 Thread Xintong Song
+1 Best, Xintong On Thu, May 26, 2022 at 3:47 PM weijie guo wrote: > Hi everyone, > > Thanks for the feedback for FLIP-235: Hybrid Shuffle Mode[1] on the > discussion thread [2] > > I'd like to start a vote for it. The vote will last for at least 72 hours > unless there is an objection or in

Re: [VOTE] FLIP-227: Support overdraft buffer

2022-05-26 Thread Anton Kalashnikov
Hi. Thanks Fanrui for this FLIP. I think it will be useful thing for us. +1(non-binding) -- Best regards, Anton Kalashnikov 26.05.2022 06:00, rui fan пишет: Hi, everyone, Thanks for your feedback for FLIP-227: Support overdraft buffer[1] on the discussion thread[2]. I'd like to start a v

Re: [DISCUSS] Releasing Flink 1.14.5

2022-05-26 Thread Dian Fu
Hi Xingbo, Thanks for driving this release. +1 for 1.14.5 as there are already nearly 100 commits [1] since 1.14.4. Regards, Dian [1] https://github.com/apache/flink/compare/release-1.14.4...release-1.14 On Tue, May 24, 2022 at 2:23 PM Xingbo Huang wrote: > Hi all, > > I would like to start d

[VOTE] FLIP-168: Speculative Execution for Batch Job

2022-05-26 Thread Zhu Zhu
Hi everyone, Thanks for the feedback for FLIP-168: Blocklist Mechanism [1] on the discussion thread [2]. I'd like to start a vote for it. The vote will last for at least 72 hours unless there is an objection or insufficient votes. [1] https://cwiki.apache.org/confluence/display/FLINK/FLIP-168%3

Re: [VOTE] FLIP-224: Blocklist Mechanism

2022-05-26 Thread Yun Gao
Thanks Lijie and Zhu for driving the FLIP! The blocked list functionality helps reduce the complexity in maintenance and the currently design looks good to me, thus +1 from my side (binding). Best, Yun -- From:Xintong Song Se

Re: Re: [DISCUSS] FLIP-168: Speculative execution for Batch Job

2022-05-26 Thread Zhu Zhu
Hi everyone, Thank you for all the feedback on this FLIP! I will open a vote for it since there is no more concern. Thanks, Zhu Zhu Zhu 于2022年5月11日周三 12:29写道: > > Hi everyone, > > According to the discussion and updates of the blocklist > mechanism[1] (FLIP-224), I have updated FLIP-168 to make

[VOTE] Apache Flink Kubernetes Operator Release 1.0.0, release candidate #2

2022-05-26 Thread Yang Wang
Hi everyone, Please review and vote on the release candidate #2 for the version 1.0.0 of Apache Flink Kubernetes Operator, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) **Release Overview** As an overview, the release consists of th

[VOTE] FLIP-235: Hybrid Shuffle Mode

2022-05-26 Thread weijie guo
Hi everyone, Thanks for the feedback for FLIP-235: Hybrid Shuffle Mode[1] on the discussion thread [2] I'd like to start a vote for it. The vote will last for at least 72 hours unless there is an objection or insufficient votes. [1] https://cwiki.apache.org/confluence/display/FLINK/FLIP-235%3A+H

[jira] [Created] (FLINK-27798) Migrate Flink ML to Flink 1.15.0

2022-05-26 Thread Yunfeng Zhou (Jira)
Yunfeng Zhou created FLINK-27798: Summary: Migrate Flink ML to Flink 1.15.0 Key: FLINK-27798 URL: https://issues.apache.org/jira/browse/FLINK-27798 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-27797) PythonTableUtils.getCollectionInputFormat cannot correctly handle None values

2022-05-26 Thread Yunfeng Zhou (Jira)
Yunfeng Zhou created FLINK-27797: Summary: PythonTableUtils.getCollectionInputFormat cannot correctly handle None values Key: FLINK-27797 URL: https://issues.apache.org/jira/browse/FLINK-27797 Project

Re: [DISCUSS] FLIP-217 Support watermark alignment of source splits

2022-05-26 Thread Piotr Nowojski
Hi Becket, I still sustain what I wrote before: > I think I would still vote soft -1 on this option, but I wouldn't block it in case I am out-voted. > I think it might be helpful to agree on the definition of optional in our case. For me it doesn't matter whether a default method throwing an exc