Re: [DISCUSS] FLIP-308: Support Time Travel In Batch Mode

2023-06-09 Thread Benchao Li
Thanks Leonard for the input, "Implicitly type conversion" way sounds good to me. I also agree that this should be done in planner instead of connector, it'll be a lot easier for connector development. Leonard Xu 于2023年6月9日周五 20:11写道: > About the semantics consideration, I have some new input

Re: [DISCUSS] FLIP-313 Add support of User Defined AsyncTableFunction

2023-06-09 Thread Aitozi
Hi Jing, I means the join key is not necessary to be the primary key or unique index of the database. In this situation, we may queried out multi rows for one join key. I think that's why the LookupFunction#lookup will return a collection of RowData. BTW, I think the behavior of lookup join

Re: [DISCUSS] FLIP-246: Multi Cluster Kafka Source

2023-06-09 Thread Tzu-Li (Gordon) Tai
> Regarding (2), definitely. This is something we planned to add later on but so far keeping things common has been working well. My main worry for doing this as a later iteration is that this would probably be a breaking change for the public interface. If that can be avoided and planned ahead,

[jira] [Created] (FLINK-32305) History Server is slow at starting

2023-06-09 Thread Yiming Zang (Jira)
Yiming Zang created FLINK-32305: --- Summary: History Server is slow at starting Key: FLINK-32305 URL: https://issues.apache.org/jira/browse/FLINK-32305 Project: Flink Issue Type: Bug

Re: [DISCUSS] FLIP-307: Flink connector Redshift

2023-06-09 Thread Jing Ge
Hi Samrat, The FLIP looks good, thanks! Best regards, Jing On Tue, Jun 6, 2023 at 8:16 PM Samrat Deb wrote: > Hi Jing, > > > I would suggest adding that information into the > FLIP. > > Updated now, please review the new version of flip whenever time. > > > +1 Looking forward to your PR :-)

[jira] [Created] (FLINK-32304) Reduce rpc-akka jar

2023-06-09 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-32304: Summary: Reduce rpc-akka jar Key: FLINK-32304 URL: https://issues.apache.org/jira/browse/FLINK-32304 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-32303) Incorrect error message in KafkaSource

2023-06-09 Thread Piotr Nowojski (Jira)
Piotr Nowojski created FLINK-32303: -- Summary: Incorrect error message in KafkaSource Key: FLINK-32303 URL: https://issues.apache.org/jira/browse/FLINK-32303 Project: Flink Issue Type: Bug

Re: [DISCUSS] FLIP-313 Add support of User Defined AsyncTableFunction

2023-06-09 Thread Jing Ge
Hi Aitozi, The keyRow used in this case contains all keys[1]. Best regards, Jing [1] https://github.com/apache/flink/blob/191ec6ca3943d7119f14837efe112e074d815c47/flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/LookupFunction.java#L49 On Fri, Jun 9, 2023 at 3:42 

[jira] [Created] (FLINK-32302) Disable Hbase 2.x tests on Java 17

2023-06-09 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-32302: Summary: Disable Hbase 2.x tests on Java 17 Key: FLINK-32302 URL: https://issues.apache.org/jira/browse/FLINK-32302 Project: Flink Issue Type:

Re: [DISCUSS] FLIP-313 Add support of User Defined AsyncTableFunction

2023-06-09 Thread Aitozi
Hi Jing, The performance test is added to the FLIP. As I know, The lookup join can return multi rows, it depends on whether the join key is the primary key of the external database or not. The `lookup` [1] will return a collection of joined result, and each of them will be collected

[DISCUSS] Visibility on HybridSource or KafkaSource with multiple topics

2023-06-09 Thread Or Keren
Hey all, *Motivation:* Currently when using either HybridSource with multiple sources or KafkaSource with multiple topics inside, it’s impossible to see the distribution between the different sources regarding how many records have been received so far. All of the received records metric is

[jira] [Created] (FLINK-32301) common.sh#create_ha_config should use set_config_key

2023-06-09 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-32301: Summary: common.sh#create_ha_config should use set_config_key Key: FLINK-32301 URL: https://issues.apache.org/jira/browse/FLINK-32301 Project: Flink

[jira] [Created] (FLINK-32300) Support get object for result set

2023-06-09 Thread Fang Yong (Jira)
Fang Yong created FLINK-32300: - Summary: Support get object for result set Key: FLINK-32300 URL: https://issues.apache.org/jira/browse/FLINK-32300 Project: Flink Issue Type: Sub-task

Re: [DISCUSS] FLIP-308: Support Time Travel In Batch Mode

2023-06-09 Thread Leonard Xu
About the semantics consideration, I have some new input after rethink. 1. We can support both TIMESTAMP and TIMESTAMP_LTZ expression following the syntax `SELECT [column_name(s)] FROM [table_name] FOR SYSTEM_TIME AS OF ` 2. For TIMESTAMP_LTZ type, give a long instant value to CatalogTable is

[jira] [Created] (FLINK-32299) Upload python jar when sql contains python udf jar

2023-06-09 Thread Shengkai Fang (Jira)
Shengkai Fang created FLINK-32299: - Summary: Upload python jar when sql contains python udf jar Key: FLINK-32299 URL: https://issues.apache.org/jira/browse/FLINK-32299 Project: Flink Issue

Re: [DISCUSS] Status of Statefun Project

2023-06-09 Thread Marco Villalobos
Why can't the Apache Software Foundation allow community members to bring it up to date? What's the process for that? I believe that there are people and companies on this mailing list interested in supporting Apache Flink Stateful Functions. You already had two people on this thread express

[jira] [Created] (FLINK-32298) The outputQueueSize is negative

2023-06-09 Thread Rui Fan (Jira)
Rui Fan created FLINK-32298: --- Summary: The outputQueueSize is negative Key: FLINK-32298 URL: https://issues.apache.org/jira/browse/FLINK-32298 Project: Flink Issue Type: Bug Components:

Re: [DISCUSS] FLIP-316: Introduce SQL Driver

2023-06-09 Thread Paul Lam
Hi Mason, I get your point. I'm increasingly feeling the need to introduce a built-in file distribution mechanism for flink-kubernetes module, just like Spark does with `spark.kubernetes.file.upload.path` [1]. I’m assuming the workflow is as follows: - KubernetesClusterDescripter uploads all

Re: [DISCUSS] Hive dialect shouldn't fall back to Flink's default dialect

2023-06-09 Thread yuxia
Thanks all again. Then, I'll start to abandon the fall back behavior for Hive dialect in Flink 1.18. Best regards, Yuxia - 原始邮件 - 发件人: "yuxia" 收件人: "dev" 发送时间: 星期四, 2023年 6 月 08日 上午 11:53:32 主题: Re: [DISCUSS] Hive dialect shouldn't fall back to Flink's default dialect Thanks all for

Re: [DISCUSS] FLIP-313 Add support of User Defined AsyncTableFunction

2023-06-09 Thread Jing Ge
Hi Aitozi, Thanks for the feedback. Looking forward to the performance tests. Afaik, lookup returns one row for each key [1] [2]. Conceptually, the lookup function is used to enrich column(s) from the dimension table. If, for the given key, there will be more than one row, there will be no way

[jira] [Created] (FLINK-32297) Use Temurin image in FlinkImageBuilder

2023-06-09 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-32297: Summary: Use Temurin image in FlinkImageBuilder Key: FLINK-32297 URL: https://issues.apache.org/jira/browse/FLINK-32297 Project: Flink Issue Type:

[jira] [Created] (FLINK-32296) Flink SQL handle array of row incorrectly

2023-06-09 Thread Lim Qing Wei (Jira)
Lim Qing Wei created FLINK-32296: Summary: Flink SQL handle array of row incorrectly Key: FLINK-32296 URL: https://issues.apache.org/jira/browse/FLINK-32296 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-32295) Try out Infra-provided Gradle Enterprise

2023-06-09 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-32295: Summary: Try out Infra-provided Gradle Enterprise Key: FLINK-32295 URL: https://issues.apache.org/jira/browse/FLINK-32295 Project: Flink Issue Type:

Re: Re: [DISCUSS] FLIP-305: Support atomic for CREATE TABLE AS SELECT(CTAS) statement

2023-06-09 Thread liu ron
Hi, Mang Thanks for your update, the FLIP looks good to me now. Best, Ron Mang Zhang 于2023年6月9日周五 12:08写道: > Hi Ron, > Thanks for your reply! > After our offline discussion, at present, there may be many of flink jobs > using non-atomic CTAS functions, especially Stream jobs, > If we only

Re: [DISCUSS] FLIP 295: Support persistence of Catalog configuration and asynchronous registration

2023-06-09 Thread Hang Ruan
Hi, Feng. I reviewed this FLIP again and found some little places that may need to optimize. 1. `CatalogDescriptor` may need a private constructor. 2. The method `initCatalog` in `CatalogManager` is not introduced. Best, Hang Feng Jin 于2023年6月6日周二 21:17写道: > Hi Leonard, > > Thanks for your