Re: [DISCUSS] FLIP-328: Allow source operators to determine isProcessingBacklog based on watermark lag

2023-09-09 Thread Jark Wu
Hi Xuannan, I leave my comments inline. > In the case where a user wants to > use a CDC source and also determine backlog status based on watermark > lag, we still need to define the rule when that occurs This rule should be defined by the source itself (who knows backlog best), not by the frame

Re: [DISCUSS] [FLINK-32873] Add a config to allow disabling Query hints

2023-09-09 Thread Jing Ge
Hi, Thanks for bringing this to our attention. At the first glance, it looks reasonable to offer a new configuration to enable/disable SQL hints globally. However, IMHO, it is not the right timing to do it now, because we should not only think as platform providers but also as end users(the number

Re: [DISCUSS] [FLINK-32873] Add a config to allow disabling Query hints

2023-09-09 Thread Jark Wu
I agree with Jing, My biggest concern is this makes the boundary of adding an option very unclear. It's not a strong reason to add a config just because of it doesn't affect existing users. Does this mean that in the future we might add an option to disable each feature? Flink already has a very