Re: [DISCUSS] Towards flink-shaded release 18.0

2023-11-22 Thread Yun Tang
+1, thanks Sergey for driving this work. Best Yun Tang From: Leonard Xu Sent: Thursday, November 23, 2023 9:38 To: dev Subject: Re: [DISCUSS] Towards flink-shaded release 18.0 +1, thanks Sergey for driving this. > 2023年11月23日 上午5:46,Martijn Visser 写道: > > +1.

[RESULT][VOTE] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-22 Thread Rui Fan
Dear developers, FLIP-390 [1] has been accepted and voted through this thread [2]. The proposal received 6 approving votes, 5 of which are binding, and there is no disapproval. Hangxiang Yu (binding) Piotr Nowojski (binding) Roman Khachatryan (binding) Leonard Xu (binding) Feng Jin Rui Fan (bind

Re: [VOTE] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-22 Thread Rui Fan
+1(binding) And closing this vote thread, results will be announced in a separate email. Best, Rui On Thu, Nov 23, 2023 at 10:32 AM Feng Jin wrote: > +1(non-binding) > > Best, > Feng > > On Wed, Nov 22, 2023 at 6:37 PM Leonard Xu wrote: > > > +1(binding) > > > > Best, > > Leonard > > > > > 20

Re: [NOTICE] flink-table-planner module has been migrated to JUnit5

2023-11-22 Thread Yuxin Tan
Thanks Jiabao for the quick response. Best, Yuxin Jiabao Sun 于2023年11月23日周四 11:25写道: > Thanks Yuxin for you reminder, > > I will complete it today. > > Best, > Jiabao > > > > 2023年11月22日 16:26,Yuxin Tan 写道: > > > > Hi, Leonard, jiabao > > > > Thanks for migrating the test classes. > > > > I h

Re: [NOTICE] flink-table-planner module has been migrated to JUnit5

2023-11-22 Thread Jiabao Sun
Thanks Yuxin for you reminder, I will complete it today. Best, Jiabao > 2023年11月22日 16:26,Yuxin Tan 写道: > > Hi, Leonard, jiabao > > Thanks for migrating the test classes. > > I have noticed that many test classes (e.g., FlinkCalciteCatalogReaderTest) > in flink-table (including flink-table-

Re: [VOTE] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-22 Thread Feng Jin
+1(non-binding) Best, Feng On Wed, Nov 22, 2023 at 6:37 PM Leonard Xu wrote: > +1(binding) > > Best, > Leonard > > > 2023年11月22日 下午6:19,Roman Khachatryan 写道: > > > > +1 (binding) > > > > > > Thanks for the proposal > > > > Regards, > > Roman > > > > On Wed, Nov 22, 2023, 10:08 AM Piotr Nowojsk

[jira] [Created] (FLINK-33624) Bump Guava to 32.1.3-jre in flink-table

2023-11-22 Thread Jing Ge (Jira)
Jing Ge created FLINK-33624: --- Summary: Bump Guava to 32.1.3-jre in flink-table Key: FLINK-33624 URL: https://issues.apache.org/jira/browse/FLINK-33624 Project: Flink Issue Type: Improvement

Re: [DISCUSSION] flink-connector-shared-utils release process

2023-11-22 Thread Leonard Xu
Thanks Etienne for driving this. > - a flink-connector-shared-utils-*test* clone repo and a > *io.github.user.flink*:flink-connector-parent custom artifact to be able to > directly commit and install the artifact in the CI > - a custom ci script that does the cloning and mvn install in the ci.ym

[jira] [Created] (FLINK-33623) Metaspce leak caused by Flink Netty Client thread

2023-11-22 Thread gabrywu (Jira)
gabrywu created FLINK-33623: --- Summary: Metaspce leak caused by Flink Netty Client thread Key: FLINK-33623 URL: https://issues.apache.org/jira/browse/FLINK-33623 Project: Flink Issue Type: Bug A

[jira] [Created] (FLINK-33622) table.optimizer.reuse-sub-plan-enabled doesn't work when a Table is converted to a DataStream

2023-11-22 Thread Yaroslav Tkachenko (Jira)
Yaroslav Tkachenko created FLINK-33622: -- Summary: table.optimizer.reuse-sub-plan-enabled doesn't work when a Table is converted to a DataStream Key: FLINK-33622 URL: https://issues.apache.org/jira/browse/FLI

Re: [DISCUSS] Towards flink-shaded release 18.0

2023-11-22 Thread Leonard Xu
+1, thanks Sergey for driving this. > 2023年11月23日 上午5:46,Martijn Visser 写道: > > +1. More than happy to help :) > > On Wed, Nov 22, 2023 at 9:16 PM Sergey Nuyanzin wrote: >> >> Hi everyone, >> >> I would like to start discussion about creating a new 18 release for >> flink-shaded[1]. >> >> A

[jira] [Created] (FLINK-33621) Table Store with PyFlink

2023-11-22 Thread Mehmet Aktas (Jira)
Mehmet Aktas created FLINK-33621: Summary: Table Store with PyFlink Key: FLINK-33621 URL: https://issues.apache.org/jira/browse/FLINK-33621 Project: Flink Issue Type: Technical Debt

Re: Apicurio Avro format proposal

2023-11-22 Thread Martijn Visser
Hi David, Can you create a small FLIP for this? Best regards, Martijn On Wed, Nov 22, 2023 at 6:46 PM David Radley wrote: > > Hi, > I would like to propose a new Apicurio Avro format. > The Apicurio Avro Schema Registry (avro-apicurio) format would allow you to > read records that were serial

Re: [DISCUSS] Towards flink-shaded release 18.0

2023-11-22 Thread Martijn Visser
+1. More than happy to help :) On Wed, Nov 22, 2023 at 9:16 PM Sergey Nuyanzin wrote: > > Hi everyone, > > I would like to start discussion about creating a new 18 release for > flink-shaded[1]. > > Among others it brings fix for ZooKeeper CVE [2], > a couple of Guava CVEs [3], [4] > and support

Re: [VOTE] FLIP-384: Introduce TraceReporter and use it to create checkpointing and recovery traces

2023-11-22 Thread David Morávek
+1 (binding) Best, D. On Wed, Nov 22, 2023 at 11:21 AM Roman Khachatryan wrote: > +1 (binding) > > Regards, > Roman > > On Wed, Nov 22, 2023, 7:08 AM Zakelly Lan wrote: > > > +1(non-binding) > > > > Best, > > Zakelly > > > > On Wed, Nov 22, 2023 at 3:04 PM Hangxiang Yu > wrote: > > > > > +1 (

[DISCUSS] Towards flink-shaded release 18.0

2023-11-22 Thread Sergey Nuyanzin
Hi everyone, I would like to start discussion about creating a new 18 release for flink-shaded[1]. Among others it brings fix for ZooKeeper CVE [2], a couple of Guava CVEs [3], [4] and support of jdk 21 from netty mentioned in one of the java 21[5] support subtasks [6] Also making a release now

[jira] [Created] (FLINK-33620) Add Java 21 to docker image

2023-11-22 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33620: --- Summary: Add Java 21 to docker image Key: FLINK-33620 URL: https://issues.apache.org/jira/browse/FLINK-33620 Project: Flink Issue Type: Sub-task

Apicurio Avro format proposal

2023-11-22 Thread David Radley
Hi, I would like to propose a new Apicurio Avro format. The Apicurio Avro Schema Registry (avro-apicurio) format would allow you to read records that were serialized by the io.apicurio.registry.serde.avro.AvroKafkaSerializer and to write records that can in turn be read by the io.apicurio.regis

[jira] [Created] (FLINK-33619) [JUnit5 Migration] Module: flink-table-planner (Remaining Tests)

2023-11-22 Thread Jiabao Sun (Jira)
Jiabao Sun created FLINK-33619: -- Summary: [JUnit5 Migration] Module: flink-table-planner (Remaining Tests) Key: FLINK-33619 URL: https://issues.apache.org/jira/browse/FLINK-33619 Project: Flink

Re: [DISCUSSION] flink-connector-shared-utils release process

2023-11-22 Thread Etienne Chauchot
I agree, it would make sense to add this process to https://cwiki.apache.org/confluence/display/FLINK/Continuous+Integration If people agree on the process and location, I can do the addition to the doc. Best Etienne Le 22/11/2023 à 14:29, Sergey Nuyanzin a écrit : yes, that's the way how

Re: [VOTE] Release 1.17.2, release candidate #1

2023-11-22 Thread Danny Cranmer
Thanks for driving this release. +1 (binding) - Verified signatures and checksums - Verified there are no binaries in the source archive - Run simple Kinesis job on binary dist, verified consumer, map and print. The Flink dashboard looks good. - Built from source successfully - Contents of maven

[jira] [Created] (FLINK-33618) Upgrade swagger for flink-shaded to 2.2.19

2023-11-22 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33618: --- Summary: Upgrade swagger for flink-shaded to 2.2.19 Key: FLINK-33618 URL: https://issues.apache.org/jira/browse/FLINK-33618 Project: Flink Issue Type:

[jira] [Created] (FLINK-33617) Upgrade tcnative for flink-shaded

2023-11-22 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33617: --- Summary: Upgrade tcnative for flink-shaded Key: FLINK-33617 URL: https://issues.apache.org/jira/browse/FLINK-33617 Project: Flink Issue Type: Technical

Re: [DISCUSSION] flink-connector-shared-utils release process

2023-11-22 Thread Sergey Nuyanzin
yes, that's the way how I tested my changes thanks for confirming that it's ok I wonder whether it should be documented somewhere, since it is not very obvious? On Wed, Nov 22, 2023 at 10:35 AM Etienne Chauchot wrote: > Hi Sergey, > > The other alternative that allows for autonomous testing of

Re: [VOTE] FLIP-393: Make QueryOperations SQL serializable

2023-11-22 Thread Martijn Visser
+1 (binding) On Wed, Nov 22, 2023 at 2:05 AM Lincoln Lee wrote: > > +1 (binding) > > Best, > Lincoln Lee > > > Sergey Nuyanzin 于2023年11月22日周三 07:55写道: > > > +1 (binding) > > > > On Tue, Nov 21, 2023 at 3:17 PM Jim Hughes > > wrote: > > > > > +1 (non-binding) > > > > > > Thanks, Dawid! > > > > >

[ANNOUNCE] Apache Flink Kubernetes Operator 1.7.0 released

2023-11-22 Thread Gyula Fóra
The Apache Flink community is very happy to announce the release of Apache Flink Kubernetes Operator 1.7.0. The Flink Kubernetes Operator allows users to manage their Apache Flink applications and their lifecycle through native k8s tooling like kubectl. Release highlights: - Standalone autoscale

Re: [DISCUSS][FLINK-32993] Datagen connector handles length-constrained fields according to the schema definition by default

2023-11-22 Thread Yubin Li
Thank Jane for providing examples to make discussions clearer. Thank Lincoln and Xuyang for your feedback,I agree with you wholeheartedly that it is better to throw an error instead of ignoring it directly. Taking the example provided, For fixed-length data types, two DDLs which custom length sh

Re: [VOTE] FLIP-386: Support adding custom metrics in Recovery Spans

2023-11-22 Thread Rui Fan
+1(binding) Thanks for driving this proposal! Best, Rui On Wed, Nov 22, 2023 at 7:44 PM Piotr Nowojski wrote: > Hi All, > > I'd like to start a vote on the FLIP-386: Support adding custom metrics in > Recovery Spans [1]. The discussion thread is here [2]. > > The vote will be open for at leas

Re: [DISCUSS] FLIP-386: Support adding custom metrics in Recovery Spans

2023-11-22 Thread Piotr Nowojski
Hi, I have started the voting thread for this FLIP as well after modifying according to Roman's suggestions. If someone has some other suggestions, please don't hesitate to raise them here regardless of the ongoing vote :) Best, Piotrek śr., 22 lis 2023 o 12:37 Piotr Nowojski napisał(a): > Ok,

[VOTE] FLIP-386: Support adding custom metrics in Recovery Spans

2023-11-22 Thread Piotr Nowojski
Hi All, I'd like to start a vote on the FLIP-386: Support adding custom metrics in Recovery Spans [1]. The discussion thread is here [2]. The vote will be open for at least 72 hours unless there is an objection or not enough votes. [1] https://cwiki.apache.org/confluence/x/VAuZE [2] https://list

Re: [DISCUSS] FLIP-386: Support adding custom metrics in Recovery Spans

2023-11-22 Thread Piotr Nowojski
Ok, good point about dropping the aggregation method from the API. We can always add it in the future if it will ever be needed. Thanks for your input! Best, Piotrek śr., 22 lis 2023 o 01:53 Roman Khachatryan napisał(a): > Thanks for clarifying, I see your points (although reporting metrics as

Re: [DISCUSS] FLIP-385: Add OpenTelemetryTraceReporter and OpenTelemetryMetricReporter

2023-11-22 Thread Jing Ge
Thanks Piotr for driving it! Really like the idea of supporting OpenTelemetry. Best regards, Jing On Tue, Nov 21, 2023 at 6:20 PM Piotr Nowojski wrote: > Thanks Roman. It kind of does depend, as the API is defined in the > FLIP-384. But the voting thread for that FLIP has started, so I think we

Re: [VOTE] FLIP-385: Add OpenTelemetryTraceReporter and OpenTelemetryMetricReporter

2023-11-22 Thread Jing Ge
+1(binding) Thanks! Best Regards, Jing On Wed, Nov 22, 2023 at 11:21 AM Roman Khachatryan wrote: > +1 (binding) > > Regards, > Roman > > On Wed, Nov 22, 2023, 7:30 AM Hangxiang Yu wrote: > > > +1(binding) > > > > On Wed, Nov 22, 2023 at 10:29 AM Rui Fan <1996fan...@gmail.com> wrote: > > > > >

Re: [VOTE] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-22 Thread Leonard Xu
+1(binding) Best, Leonard > 2023年11月22日 下午6:19,Roman Khachatryan 写道: > > +1 (binding) > > > Thanks for the proposal > > Regards, > Roman > > On Wed, Nov 22, 2023, 10:08 AM Piotr Nowojski > wrote: > >> Thanks Rui! >> >> +1 (binding) >> >> Best, >> Piotrek >> >> śr., 22 lis 2023 o 08:05

Re: [DISCUSS] FLIP-379: Dynamic source parallelism inference for batch jobs

2023-11-22 Thread Leonard Xu
Thanks Xia for the reply, sorry for the late reply. > Thanks for pointing out the issue, the current wording does indeed seem to > be confusing. It involves the existing implementation of the > AdaptiveBatchScheduler, where the dynamically inferred parallelism cannot > exceed the JobVertex's maxP

Re: [VOTE] FLIP-385: Add OpenTelemetryTraceReporter and OpenTelemetryMetricReporter

2023-11-22 Thread Roman Khachatryan
+1 (binding) Regards, Roman On Wed, Nov 22, 2023, 7:30 AM Hangxiang Yu wrote: > +1(binding) > > On Wed, Nov 22, 2023 at 10:29 AM Rui Fan <1996fan...@gmail.com> wrote: > > > +1(binding) > > > > Best, > > Rui > > > > On Wed, Nov 22, 2023 at 1:20 AM Piotr Nowojski > > wrote: > > > > > Hi All, > >

Re: [VOTE] FLIP-384: Introduce TraceReporter and use it to create checkpointing and recovery traces

2023-11-22 Thread Roman Khachatryan
+1 (binding) Regards, Roman On Wed, Nov 22, 2023, 7:08 AM Zakelly Lan wrote: > +1(non-binding) > > Best, > Zakelly > > On Wed, Nov 22, 2023 at 3:04 PM Hangxiang Yu wrote: > > > +1 (binding) > > Thanks for driving this again! > > > > On Wed, Nov 22, 2023 at 10:30 AM Rui Fan <1996fan...@gmail.co

Re: [VOTE] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-22 Thread Roman Khachatryan
+1 (binding) Thanks for the proposal Regards, Roman On Wed, Nov 22, 2023, 10:08 AM Piotr Nowojski wrote: > Thanks Rui! > > +1 (binding) > > Best, > Piotrek > > śr., 22 lis 2023 o 08:05 Hangxiang Yu napisał(a): > > > +1 (binding) > > Thanks for your efforts! > > > > On Mon, Nov 20, 2023 at 11

[jira] [Created] (FLINK-33616) multi lookup join error

2023-11-22 Thread yong yang (Jira)
yong yang created FLINK-33616: - Summary: multi lookup join error Key: FLINK-33616 URL: https://issues.apache.org/jira/browse/FLINK-33616 Project: Flink Issue Type: Bug Components: Table

Re: [VOTE] FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-22 Thread Piotr Nowojski
Thanks Rui! +1 (binding) Best, Piotrek śr., 22 lis 2023 o 08:05 Hangxiang Yu napisał(a): > +1 (binding) > Thanks for your efforts! > > On Mon, Nov 20, 2023 at 11:53 AM Rui Fan <1996fan...@gmail.com> wrote: > > > Hi everyone, > > > > Thank you to everyone for the feedback on FLIP-390: Support >

Re: [DISCUSSION] flink-connector-shared-utils release process

2023-11-22 Thread Etienne Chauchot
Hi Sergey, The other alternative that allows for autonomous testing of ci changes (thanks @Chesnay for the suggestion) is to create you own repo: - a flink-connector-shared-utils-*test* clone repo and a *io.github.user.flink*:flink-connector-parent custom artifact to be able to directly comm

[jira] [Created] (FLINK-33615) build_wheels_on_macos failed

2023-11-22 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-33615: - Summary: build_wheels_on_macos failed Key: FLINK-33615 URL: https://issues.apache.org/jira/browse/FLINK-33615 Project: Flink Issue Type: Bug Comp

Re: [NOTICE] flink-table-planner module has been migrated to JUnit5

2023-11-22 Thread Yuxin Tan
Hi, Leonard, jiabao Thanks for migrating the test classes. I have noticed that many test classes (e.g., FlinkCalciteCatalogReaderTest) in flink-table (including flink-table-planner) have been updated to use AssertJ. However, their dependent test classes still utilize org.junit.Test or org.junit.B