Re: [VOTE] Release 1.19.1, release candidate #1

2024-06-10 Thread Matthias Pohl
+1 (binding) * Downloaded all artifacts * Extracted sources and ran compilation on sources * Diff of git tag checkout with downloaded sources * Verified SHA512 & GPG checksums * Checked that all POMs have the right expected version * Generated diffs to compare pom file changes with NOTICE files *

Re: [ANNOUNCE] New Apache Flink PMC Member - Fan Rui

2024-06-10 Thread Jiangang Liu
Congratulations, Fan Rui! Best, Jiangang Liu Jacky Lau 于2024年6月11日周二 13:04写道: > Congratulations Rui, well deserved! > > Regards, > Jacky Lau > > Jeyhun Karimov 于2024年6月11日 周二03:49写道: > > > Congratulations Rui, well deserved! > > > > Regards, > > Jeyhun > > > > On Mon, Jun 10, 2024, 10:21 Ahmed

Re: [DISCUSS] Connector Externalization Retrospective

2024-06-10 Thread Xintong Song
Thanks for bringing this up, Danny. This is indeed an important issue that the community needs to improve on. Personally, I think a mono-repo might not be a bad idea, if we apply different rules for the connector releases. To be specific: - flink-connectors 1.19.x contains all connectors that are

Re: [DISCUSSION] FLIP-456: CompiledPlan support for Batch Execution Mode

2024-06-10 Thread Timo Walther
Hi Alexey, thanks for proposing this FLIP. It is a nice continuation of the vision we had for CompiledPlan when writing and implementing FLIP-190. The whole stack is prepared for serializing BatchExecNodes as well so it shouldn't be too hard to make this a reality. > I think the FLIP should

Re: [VOTE] FLIP-459: Support Flink hybrid shuffle integration with Apache Celeborn

2024-06-10 Thread Junrui Lee
+1 (non-binding) Best, Junrui Venkatakrishnan Sowrirajan 于2024年6月10日周一 02:37写道: > Thanks for adding this new support. +1 (non-binding) > > On Sat, Jun 8, 2024, 3:26 PM Ahmed Hamdy wrote: > > > +1 (non-binding) > > Best Regards > > Ahmed Hamdy > > > > > > On Sat, 8 Jun 2024 at 22:26, Jeyhun Kar

Re: [Discuss] Non-retriable (partial) errors in Elasticsearch 8 connector

2024-06-10 Thread Mingliang Liu
Thank you Ahmed for the explanation. The current Elasticsearch 8 connector already uses the FatalExeptionClassifier for fatal / non-retriable requests [1]. It's very similar to what you linked in the AWS connectors. Currently this is only used for fully failed requests. The main problem I was conc

Re: [DISCUSS] FLIP-463: Schema Definition in CREATE TABLE AS Statement

2024-06-10 Thread Timo Walther
Hi Sergio, thanks for proposing this FLIP for finalizing the CTAS statement. Adopting the logic from MySQL for deriving and potentially overwriting parts of the schema should be easy to understand for everyone. So +1 for the FLIP in general. > How do you handle CTAS statements with SELECT cl

Re: [ANNOUNCE] New Apache Flink PMC Member - Fan Rui

2024-06-10 Thread Jacky Lau
Congratulations Rui, well deserved! Regards, Jacky Lau Jeyhun Karimov 于2024年6月11日 周二03:49写道: > Congratulations Rui, well deserved! > > Regards, > Jeyhun > > On Mon, Jun 10, 2024, 10:21 Ahmed Hamdy wrote: > > > Congratulations Rui! > > Best Regards > > Ahmed Hamdy > > > > > > On Mon, 10 Jun 2024

[jira] [Created] (FLINK-35563) 'Run kubernetes application test' failed on AZP

2024-06-10 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-35563: -- Summary: 'Run kubernetes application test' failed on AZP Key: FLINK-35563 URL: https://issues.apache.org/jira/browse/FLINK-35563 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-35562) WindowTableFunctionProcTimeRestoreTest produced no output for 900 seconds

2024-06-10 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-35562: -- Summary: WindowTableFunctionProcTimeRestoreTest produced no output for 900 seconds Key: FLINK-35562 URL: https://issues.apache.org/jira/browse/FLINK-35562 Project: Flink

Re: Flink Kubernetes Operator 1.9.0 release planning

2024-06-10 Thread Rui Fan
Thanks Gyula for driving this release! > I suggest we cut the release branch this week after merging current > outstanding smaller PRs. It makes sense to me. Best, Rui On Mon, Jun 10, 2024 at 3:05 PM Gyula Fóra wrote: > Hi all! > > I want to kick off the discussion / release process for the F

Re: [VOTE] Release 1.19.1, release candidate #1

2024-06-10 Thread Xintong Song
+1 (binding) - verified checksums and signatures - built from source - executed example jobs on a standalone cluster Best, Xintong On Mon, Jun 10, 2024 at 6:54 PM Hong Liang wrote: > Thanks for testing the release candidate, everyone. Nice to see coverage on > different types of testing bei

Re: [ANNOUNCE] New Apache Flink PMC Member - Fan Rui

2024-06-10 Thread Jeyhun Karimov
Congratulations Rui, well deserved! Regards, Jeyhun On Mon, Jun 10, 2024, 10:21 Ahmed Hamdy wrote: > Congratulations Rui! > Best Regards > Ahmed Hamdy > > > On Mon, 10 Jun 2024 at 09:10, David Radley > wrote: > > > Congratulations, Rui! > > > > From: Sergey Nuyanzin > > Date: Sunday, 9 June 2

Re: [DISCUSS] FLIP-463: Schema Definition in CREATE TABLE AS Statement

2024-06-10 Thread Jeyhun Karimov
Hi Sergio, Thanks for driving this FLIP. +1 for it. I have a few questions: - How do you handle CTAS statements with SELECT clauses that have (implicit or explicit) NULLABLE or NOT NULLABLE columns? Could you also mention the casting rules in the FLIP for this case? - In some cases, redefining th

Re: [DISCUSS] Connector Externalization Retrospective

2024-06-10 Thread David Radley
Hi Danny, I think your proposal is a good one. This is the approach that we took with the Egeria project, firstly taking the connectors out of the main repo, then connectors having their own versions that incremented organically rather then tied to the core release. Blue sky thinking - I wonder

[jira] [Created] (FLINK-35561) Flink REST API incorrect documentation

2024-06-10 Thread Shyam (Jira)
Shyam created FLINK-35561: - Summary: Flink REST API incorrect documentation Key: FLINK-35561 URL: https://issues.apache.org/jira/browse/FLINK-35561 Project: Flink Issue Type: Bug Components

Re: [DISCUSS] FLIP-463: Schema Definition in CREATE TABLE AS Statement

2024-06-10 Thread Sergio Pena
Hi David, The CTAS feature is already part of Flink (proposed in FLIP-218 [1]). The new FLIP-463 is just to extend the CTAS syntax to allow for adding new columns to the created table that are not part of the generated schema. I think FLIP-218 [1] was discussed in the mail list somewhere, but I co

[DISCUSS] Connector Externalization Retrospective

2024-06-10 Thread Danny Cranmer
Hello Flink community, It has been over 2 years [1] since we started externalizing the Flink connectors to dedicated repositories from the main Flink code base. The past discussions can be found here [2]. The community decided to externalize the connectors to primarily 1/ improve stability and spe

Re: [DISCUSS] FLIP-462: Support Custom Data Distribution for Input Stream of Lookup Join

2024-06-10 Thread Lincoln Lee
Hi Weijie, Thanks for your proposal, this will be a useful advanced optimization for connector developers! I have two questions: 1. FLIP-204[1] hash lookup join hint is mentioned in this FLIP, what's the apply ordering of the two feature? For example, a connector that implements the `SupportsLoo

Re: [VOTE] Release 1.19.1, release candidate #1

2024-06-10 Thread Hong Liang
Thanks for testing the release candidate, everyone. Nice to see coverage on different types of testing being done. I've addressed the comments on the web PR - thanks Rui Fan for good comments, and for the reminder from Ahmed :) We have <24 hours on the vote wait time, and still waiting on 1 more

Re: [ANNOUNCE] New Apache Flink PMC Member - Fan Rui

2024-06-10 Thread Ahmed Hamdy
Congratulations Rui! Best Regards Ahmed Hamdy On Mon, 10 Jun 2024 at 09:10, David Radley wrote: > Congratulations, Rui! > > From: Sergey Nuyanzin > Date: Sunday, 9 June 2024 at 20:33 > To: dev@flink.apache.org > Subject: [EXTERNAL] Re: [ANNOUNCE] New Apache Flink PMC Member - Fan Rui > Congra

RE: [ANNOUNCE] New Apache Flink PMC Member - Fan Rui

2024-06-10 Thread David Radley
Congratulations, Rui! From: Sergey Nuyanzin Date: Sunday, 9 June 2024 at 20:33 To: dev@flink.apache.org Subject: [EXTERNAL] Re: [ANNOUNCE] New Apache Flink PMC Member - Fan Rui Congratulations, Rui! On Fri, Jun 7, 2024 at 5:36 AM Xia Sun wrote: > Congratulations, Rui! > > Best, > Xia > > Paul

Re: [DISCUSS] FLIP-463: Schema Definition in CREATE TABLE AS Statement

2024-06-10 Thread David Radley
Hi Sergio, Sounds good . I am relatively new to this area and had some basic questions: I notice in [1] it talks of materialized views. And CREATE view can already take the AS keyword. It would be useful to me to understand when we would use each of these. - I assume the table will be kept up t

Flink Kubernetes Operator 1.9.0 release planning

2024-06-10 Thread Gyula Fóra
Hi all! I want to kick off the discussion / release process for the Flink Kubernetes Operator 1.9.0 version. The last, 1.8.0, version was released in March and since then we have had a number of important fixes. Furthermore there are some bigger pieces of outstanding work in the form of open PRs