Aitozi commented on code in PR #153:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/153#discussion_r841297026
##
docker-entrypoint.sh:
##
@@ -27,12 +27,12 @@ if [ "$1" = "help" ]; then
elif [ "$1" = "operator" ]; then
echo "Starting Operator"
-exec ja
Aitozi commented on code in PR #153:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/153#discussion_r841297739
##
helm/flink-kubernetes-operator/values.yaml:
##
@@ -78,3 +78,8 @@ metrics:
imagePullSecrets: []
nameOverride: ""
fullnameOverride: ""
+
+# Set the j
gyfora commented on code in PR #153:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/153#discussion_r841366071
##
helm/flink-kubernetes-operator/values.yaml:
##
@@ -78,3 +78,8 @@ metrics:
imagePullSecrets: []
nameOverride: ""
fullnameOverride: ""
+
+# Set the j
JingsongLi commented on code in PR #72:
URL: https://github.com/apache/flink-table-store/pull/72#discussion_r841400831
##
docs/content/docs/development/query-table.md:
##
@@ -0,0 +1,87 @@
+---
+title: "Query Table"
+weight: 4
+type: docs
+aliases:
+- /development/query-table.htm
FilKarnicki commented on code in PR #309:
URL: https://github.com/apache/flink-statefun/pull/309#discussion_r841456053
##
docs/content/docs/modules/overview.md:
##
@@ -61,3 +61,36 @@ spec:
A module YAML file can contain multiple YAML documents, separated by `---`,
each repre
XComp commented on code in PR #19275:
URL: https://github.com/apache/flink/pull/19275#discussion_r841387465
##
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java:
##
@@ -1060,40 +1066,24 @@ protected CleanupJobState
jobReachedTerminalState(Execution
MartijnVisser merged PR #1:
URL: https://github.com/apache/flink-connector-redis/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@
pscls opened a new pull request, #1:
URL: https://github.com/apache/flink-connector-rabbitmq/pull/1
## What is the purpose of the change
This pull request ports the RabbitMQ connector implementation to the new
Connector’s API described in
[FLIP-27](https://cwiki.apache.org/co
pscls commented on PR #1:
URL:
https://github.com/apache/flink-connector-rabbitmq/pull/1#issuecomment-1135011871
This is a copy from the original PR
(https://github.com/apache/flink/pull/15140) against the Flink repository.
--
This is an automated message from the Apache Git Service.
To
pscls commented on PR #1:
URL:
https://github.com/apache/flink-connector-rabbitmq/pull/1#issuecomment-1135015425
@MartijnVisser We are not exactly sure what has to be part of the root-pom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
MartijnVisser commented on PR #1:
URL:
https://github.com/apache/flink-connector-rabbitmq/pull/1#issuecomment-1135867243
@pscls I think you've done a good job already with the root-pom; it looks
like the one we currently have for Elasticsearch. I've just approved the run,
so we can also se
chayim commented on PR #2:
URL:
https://github.com/apache/flink-connector-redis/pull/2#issuecomment-1136864263
@MartijnVisser Pinging here - as this superceeds
https://github.com/apache/flink/pull/15487
--
This is an automated message from the Apache Git Service.
To respond to the messag
MartijnVisser commented on PR #2:
URL:
https://github.com/apache/flink-connector-redis/pull/2#issuecomment-1137146071
@chayim Thanks for that! I'm off for a little bit but I'll see if we can
find anyone who can help with a review of this!
--
This is an automated message from the Apache G
sazzad16 commented on PR #2:
URL:
https://github.com/apache/flink-connector-redis/pull/2#issuecomment-1137164171
@MartijnVisser Thank you :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
chayim commented on PR #2:
URL:
https://github.com/apache/flink-connector-redis/pull/2#issuecomment-1148455033
@MartijnVisser any luck finding someone to help? Hope you're enjoying your
time off!
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
MartijnVisser commented on PR #2:
URL:
https://github.com/apache/flink-connector-redis/pull/2#issuecomment-1148571757
@chayim Not yet, I'm bringing this PR up in our release meet-up which is
scheduled for next week on Tuesday!
--
This is an automated message from the Apache Git Service.
MartijnVisser commented on PR #2:
URL:
https://github.com/apache/flink-connector-redis/pull/2#issuecomment-1148589486
@sazzad16 One request from my end: can you rebase on the current `main`
branch to get the correct ASF repository configuration in. It will avoid
creating a lot of comments
sazzad16 commented on PR #2:
URL:
https://github.com/apache/flink-connector-redis/pull/2#issuecomment-1148599822
@MartijnVisser It is already rebased. Just rechecked.
Is there anything missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
MartijnVisser commented on PR #1:
URL:
https://github.com/apache/flink-connector-rabbitmq/pull/1#issuecomment-1160080270
@pscls Can you have a look at the failing build? It's a checkstyle error.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
wanglijie95 commented on PR #1:
URL:
https://github.com/apache/flink-connector-rabbitmq/pull/1#issuecomment-1160089843
@MartijnVisser @pscls I noticed that the GitBox of flink-connector-rabbitmq
sent emails to the dev@flink.apache.org. Is it expected?
--
This is an automated message
MartijnVisser commented on PR #1:
URL:
https://github.com/apache/flink-connector-rabbitmq/pull/1#issuecomment-1160102027
@wanglijie95 No. Most likely this is caused because the PR was created/is
not yet using the ASF config as defined in
https://github.com/apache/flink-connector-rabbitmq/b
knaufk commented on PR #2:
URL:
https://github.com/apache/flink-connector-redis/pull/2#issuecomment-1190766247
Thanks @sazzad16 for you contribution and patience. I think the community
would really benefit from a Redis Connector and I'll try to help you get this
in.
The main challe
sazzad16 commented on PR #2:
URL:
https://github.com/apache/flink-connector-redis/pull/2#issuecomment-1193897653
Hi @knaufk,
Thanks for the pointers and the feedback!
@MartijnVisser has also sent me more read material including
https://cwiki.apache.org/confluence/display/FLINK
eskabetxe opened a new pull request, #3:
URL: https://github.com/apache/flink-connector-redis/pull/3
Add basic RedisSink based on AsyncSinkWriter
As Jedis dont have a async call, it was implemented.
Maybe better choice was to use lettuce or Redisson libs..
Need to be added a
MartijnVisser merged PR #4:
URL: https://github.com/apache/flink-connector-redis/pull/4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@
MartijnVisser commented on PR #1:
URL:
https://github.com/apache/flink-connector-rabbitmq/pull/1#issuecomment-1203925901
@pscls The CI fails due to spotless; can you fix that? (By running `mvn
spotless:apply`)
--
This is an automated message from the Apache Git Service.
To respond to the
pscls commented on PR #1:
URL:
https://github.com/apache/flink-connector-rabbitmq/pull/1#issuecomment-1209062942
> @pscls The CI fails due to spotless; can you fix that? (By running `mvn
spotless:apply`)
@MartijnVisser I've nothing to commit when running `mvn spotless:apply`.
http
MartijnVisser commented on PR #1:
URL:
https://github.com/apache/flink-connector-rabbitmq/pull/1#issuecomment-1232836643
@pscls Weird. Could you push once more, since the logs are no longer
available?
--
This is an automated message from the Apache Git Service.
To respond to the message,
MartijnVisser commented on PR #2:
URL:
https://github.com/apache/flink-connector-rabbitmq/pull/2#issuecomment-1262073428
@zentol Ideally this will be available for
https://github.com/apache/flink-connector-rabbitmq/pull/1 benefits from it when
rebasing
--
This is an automated message fr
MartijnVisser merged PR #2:
URL: https://github.com/apache/flink-connector-rabbitmq/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr.
zentol opened a new pull request, #1:
URL: https://github.com/apache/flink-connector-shared-utils/pull/1
This PR adds the first version of shared release utilities for connectors.
The expectation is that the `release_utils` branch will be mounted as a git
submodule into each connector
zentol commented on PR #1:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/1#issuecomment-1297059496
Note that we could just do a review round, and then try them out for the ES
connector release before merging them.
--
This is an automated message from the Apache Git Ser
MartijnVisser commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/1#discussion_r1010743355
##
README.md:
##
@@ -1 +1,79 @@
-This repository contains utilities for [Apache
Flink](https://flink.apache.org/) connectors.
\ No newline at end
zentol commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/1#discussion_r1011296837
##
check_environment.sh:
##
@@ -0,0 +1,67 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contribut
zentol commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/1#discussion_r1011297983
##
_init.sh:
##
@@ -0,0 +1,45 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license a
zentol commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/1#discussion_r1011301075
##
README.md:
##
@@ -1 +1,79 @@
-This repository contains utilities for [Apache
Flink](https://flink.apache.org/) connectors.
\ No newline at end of fil
zentol commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/1#discussion_r1011301544
##
publish_git_tag.sh:
##
@@ -0,0 +1,46 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor
zentol commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/1#discussion_r1011297983
##
_init.sh:
##
@@ -0,0 +1,45 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license a
zentol commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/1#discussion_r1011368848
##
_utils.sh:
##
@@ -0,0 +1,59 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
zentol commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/1#discussion_r1011369044
##
README.md:
##
@@ -1 +1,79 @@
-This repository contains utilities for [Apache
Flink](https://flink.apache.org/) connectors.
\ No newline at end of fil
zentol commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/1#discussion_r1011501540
##
stage_jars.sh:
##
@@ -0,0 +1,55 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor lice
zentol commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/1#discussion_r1011501540
##
stage_jars.sh:
##
@@ -0,0 +1,55 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor lice
leonardBang commented on PR #1:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/1#issuecomment-1299982431
Thanks @zentol and @zentol for driving this, but I saw `dev` mail list
received all PR updates information from this repo, is there some settings
incorrect?
--
Th
MartijnVisser commented on PR #1:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/1#issuecomment-1299988788
> Thanks @zentol and @MartijnVisser for driving this, but I saw `dev` mail
list received all PR updates information from this repo, is there some settings
incorrect?
leonardBang commented on PR #1:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/1#issuecomment-1303154579
Happy to see you start working @zentol , Could you take a look my comments
here? https://github.com/apache/flink/pull/21227 sorry to reply under this
issue but I've tr
zentol commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/1#discussion_r1016492375
##
README.md:
##
@@ -1 +1,79 @@
-This repository contains utilities for [Apache
Flink](https://flink.apache.org/) connectors.
\ No newline at end of fil
zentol merged PR #1:
URL: https://github.com/apache/flink-connector-shared-utils/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@
lindong28 opened a new pull request #1:
URL: https://github.com/apache/flink-ml/pull/1
## What is the purpose of the change
Move Flink ML pipeline API and library code from apache/flink to
apache/flink-ml
## Brief change log
- Move files under flink/flink-ml-parent to f
lindong28 commented on pull request #1:
URL: https://github.com/apache/flink-ml/pull/1#issuecomment-809144123
@becketqin Could you review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
becketqin merged pull request #1:
URL: https://github.com/apache/flink-ml/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please co
becketqin commented on pull request #1:
URL: https://github.com/apache/flink-ml/pull/1#issuecomment-809247359
@lindong28 Thanks for the patch. Merged to master.
08d058046f34b711128e0646ffbdc7e384c22064
--
This is an automated message from the Apache Git Service.
To respond to the m
lindong28 opened a new pull request #2:
URL: https://github.com/apache/flink-ml/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, ple
lindong28 commented on pull request #2:
URL: https://github.com/apache/flink-ml/pull/2#issuecomment-810706284
@becketqin Could you review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
AHeise closed pull request #1:
URL: https://github.com/apache/flink-connectors/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr
JingGe opened a new pull request #2:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/2
## What is the purpose of the change
**Attention**: this PR is still under construction with the following tasks:
1. merge the change of #18634
2. remove all code and test re
MartijnVisser commented on pull request #2:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/2#issuecomment-1083152212
@JingGe Thanks for this! Should we also be able to run `mvn clean install` ?
I've tried that, but I'm getting getting some errors:
```
```
--
MartijnVisser edited a comment on pull request #2:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/2#issuecomment-1083152212
@JingGe Thanks for this! Should we also be able to run `mvn clean install` ?
I've tried that, but I'm getting getting some errors:
```
[I
JingGe commented on pull request #2:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/2#issuecomment-1083166099
> @JingGe Thanks for this! Should we also be able to run `mvn clean install`
? I've tried that, but I'm getting getting some errors:
looks like a Java ver
MartijnVisser commented on pull request #2:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/2#issuecomment-1083167678
> > @JingGe Thanks for this! Should we also be able to run `mvn clean
install` ? I've tried that, but I'm getting getting some errors:
>
> looks li
MartijnVisser opened a new pull request #3:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/3
Matching https://github.com/apache/flink/blob/master/.asf.yaml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
AHeise merged pull request #3:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
MarkSfik commented on a change in pull request #328:
URL: https://github.com/apache/flink-web/pull/328#discussion_r411336028
##
File path: _posts/2020-04-17-memory-management-improvements-flink-1.10.md
##
@@ -0,0 +1,87 @@
+---
+layout: post
+title: "Memory Management improvemen
MarkSfik commented on a change in pull request #328:
URL: https://github.com/apache/flink-web/pull/328#discussion_r411336241
##
File path: _posts/2020-04-17-memory-management-improvements-flink-1.10.md
##
@@ -0,0 +1,87 @@
+---
+layout: post
+title: "Memory Management improvemen
MarkSfik commented on a change in pull request #328:
URL: https://github.com/apache/flink-web/pull/328#discussion_r411336465
##
File path: _posts/2020-04-17-memory-management-improvements-flink-1.10.md
##
@@ -0,0 +1,87 @@
+---
+layout: post
+title: "Memory Management improvemen
MarkSfik commented on a change in pull request #328:
URL: https://github.com/apache/flink-web/pull/328#discussion_r411336895
##
File path: _posts/2020-04-17-memory-management-improvements-flink-1.10.md
##
@@ -0,0 +1,87 @@
+---
+layout: post
+title: "Memory Management improvemen
MarkSfik commented on a change in pull request #328:
URL: https://github.com/apache/flink-web/pull/328#discussion_r411337034
##
File path: _posts/2020-04-17-memory-management-improvements-flink-1.10.md
##
@@ -0,0 +1,87 @@
+---
+layout: post
+title: "Memory Management improvemen
MarkSfik commented on a change in pull request #328:
URL: https://github.com/apache/flink-web/pull/328#discussion_r411337742
##
File path: _posts/2020-04-17-memory-management-improvements-flink-1.10.md
##
@@ -0,0 +1,87 @@
+---
+layout: post
+title: "Memory Management improvemen
MarkSfik commented on a change in pull request #328:
URL: https://github.com/apache/flink-web/pull/328#discussion_r411337034
##
File path: _posts/2020-04-17-memory-management-improvements-flink-1.10.md
##
@@ -0,0 +1,87 @@
+---
+layout: post
+title: "Memory Management improvemen
MarkSfik commented on a change in pull request #328:
URL: https://github.com/apache/flink-web/pull/328#discussion_r411339534
##
File path: _posts/2020-04-17-memory-management-improvements-flink-1.10.md
##
@@ -0,0 +1,87 @@
+---
+layout: post
+title: "Memory Management improvemen
MarkSfik commented on a change in pull request #328:
URL: https://github.com/apache/flink-web/pull/328#discussion_r409549023
##
File path: _posts/2020-04-17-memory-management-improvements-flink-1.10.md
##
@@ -0,0 +1,87 @@
+---
+layout: post
+title: "Memory Management improvemen
MarkSfik commented on a change in pull request #328:
URL: https://github.com/apache/flink-web/pull/328#discussion_r411340267
##
File path: _posts/2020-04-17-memory-management-improvements-flink-1.10.md
##
@@ -0,0 +1,87 @@
+---
+layout: post
+title: "Memory Management improvemen
zentol opened a new pull request #84:
URL: https://github.com/apache/flink-shaded/pull/84
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
azagrebin commented on a change in pull request #328:
URL: https://github.com/apache/flink-web/pull/328#discussion_r411984361
##
File path: _posts/2020-04-17-memory-management-improvements-flink-1.10.md
##
@@ -0,0 +1,87 @@
+---
+layout: post
+title: "Memory Management Improveme
azagrebin commented on a change in pull request #328:
URL: https://github.com/apache/flink-web/pull/328#discussion_r411989670
##
File path: _posts/2020-04-17-memory-management-improvements-flink-1.10.md
##
@@ -0,0 +1,87 @@
+---
+layout: post
+title: "Memory Management Improveme
azagrebin commented on a change in pull request #328:
URL: https://github.com/apache/flink-web/pull/328#discussion_r411994775
##
File path: _posts/2020-04-17-memory-management-improvements-flink-1.10.md
##
@@ -0,0 +1,87 @@
+---
+layout: post
+title: "Memory Management Improveme
azagrebin commented on a change in pull request #328:
URL: https://github.com/apache/flink-web/pull/328#discussion_r411994181
##
File path: _posts/2020-04-17-memory-management-improvements-flink-1.10.md
##
@@ -0,0 +1,87 @@
+---
+layout: post
+title: "Memory Management Improveme
azagrebin commented on a change in pull request #328:
URL: https://github.com/apache/flink-web/pull/328#discussion_r411995447
##
File path: _posts/2020-04-17-memory-management-improvements-flink-1.10.md
##
@@ -0,0 +1,87 @@
+---
+layout: post
+title: "Memory Management Improveme
azagrebin commented on a change in pull request #328:
URL: https://github.com/apache/flink-web/pull/328#discussion_r411995827
##
File path: _posts/2020-04-17-memory-management-improvements-flink-1.10.md
##
@@ -0,0 +1,87 @@
+---
+layout: post
+title: "Memory Management Improveme
dianfu commented on issue #329:
URL: https://github.com/apache/flink-web/pull/329#issuecomment-618330787
@carp84 @uce Thanks a lot for the review. I will update the post date and
release date before merging this PR.
This is
carp84 opened a new pull request #330:
URL: https://github.com/apache/flink-web/pull/330
Adds release announcement and download link for 1.10.1
Dates on announcements are still TBD and should be updated accordingly once
release happens.
-
dianfu commented on pull request #329:
URL: https://github.com/apache/flink-web/pull/329#issuecomment-619327260
Merged via af2d8de132b73f0dae6fd88912fe1c92202f3efe
This is an automated message from the Apache Git Service.
To
klion26 commented on a change in pull request #235:
URL: https://github.com/apache/flink-web/pull/235#discussion_r417031566
##
File path: contributing/how-to-contribute.zh.md
##
@@ -4,136 +4,138 @@ title: "如何参与贡献"
-Apache Flink is developed by an open and friendly communi
klion26 commented on pull request #242:
URL: https://github.com/apache/flink-web/pull/242#issuecomment-620981849
@shining-huang thanks for your contribution. could you please resolve the
conflic by rebasing the newly master?
klion26 edited a comment on pull request #242:
URL: https://github.com/apache/flink-web/pull/242#issuecomment-620981849
@shining-huang thanks for your contribution. could you please resolve the
conflict by rebasing the newly master?
piyushnarang opened a new pull request #85:
URL: https://github.com/apache/flink-shaded/pull/85
Follow up from https://github.com/apache/flink/pull/11938 to commit in the
right project.
Picking up the updated zk dependency allows us to get around an issue in the
`StaticHostProvider` in
piyushnarang commented on pull request #85:
URL: https://github.com/apache/flink-shaded/pull/85#issuecomment-621507875
cc @zentol - I tried using this version on Flink and I hit the issues that
were captured in https://issues.apache.org/jira/browse/FLINK-11259
We need to make a minor twe
klion26 commented on a change in pull request #245:
URL: https://github.com/apache/flink-web/pull/245#discussion_r417746431
##
File path: contributing/code-style-and-quality-preamble.zh.md
##
@@ -1,25 +1,25 @@
---
-title: "Apache Flink Code Style and Quality Guide — Preamble"
klion26 commented on pull request #245:
URL: https://github.com/apache/flink-web/pull/245#issuecomment-621605899
Seems the original author's account has been deleted. maybe someone else can
take over this?
This is an automat
XBaith commented on a change in pull request #245:
URL: https://github.com/apache/flink-web/pull/245#discussion_r417749335
##
File path: contributing/code-style-and-quality-preamble.zh.md
##
@@ -1,25 +1,25 @@
---
-title: "Apache Flink Code Style and Quality Guide — Preamble"
klion26 commented on pull request #247:
URL: https://github.com/apache/flink-web/pull/247#issuecomment-621676247
@chaojianok thanks for your contribution. could you please get rid of the
`git merge` commit in the history. you can use `git rebase` or the other git
command to achieve it.
zentol commented on a change in pull request #85:
URL: https://github.com/apache/flink-shaded/pull/85#discussion_r417859654
##
File path: flink-shaded-zookeeper-parent/flink-shaded-zookeeper-34/pom.xml
##
@@ -128,4 +128,4 @@ under the License.
-
R
klion26 commented on a change in pull request #245:
URL: https://github.com/apache/flink-web/pull/245#discussion_r417948740
##
File path: contributing/code-style-and-quality-preamble.zh.md
##
@@ -1,25 +1,25 @@
---
-title: "Apache Flink Code Style and Quality Guide — Preamble"
morsapaes opened a new pull request #332:
URL: https://github.com/apache/flink-web/pull/332
Adding a blogpost to announce Flink's application to [Google Season of
Docs](https://developers.google.com/season-of-docs).
This is
piyushnarang commented on pull request #85:
URL: https://github.com/apache/flink-shaded/pull/85#issuecomment-621874740
Yeah, let me double check if things continue to work after the excludes.
This is an automated message from
piyushnarang commented on a change in pull request #85:
URL: https://github.com/apache/flink-shaded/pull/85#discussion_r418035841
##
File path: flink-shaded-zookeeper-parent/flink-shaded-zookeeper-34/pom.xml
##
@@ -128,4 +128,4 @@ under the License.
piyushnarang commented on pull request #85:
URL: https://github.com/apache/flink-shaded/pull/85#issuecomment-622144494
@zentol added the updates you requested. I did some basic sanity checking /
testing after excluding the spotbugs and jsr305 and it seems to work ok. Do you
know if there's
alpinegizmo opened a new pull request #333:
URL: https://github.com/apache/flink-web/pull/333
Now that the documentation has a training section, it would be good to help
folks find it by promoting it from the project website.
This adds training.md and training.zh.md, and adds a Train
alpinegizmo commented on pull request #333:
URL: https://github.com/apache/flink-web/pull/333#issuecomment-622351679
I've created https://issues.apache.org/jira/browse/FLINK-17491 for the
Chinese translation.
This is an auto
morsapaes commented on pull request #333:
URL: https://github.com/apache/flink-web/pull/333#issuecomment-622432180
Hey, David! Thanks a lot for doing the whole integration of the training —
it's a super valuable resource that indeed deserves more attention.
What about linking this fr
XBaith commented on pull request #333:
URL: https://github.com/apache/flink-web/pull/333#issuecomment-622439043
> Hey, David! Thanks a lot for doing the whole integration of the training —
it's a super valuable resource that indeed deserves more attention.
>
> What about linking this
1 - 100 of 115 matches
Mail list logo
