Re: [VOTE] FLIP-372: Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable

2023-12-19 Thread Yanquan Lv
+1 (non-binding) Merging multiple write results into one submission is a common scenario we encounter. But in the process of implementing the addPreCommitTopology, I feel that the logic of regenerating CommittableSummary objects is a bit hidden. Best, Yanquan Lv. Péter Váry 于2023年12月18日周一 16:35

Re: [VOTE] Release flink-connector-jdbc, release candidate #3

2024-02-02 Thread Yanquan Lv
+1 (non-binding) - Validated checksum hash - Verified signature - Build the source with Maven and jdk8/11/17 - Check that the jar is built by jdk8 - Verified that no binaries exist in the source archive Sergey Nuyanzin 于2024年2月1日周四 19:50写道: > Hi everyone, > Please review and vote on the release

Re: [ANNOUNCE] New Apache Flink Committer - Jiabao Sun

2024-02-19 Thread Yanquan Lv
Congratulations, Jiabao. He Wang 于2024年2月19日周一 19:21写道: > Congrats, Jiabao! > > On Mon, Feb 19, 2024 at 7:19 PM Benchao Li wrote: > > > Congrats, Jiabao! > > > > Zhanghao Chen 于2024年2月19日周一 18:42写道: > > > > > > Congrats, Jiaba! > > > > > > Best, > > > Zhanghao Chen > > > __

Re: [VOTE] Release flink-connector-parent 1.1.0 release candidate #2

2024-02-24 Thread Yanquan Lv
+1 (non-binding) - verified release notes - verified checksum and signature - build with java8/11/17 - Verified no binaries in source files - reviewed the web PR Etienne Chauchot 于2024年2月20日周二 01:34写道: > Hi everyone, > Please review and vote on the release candidate #2 for the version > 1.1.0,

Re: [DISCUSS] FLIP-399: Flink Connector Doris

2024-03-02 Thread Yanquan Lv
Thanks for driving this. The content is very detailed, it is recommended to add a section on Test Plan for more completeness. Di Wu 于2024年1月25日周四 15:40写道: > Hi all, > > Previously, we had some discussions about contributing Flink Doris > Connector to the Flink community [1]. I want to further pr

Re: [DISCUSS] FLIP Suggestion: Externalize Kudu Connector from Bahir

2024-03-10 Thread Yanquan Lv
Hi Ferenc, +1 for this FLIP. Ferenc Csaky 于2024年3月9日周六 01:49写道: > Thank you Jeyhun, Leonard, and Hang for your comments! Let me > address them from earliest to latest. > > > How do you plan the review process in this case (e.g. incremental > over existing codebase or cumulative all at once) ? >

Re: [ANNOUNCE] Apache Flink 1.19.0 released

2024-03-20 Thread Yanquan Lv
Congratulations! Thanks to all contributors. Best, Yanquan Shawn Huang 于2024年3月19日周二 15:12写道: > Congratulations! > > Best, > Shawn Huang > > > Xuannan Su 于2024年3月19日周二 14:40写道: > > > Congratulations! Thanks for all the great work! > > > > Best regards, > > Xuannan > > > > On Tue, Mar 19, 2024

Re: [DISCUSS] Flink Website Menu Adjustment

2024-03-25 Thread Yanquan Lv
+1 for this proposal. gongzhongqiang 于2024年3月25日周一 15:49写道: > Hi everyone, > > I'd like to start a discussion on adjusting the Flink website [1] menu to > improve accuracy and usability.While migrating Flink CDC documentation > to the website, I found outdated links, need to review and update me

Re: [ANNOUNCE] New Apache Flink PMC Member - Lincoln Lee

2024-04-14 Thread Yanquan Lv
Congratulations, Lincoln. Jark Wu 于2024年4月12日周五 15:59写道: > Hi everyone, > > On behalf of the PMC, I'm very happy to announce that Lincoln Lee has > joined the Flink PMC! > > Lincoln has been an active member of the Apache Flink community for > many years. He mainly works on Flink SQL component a

Re: [ANNOUNCE] New Apache Flink PMC Member - Jing Ge

2024-04-14 Thread Yanquan Lv
Congratulations, Jing! Jark Wu 于2024年4月12日周五 16:03写道: > Hi everyone, > > On behalf of the PMC, I'm very happy to announce that Jing Ge has > joined the Flink PMC! > > Jing has been contributing to Apache Flink for a long time. He continuously > works on SQL, connectors, Source, and Sink APIs, te

Re: [VOTE] FLIP-399: Flink Connector Doris

2024-04-14 Thread Yanquan Lv
+1 (non-binding), thanks for it. wudi <676366...@qq.com.invalid> 于2024年4月9日周二 10:48写道: > Hi devs, > > I would like to start a vote about FLIP-399 [1]. The FLIP is about > contributing the Flink Doris Connector[2] to the Flink community. > Discussion thread [3]. > > The vote will be open for at le

Re: [ANNOUNCE] New Apache Flink Committer - Zakelly Lan

2024-04-14 Thread Yanquan Lv
Congratulations, Zakelly! Best, YanQuan Yuan Mei 于2024年4月15日周一 10:51写道: > Hi everyone, > > On behalf of the PMC, I'm happy to let you know that Zakelly Lan has become > a new Flink Committer! > > Zakelly has been continuously contributing to the Flink project since 2020, > with a focus area on

Re: [VOTE] Apache Flink CDC Release 3.1.0, release candidate #3

2024-05-14 Thread Yanquan Lv
+1 (non-binding) - Validated checksum hash - Build the source with Maven and jdk8 - Verified web PR - Check that the jar is built by jdk8 - Check synchronizing from mysql to paimon - Check synchronizing from mysql to kafka Hang Ruan 于2024年5月13日周一 13:55写道: > +1 (non-binding) > > - Validated check

Re: [ANNOUNCE] Apache Flink CDC 3.1.0 released

2024-05-17 Thread Yanquan Lv
Congratulations! Thanks for all selfless contributors. Best, Yanquan Lv Ahmed Hamdy 于2024年5月17日周五 18:49写道: > Congratulations, > Great Work! > Best Regards > Ahmed Hamdy > > > On Fri, 17 May 2024 at 10:56, ConradJam wrote: > > > Congratulations! > > > &g

Re: [DISCUSS] Add a JDBC Sink Plugin to Flink-CDC-Pipeline

2024-05-22 Thread Yanquan Lv
Thanks jerry for driving this, JDBC sink for CDC pipeline is indeed a high demand in the community. I have one concern: Some databases that use jdbc, such as mysql, may be time-consuming to perform table structure changes, but FlinkCDC will not send DataChangeEvent during this period, which can ca

Re: [VOTE] Release flink-connector-kafka v3.2.0, release candidate #1

2024-06-06 Thread Yanquan Lv
+1 (non-binding) - verified gpg signatures - verified sha512 hash - built from source code with java 8/11/17 - checked Github release tag - checked the CI result - checked release notes Danny Cranmer 于2024年4月22日周一 21:56写道: > Hi everyone, > > Please review and vote on release candidate #1 for fl

Re: [DISCUSS] FLIP-463: Schema Definition in CREATE TABLE AS Statement

2024-06-11 Thread Yanquan Lv
Hi Sergio, thanks for driving it, +1 for this. I have some comments: 1. If we have a source table with primary keys and partition keys defined, what is the default behavior if PARTITIONED and DISTRIBUTED not specified in the CTAS statement, It should not be inherited by default? 2. I suggest provi

Re: [ANNOUNCE] New Apache Flink Committer - Hang Ruan

2024-06-16 Thread Yanquan Lv
Congratulations, Hang! Samrat Deb 于2024年6月17日周一 11:32写道: > Congratulations Hang Ruan ! > > Bests, > Samrat > > On Mon, Jun 17, 2024 at 8:47 AM Leonard Xu wrote: > > > Hi everyone, > > On behalf of the PMC, I'm happy to let you know that Hang Ruan has become > > a new Flink Committer ! > > > > H

Re: [ANNOUNCE] New Apache Flink Committer - Zhongqiang Gong

2024-06-16 Thread Yanquan Lv
Congratulations, Zhongqiang! Shawn Huang 于2024年6月17日周一 12:05写道: > Congratulations ! > > Best, > Shawn Huang > > > Yuepeng Pan 于2024年6月17日周一 12:03写道: > > > Congratulations ! Best regards Yuepeng Pan > > > > > > > > > > > > At 2024-06-17 11:20:30, "Leonard Xu" wrote: > > >Hi everyone, > > >On be

Re: [VOTE] Apache Flink CDC Release 3.1.1, release candidate #0

2024-06-17 Thread Yanquan Lv
+1 (non-binding) - verified gpg signatures - verified sha512 hash - checked Github release tag - checked release notes - restarted job with savepoint from cdc 3.0.1 Xiqian YU 于2024年6月14日周五 18:34写道: > Thanks Qingsheng for driving this release! > > +1 (non-binding) > > > * Verified tarball ch

Re: [VOTE] FLIP-463: Schema Definition in CREATE TABLE AS Statement

2024-06-22 Thread Yanquan Lv
Thnaks Sergio, +1 (non-binding) gongzhongqiang 于2024年6月23日周日 10:06写道: > +1 (non-binding) > > Best, > Zhongqiang Gong > > Sergio Pena 于2024年6月21日周五 22:18写道: > > > Hi everyone, > > > > Thanks for all the feedback about FLIP-463: Schema Definition in CREATE > > TABLE AS Statement [1]. The discussi

Re: [DISCUSS] FLIP-456: Introduce DESCRIBE FUNCTION

2024-06-30 Thread Yanquan Lv
Hi, Natea. This FLIP looks good from my side. I also look forward to showing the return type, as well as auxiliary information such as comments or usage, although the current implementation does not include this part. Natea Eshetu Beshada 于2024年6月26日周三 03:01写道: > Oh no haha, yes thanks for poin

Re: [VOTE] FLIP-465: Introduce DESCRIBE FUNCTION

2024-07-03 Thread Yanquan Lv
Hi Natea, thanks for driving it. +1 (non-binding). Jim Hughes 于2024年7月4日周四 04:41写道: > Hi Natea, > > Looks good to me! > > +1 (non-binding). > > Cheers, > > Jim > > On Wed, Jul 3, 2024 at 3:16 PM Natea Eshetu Beshada > wrote: > > > Sorry I forgot to include the FLIP [1] and the mailing thread di

Re: [VOTE] FLIP-460: Display source/sink I/O metrics on Flink Web UI

2024-07-16 Thread Yanquan Lv
+1 (non-binding) Glad to see a more user-friendly display page. Best, Yanquan Rui Fan <1996fan...@gmail.com> 于2024年7月17日周三 09:48写道: > +1 (binding) > > Best, > Rui > > On Wed, Jul 17, 2024 at 9:07 AM Xintong Song > wrote: > > > +1 (binding) > > > > Best, > > > > Xintong > > > > > > > > On Wed,

Re: [DISCUSS] FLIP-XXX Amazon SQS Source Connector

2024-07-21 Thread Yanquan Lv
Hi Dhingra, thanks for driving this. I am not very familiar with SQS, but this should be some kind of message queue. So could we add metric of currentFetchEventTimeLag and currentEmitEventTimeLag from FLIP-33[1] in SQS source? and I want to know what metrics do we provide in SQS source. [1] http

Re: Discussion on Vertica-Flink Connector

2024-07-23 Thread Yanquan Lv
Hi, Vikas. Vertica can be connected and accessed through JDBC API, I'm not sure if you connected through this API, Flink already provided a flink-connector-jdbc repo, and Supported a considerable number of databases through dialect, could we add a Vertica implementation on this? [1] https://github

Re: [ANNOUNCE] New Apache Flink Committer - Xuannan Su

2024-08-17 Thread Yanquan Lv
Congratulations Xuannan! Hong 于2024年8月18日周日 04:42写道: > Congratulations Xuannan! > > Hong > > > On 17 Aug 2024, at 17:56, Samrat Deb wrote: > > > > congratulations Xuannan Su ! > > > > Bests, > > Samrat > > > >> On Sat, Aug 17, 2024 at 9:15 PM Qingsheng Ren wrote: > >> > >> Congratulations a

Re: [VOTE] Apache Flink CDC Release 3.2.0, release candidate #0

2024-08-18 Thread Yanquan Lv
Hi Qingsheng, I've tested and met a NotSerializableException[1] that will lead to failure when using Kafka as pipeline sink in 3.2.0 version. I think it may be a blocker as this happened during the submission phase. [1] https://issues.apache.org/jira/browse/FLINK-36082 Qingsheng Ren 于2024年8月15日周

Re: [VOTE] Apache Flink CDC Release 3.2.0, release candidate #0

2024-08-18 Thread Yanquan Lv
/browse/FLINK-36082 [2] https://issues.apache.org/jira/browse/FLINK-36088 Yanquan Lv 于2024年8月18日周日 17:43写道: > Hi Qingsheng, I've tested and met a NotSerializableException[1] that will > lead to failure when using Kafka as pipeline sink in 3.2.0 version. > I think it may be a b