+1, there’re methods offer parameter with String which allows users to migrate.
Best,
Leonard
> On Jul 18, 2023, at 9:26 PM, Jing Ge wrote:
>
> +1
>
> On Tue, Jul 18, 2023 at 1:11 PM Chesnay Schepler wrote:
>
>> Good catch; i've fixed the list.
>>
>> On 18/07/2023 12:20, Xintong Song
+1
On Tue, Jul 18, 2023 at 1:11 PM Chesnay Schepler wrote:
> Good catch; i've fixed the list.
>
> On 18/07/2023 12:20, Xintong Song wrote:
> > +1 in general.
> >
> > I think the list of affected public interfaces in the FLIP is not
> accurate.
> >
> > - `#counter(int, Counter)` is missed
>
Good catch; i've fixed the list.
On 18/07/2023 12:20, Xintong Song wrote:
+1 in general.
I think the list of affected public interfaces in the FLIP is not accurate.
- `#counter(int, Counter)` is missed
- `#meter(int)` should be `#meter(int, Meter)`
- `#group(int)` should be
+1 in general.
I think the list of affected public interfaces in the FLIP is not accurate.
- `#counter(int, Counter)` is missed
- `#meter(int)` should be `#meter(int, Meter)`
- `#group(int)` should be `#addGroup(int)`
Best,
Xintong
On Tue, Jul 18, 2023 at 4:39 PM Chesnay Schepler
The MetricGroup interface contains methods to create groups and metrics
using an int as a name. The original intention was to allow pattern like
|group.addGroup("subtaskIndex").addGroup(0)| , but this didn't really
work out, with |addGroup(String, String)| serving this use case much
better.
