Re: [DISCUSS][TABLE] Issue with package structure in the Table API

2020-02-17 Thread Jingsong Li
Thanks for bringing this discussion. +1 to peforming this big change as early as possible. You solved my question, why we need "_root_". Yes, I don't like this import too. And it is very strange that expressionDsl is in api, but can only work in api.scala. (Because scala extends

Re: [DISCUSS][TABLE] Issue with package structure in the Table API

2020-02-13 Thread Timo Walther
Hi everyone, thanks for bringing our offline discussion to the mailing list, Dawid. This is a very bad mistake that has been made in the past. In general, we should discourage putting the terms "java" and "scala" in package names as this has side effects on Scala imports. I really don't

[DISCUSS][TABLE] Issue with package structure in the Table API

2020-02-13 Thread Dawid Wysakowicz
Hi devs, I wanted to bring up a problem that we have in our package structure. As a result of https://issues.apache.org/jira/browse/FLINK-13045 we started advertising importing two packages in the scala API: import org.apache.flink.table.api._ import org.apache.flink.table.api.scala._ The