Re: [DISCUSS] A mechanism to validate the precision of columns for connectors

2020-01-10 Thread Bowen Li
Hi Zhenghua, For external systems with schema, I think the schema information is available most of the time and should be the single source of truth to programmatically mapping column precision via Flink catalogs, to minimize users efforts creating schema redundantly again and avoid any human erro

Re: [DISCUSS] A mechanism to validate the precision of columns for connectors

2020-01-10 Thread Zhenghua Gao
Hi Jingsong Lee You are right that the connectors don't validate data types either now. We seems lack a mechanism to validate with properties[1], data types, etc for CREATE TABLE. [1] https://issues.apache.org/jira/browse/FLINK-15509 *Best Regards,* *Zhenghua Gao* On Fri, Jan 10, 2020 at 2:59

Re: [DISCUSS] A mechanism to validate the precision of columns for connectors

2020-01-09 Thread Jingsong Li
Hi Zhenghua, I think it's not just about precision of type. Connectors not validate the types either. Now there is "SchemaValidator", this validator is just used to validate type properties. But not for connector type support. I think we can have something like "DataTypeValidator" to help connecto

[DISCUSS] A mechanism to validate the precision of columns for connectors

2020-01-09 Thread Zhenghua Gao
Hi dev, I'd like to kick off a discussion on a mechanism to validate the precision of columns for some connectors. We come to an agreement that the user should be informed if the connector does not support the desired precision. And from the connector developer's view, there are 3-levels informat