A bit late but also +1 for the proposal to return an empty
iterator/collection.
Cheers,
Till
On Mon, May 11, 2020 at 11:17 AM SteNicholas wrote:
> Hi Tang Yun,
> I have already created new issue for FLINK-17610 to align the behavior
> of result of internal map state to return empty
Hi Tang Yun,
I have already created new issue for FLINK-17610 to align the behavior
of result of internal map state to return empty iterator. Please check this
issue, if you have any question for it, please let me know about this.
Thanks,
Nicholas Jiang
--
Sent from:
Thanks for everyone's positive response. FLINK-17610 [1] have been created to
track this problem.
[1] https://issues.apache.org/jira/browse/FLINK-17610
Best
Yun Tang
From: Congxian Qiu
Sent: Monday, May 11, 2020 13:42
To: dev@flink.apache.org
Subject: Re:
+1 to align the behavior to returning empty iterator. and I think this is
what's the code style[1] said.
Best,
Congxian
Yu Li 于2020年5月11日周一 上午11:42写道：
> +1 to align the behavior to returning empty iterator. There's no `Nullable`
> annotation on the `MapState` interfaces, either.
>
> Best
+1 to align the behavior to returning empty iterator. There's no `Nullable`
annotation on the `MapState` interfaces, either.
Best Regards,
Yu
On Mon, 11 May 2020 at 11:21, Pengfei Li wrote:
> +1 to align the behavior
>
> Jark Wu 于2020年5月9日周六 下午9:36写道：
>
> > +1 to return emty iterator and
+1 to align the behavior
Jark Wu 于2020年5月9日周六 下午9:36写道：
> +1 to return emty iterator and align the implementations.
>
> Best,
> Jark
>
> On Sat, 9 May 2020 at 19:18, SteNicholas wrote:
>
> > Hi Tang Yun,
> > I agree with the point you mentioned that align these internal
> > behavior
> >
+1 to return emty iterator and align the implementations.
Best,
Jark
On Sat, 9 May 2020 at 19:18, SteNicholas wrote:
> Hi Tang Yun,
> I agree with the point you mentioned that align these internal
> behavior
> to return empty iterator instead of null. In my opinion,
>
Hi Tang Yun,
I agree with the point you mentioned that align these internal behavior
to return empty iterator instead of null. In my opinion,
StateMapViewWithKeysNullable handle nullable map keys, and result of
internal map state should be empty map in the null behavior case. Therefore,
as
Hi devs
This thread is inspired by FLINK-17015 [1] which meet NEP when SQL guys develop
operator based on internal map state.
Unfortunately, we have different behavior of result of internal map state. For
HeapMapState, #entries(), #keys(), #values(), and #iterator() would all return
null.
