Re: [DISCUSS] Backpoint FLIP-126 (watermarks) integration with FLIP-27

2020-05-28 Thread Aljoscha Krettek
by Stephan and Becket here, I am +1 to backport it to release-1.11. Best, Zhijiang -- From:Piotr Nowojski Send Time:2020年5月26日(星期二) 18:51 To:Becket Qin Cc:Stephan Ewen ; dev ; zhijiang Subject:Re: [DISCUSS] Backpoint FLIP-126

Re: [DISCUSS] Backpoint FLIP-126 (watermarks) integration with FLIP-27

2020-05-26 Thread Zhijiang
Nowojski Send Time:2020年5月26日(星期二) 18:51 To:Becket Qin Cc:Stephan Ewen ; dev ; zhijiang Subject:Re: [DISCUSS] Backpoint FLIP-126 (watermarks) integration with FLIP-27 Hi, As we discussed this offline a bit, initially I was sceptical to merge it, as: - even it’s an isolated change, it can destabilise

Re: [DISCUSS] Backpoint FLIP-126 (watermarks) integration with FLIP-27

2020-05-26 Thread Piotr Nowojski
Hi, As we discussed this offline a bit, initially I was sceptical to merge it, as: - even it’s an isolated change, it can destabilise the builds and prolong release testing period - is distracting from solving release blockers etc However all in all I’m +0.5 to merge it because of this argument:

Re: [DISCUSS] Backpoint FLIP-126 (watermarks) integration with FLIP-27

2020-05-26 Thread Becket Qin
Usually we should avoid checking in patches other than bug fix after feature freeze. However, in this particular case, the code base is sort of in an incomplete state - an exposed known-to-change feature - due to missing this patch. Fixing forward seems the best option. Besides that, FLIP-27 has

[DISCUSS] Backpoint FLIP-126 (watermarks) integration with FLIP-27

2020-05-26 Thread Stephan Ewen
Hi all! I want to discuss merging this PR to the 1.11 release branch: https://github.com/apache/flink/pull/12306 It contains the new FLIP-126 Watermarks, and per-partition watermarking to the FLIP-27 sources. In that sense it is partially a new feature after the feature freeze. Hence this