Re: [DISCUSS] Component labels in PR/commit messages

2021-05-20 Thread Roman Khachatryan
Thanks for raising this issue. I agree with the above points. One simple argument against labels is that they consume space in the commit messages. +1 to make labels optional Regards, Roman On Thu, May 20, 2021 at 9:31 AM Robert Metzger wrote: > > +1 to Till's proposal to update the wording.

Re: [DISCUSS] Component labels in PR/commit messages

2021-05-20 Thread Robert Metzger
+1 to Till's proposal to update the wording. Regarding c) The guide [1] actually mentions a good heuristic for coming up with a label that is also suitable for newcomers: The maven module name where most of the changes are. [1]

Re: [DISCUSS] Component labels in PR/commit messages

2021-05-19 Thread Till Rohrmann
I think a big problem with the component labels is that there is a) no defined set of labels b) no way to enforce the usage of them c) no easy way to figure out which label to use Due to these problems they are used very inconsistently in the project. I do agree with Arvid's observation that

Re: [DISCUSS] Component labels in PR/commit messages

2021-05-19 Thread Chesnay Schepler
For commit messages the labels are useful mostly when scanning the commit history, like searching for some commit that could've caused something /without knowing where that change was made/, because it enables you to quickly filter out commits by their label instead of having to read the

[DISCUSS] Component labels in PR/commit messages

2021-05-19 Thread Arvid Heise
Dear devs, In the last couple of weeks, I have noticed that we are slacking a bit on the components in PR/commit messages. I'd like to gather some feedback if we still want to include them and if so, how we can improve the process of finding the correct label. My personal opinion: So far, I have