I agree with Ingo. We can open a new JIRA issue or thread to discuss it.
Best,
Jark
On Mon, 29 Nov 2021 at 16:26, Ingo Bürk wrote:
> I of course meant DQL, not DDL, but same thing either way. It is akin to
> e.g. SHOW TABLES.
>
> On Mon, Nov 29, 2021 at 9:24 AM Ingo Bürk wrote:
>
> > To me
I of course meant DQL, not DDL, but same thing either way. It is akin to
e.g. SHOW TABLES.
On Mon, Nov 29, 2021 at 9:24 AM Ingo Bürk wrote:
> To me this doesn't seem too related to the FLIP – this feature would
> require new DDL, and new DDL should live in Flink itself, not in the SQL
> client.
To me this doesn't seem too related to the FLIP – this feature would
require new DDL, and new DDL should live in Flink itself, not in the SQL
client.
I don't think this requires a FLIP, necessarily, though. It can probably
just be discussed on a JIRA issue.
Ingo
On Mon, Nov 29, 2021 at 9:19 AM
Hi Daisy
Thank you for the proposal.
I like it.
It was not discussed within this FLIP.
I'm not sure about the procedure in such cases (since voting finished).
Maybe a separate discussion thread makes sense.
However I think it could be done as well if there is no objection.
On Fri, Nov 26,
Hi,
would a command that shows the available table source/sink factories be
implemented? Something that can show that a factory is loaded, etc.
- Daisy
On Thu, Nov 4, 2021 at 8:30 AM Sergey Nuyanzin wrote:
> I've started a [VOTE] thread for this FLIP
>
I've started a [VOTE] thread for this FLIP
https://lists.apache.org/thread/f14jjhrscrdv7h6zw6h1k72nfx232qxs
On Wed, Nov 3, 2021 at 2:59 PM Sergey Nuyanzin wrote:
> Hi Timo,
>
> I completely agree it would be great if we can propagate Calcite parser
> config in
> the way you have described. As
Hi Timo,
I completely agree it would be great if we can propagate Calcite parser
config in
the way you have described. As you mentioned we could discuss this
when it comes to the implementation.
Meanwhile it looks like I can start voting (please correct me if I'm wrong).
I will start it a bit
Hi Sergey,
thanks for your explanation.
Regarding keywords and other info: We should receive the information
from the Flink SQL parser directly. We have added a couple of new
keywords such as WATERMARK or MATCH_RECOGNIZE clauses. SQL92 would not
help a user understand why a column name needs
Hi 李宇彬,
I think you are right. Thank you very much for the idea.
I came across MySQL[1] and PostgreSQL[2] prompts and also
found several interesting features like control symbols to change style,
showing current property value and different datetime formats.
I have added your proposals and my
Hi Sergey
It is a very useful improvement I'm looking forward to. in addition, I think
prompt
can play a greater role.
To help users call commands in expected context, we can get session context
(current catalog/db/time) from cli prompt like MySQL,
please see details as below:
Hi Timo
Thank you for your questions.
I will answer your questions here and update FLIP's page as well
>For example, who is responsible for parsing comments? I guess the SQL
>Client and not the Flink SQL parser will take care of this?
Yes, you are right. SQL Client is responsible for parsing
Hi Sergey,
thanks for this nice demo video. It looks very nice and makes the SQL
Client an even more useful tool.
What I miss a bit in the FLIP is the implementation details.
For example, who is responsible for parsing comments? I guess the SQL
Client and not the Flink SQL parser will take
Thank you very much for the feedback.
Thanks for the idea, Jark.
Yes, that is possible, I added this property to the FLIP's page
+ same for line numbers
Till, thanks for process clarification.
I'm new to the FLIP process, so your comment is really helpful.
I think the only unresolved thing is
Hi Sergey,
I think that after answering/resolving Jark's comments, you can start a
[VOTE] thread for this FLIP. The process is described here [1]. Once the
FLIP has been accepted, which it should, given the positive feedback, you
can start working on it by creating the corresponding JIRA tickets
Hi Sergey,
Thank you for your FLIP, the autocompletion looks stunning and really
useful!
FG
On Tue, Nov 2, 2021 at 4:25 AM Jark Wu wrote:
> Awesome demo, looking forward to these features!
>
> I only have a minor comment: could we provide a config to enable/disable
> the prompt values?
> We
Awesome demo, looking forward to these features!
I only have a minor comment: could we provide a config to enable/disable
the prompt values?
We can also discuss whether we can enable all the new features by default
to give them more exposure.
Best,
Jark
On Tue, 2 Nov 2021 at 10:48, JING ZHANG
Amazing improvements and impressive video.
Big +1.
Best,
JING ZHANG
Kurt Young 于2021年11月2日周二 上午9:37写道：
> Really cool improvements @Sergey. Can't wait to see it happen.
>
> Best,
> Kurt
>
>
> On Tue, Nov 2, 2021 at 1:56 AM Martijn Visser
> wrote:
>
> > Hi Sergey,
> >
> > I guess you've just
Really cool improvements @Sergey. Can't wait to see it happen.
Best,
Kurt
On Tue, Nov 2, 2021 at 1:56 AM Martijn Visser wrote:
> Hi Sergey,
>
> I guess you've just set a new standard ;-) I agree with Ingo, these
> improvements look really good!
>
> Best regards,
>
> Martijn
>
> On Mon, 1 Nov
Hi Sergey,
I guess you've just set a new standard ;-) I agree with Ingo, these
improvements look really good!
Best regards,
Martijn
On Mon, 1 Nov 2021 at 18:23, Ingo Bürk wrote:
> Hi Sergey,
>
> I think those improvements look absolutely amazing. Thanks for the little
> video!
>
>
> Best
>
Hi Sergey,
I think those improvements look absolutely amazing. Thanks for the little
video!
Best
Ingo
On Mon, Nov 1, 2021, 17:15 Sergey Nuyanzin wrote:
> Thanks for the feedback Till.
>
> Martijn, I have created a short demo showing some of the features mentioned
> in FLIP.
> It is available
Thanks for the feedback Till.
Martijn, I have created a short demo showing some of the features mentioned
in FLIP.
It is available at https://asciinema.org/a/446247?speed=3.0
Could you please tell if it is what you are expecting or not?
On Fri, Oct 29, 2021 at 4:59 PM Till Rohrmann wrote:
>
Thanks for creating this FLIP Sergey. I think what you propose sounds like
very good improvements for the SQL client. This should make the client a
lot more ergonomic :-)
Cheers,
Till
On Fri, Oct 29, 2021 at 11:26 AM Sergey Nuyanzin
wrote:
> Hi Martijn,
>
> Thank you for your suggestion with
Hi Martijn,
Thank you for your suggestion with POC.
Yes I will do that and come back to this thread probably after the weekend
On Thu, Oct 28, 2021 at 4:38 PM Martijn Visser
wrote:
> Hi Sergey,
>
> Thanks for taking the initiative to create a FLIP and propose improvements
> on the SQL client.
Hi Sergey,
Thanks for taking the initiative to create a FLIP and propose improvements
on the SQL client. All usability improvements on the SQL client are highly
appreciated, especially for new users of Flink. Multi-line support is
definitely one of those things I've run into myself.
I do think
Hi all,
I want to start a discussion about FLIP-189: SQL Client Usability
Improvements.
The main changes in this FLIP:
- Flink sql client parser improvements so
that sql client does not ask for ; inside a quoted string or a comment
- use prompt to show what sql client is waiting for
-
25 matches
Mail list logo
