Re: [DISCUSS] FLIP-223: Support HiveServer2 Endpoint

2022-06-06 Thread Shengkai Fang
> > Hi, everyone. > > Thanks for all the input. Hope my feedback can address most of the > questions. > > Since the discussion has lasted for a long time, I think we have reached a > consensus about the > design. If the discussion doesn't get more responses, I think we can start > the vote

Re: [DISCUSS] FLIP-223: Support HiveServer2 Endpoint

2022-06-06 Thread godfrey he
Hi, Shengkai. Thanks for the update, LGTM now. Best, Godfrey Shengkai Fang 于2022年6月6日周一 16:47写道: > > Hi. Godfrey. > > Nice to hear the comments from you. > > > Could you give a whole architecture about the Ecosystem of HiveServers > > and the SqlGateway, such as JDBC driver, Beeline, etc. > >

Re: [DISCUSS] FLIP-223: Support HiveServer2 Endpoint

2022-06-06 Thread Shengkai Fang
Hi. Godfrey. Nice to hear the comments from you. > Could you give a whole architecture about the Ecosystem of HiveServers > and the SqlGateway, such as JDBC driver, Beeline, etc. > Which is more clear for users. Yes. I have updated the FLIP and added the architecture of the Gateway with the

Re: [DISCUSS] FLIP-223: Support HiveServer2 Endpoint

2022-06-05 Thread godfrey he
Hi Shengkai, Thanks for driving this. I have a few comments: Could you give a whole architecture about the Ecosystem of HiveServers and the SqlGateway, such as JDBC driver, Beeline, etc. Which is more clear for users. > Considering the different users may have different requirements to connect

Re: [DISCUSS] FLIP-223: Support HiveServer2 Endpoint

2022-06-01 Thread Shengkai Fang
Hi, Jingsong. Thanks for your feedback. > I've read the FLIP and it's not quite clear what the specific unsupported items are Yes. I have added a section named Difference with HiveServer2 and list the difference between the SQL Gateway with HiveServer2 endpoint and HiveServer2. > Support

Re: [DISCUSS] FLIP-223: Support HiveServer2 Endpoint

2022-06-01 Thread Jingsong Li
Hi Shengkai, Thanks for driving. I have a few comments: ## Unsupported features I've read the FLIP and it's not quite clear what the specific unsupported items are? - For example, security related, is it not supported. - For example, is there a loss of precision for types - For example, the

Re: [DISCUSS] FLIP-223: Support HiveServer2 Endpoint

2022-05-23 Thread Shengkai Fang
Hi, all. Considering we start to vote for FLIP-91 for a while, I think we can restart the discussion about the FLIP-223. I am glad that you can give some feedback about FLIP-223. Best, Shengkai Martijn Visser 于2022年5月6日周五 19:10写道: > Hi Shengkai, > > Thanks for clarifying. > > Best regards,

Re: [DISCUSS] FLIP-223: Support HiveServer2 Endpoint

2022-05-06 Thread Martijn Visser
Hi Shengkai, Thanks for clarifying. Best regards, Martijn On Fri, 6 May 2022 at 08:40, Shengkai Fang wrote: > Hi Martijn. > > > So this implementation would not rely in any way on Hive, only on Thrift? > > Yes. The dependency is light. We also can just copy the iface file from > the Hive

Re: [DISCUSS] FLIP-223: Support HiveServer2 Endpoint

2022-05-06 Thread Shengkai Fang
Hi Martijn. > So this implementation would not rely in any way on Hive, only on Thrift? Yes. The dependency is light. We also can just copy the iface file from the Hive repo and maintain by ourselves. Best, Shengkai Martijn Visser 于2022年5月4日周三 21:44写道: > Hi Shengkai, > > > Actually we will

Re: [DISCUSS] FLIP-223: Support HiveServer2 Endpoint

2022-05-04 Thread Martijn Visser
Hi Shengkai, > Actually we will only rely on the API in the Hive, which only contains the thrift file and the generated code So this implementation would not rely in any way on Hive, only on Thrift? Best regards, Martijn Visser https://twitter.com/MartijnVisser82

Re: [DISCUSS] FLIP-223: Support HiveServer2 Endpoint

2022-04-28 Thread Shengkai Fang
Hi, Jark and Martijn Thanks for your feedback. > Kyuubi provides three ways to configure Hive metastore [1]. Could we provide similar abilities? Yes. I have updated the FLIP about this and it takes some time to figure out how the jdbc driver works. I added the section about how to use the hive

Re: [DISCUSS] FLIP-223: Support HiveServer2 Endpoint

2022-04-26 Thread Martijn Visser
Hi all, I'm not too familiar with Hive and HiveServer2, but I do have a couple of questions/concerns: 1. What is the relationship between this FLIP and FLIP-91? My assumption would be that this FLIP (and therefore the HiveServer2) implementation would need to be integrated in the REST Gateway,

Re: [DISCUSS] FLIP-223: Support HiveServer2 Endpoint

2022-04-25 Thread Jark Wu
Thank Shengkai for driving this effort, I think this is an essential addition to Flink Batch. I have some small suggestions: 1) Kyuubi provides three ways to configure Hive metastore [1]. Could we provide similar abilities? Especially with the JDBC Connection URL, users can visit different Hive

Re: [DISCUSS] FLIP-223: Support HiveServer2 Endpoint

2022-04-24 Thread Shengkai Fang
Hi, Jiang. Thanks for your feedback! > Integrating the Hive ecosystem should not require changing the service interface I move the API change to the FLIP-91. But I think it's possible we add more interfaces to intergrate the new endpoints in the future because every endpoints's functionality is

Re: [DISCUSS] FLIP-223: Support HiveServer2 Endpoint

2022-04-22 Thread Nicholas Jiang
Hi Shengkai. Thanks for driving the proposal of HiveServer2 Endpoint support. For the "GatewayService API Change", I don't think the motivation for supporting HiveServer2 endpoint need to change the GatewayService API, in other words, integrating the Hive ecosystem should not require changing

Re: [DISCUSS] FLIP-223: Support HiveServer2 Endpoint

2022-04-21 Thread Shengkai Fang
Hi Paul. Thanks for your feedback.! > SQL client would remain supporting REST endpoint only? Yes. The SQL Client will only support REST endpoint. The FLIP's goal is to migrate the FLINK Gateway into the Hive ecosystem. But I think we can leave this as the future work. Best, Shengkai Paul Lam

Re: [DISCUSS] FLIP-223: Support HiveServer2 Endpoint

2022-04-21 Thread Paul Lam
Hi Shengkai, Thanks for starting the discussion. As the FLIP doesn’t mention SQL client, I’m assuming that SQL client would remain supporting REST endpoint only? Best, Paul Lam > 2022年4月21日 14:45,Shengkai Fang 写道: > > Hi, Flink developers. > > I want to start a discussion about the

[DISCUSS] FLIP-223: Support HiveServer2 Endpoint

2022-04-21 Thread Shengkai Fang
Hi, Flink developers. I want to start a discussion about the FLIP-223: Support HiveServer2 Endpoint[1]. The Endpoint will implement the thrift interface exposed by the HiveServer2, and users' BI, CLI and other tools based on the HiveServer2 can also be seamlessly migrated to the Flink SQL