[DISCUSS] FLIP-237: Thrift Format Support in Flink

2022-06-06 Thread Chen Qin
Hi there, I want to kick off the first round of FLIP-237 : Thrift Format Support discussion. Notice for the area marked as WIP, we are looking for more feedback from folks, those areas would either stay in the sco

Re: [DISCUSS] FLIP-237: Thrift Format Support in Flink

2022-06-06 Thread Jing Ge
Hi Chen, Thanks for driving this! Afaik, the community has the consensus to *Start a [DISCUSS] thread on the Apache mailing list*[1]. I just walked through some existing FLIPs and didn't find any that have been using google doc as the discussion thread. Would you like to follow the current process

Re: [DISCUSS] FLIP-237: Thrift Format Support in Flink

2022-06-07 Thread Jark Wu
Yes. The community recommends keeping content on the wiki page and discuss in the mailing list. Discussions on the google doc are not so visible to the community, and "If it didn’t happen on a mailing list, it didn’t happen." Best, Jark On Tue, 7 Jun 2022 at 14:15, Jing Ge wrote: > Hi Chen, > >

Re: [DISCUSS] FLIP-237: Thrift Format Support in Flink

2022-06-07 Thread Chen Qin
Thanks for the pointers, I moved the proposal to the wiki and updated the FLIP status page. https://cwiki.apache.org/confluence/display/FLINK/FLIP-237%3A+Thrift+Format+Support Looking forward to getting community feedback. Chen On Tue, Jun 7, 2022 at 12:12 AM Jark Wu wrote: > Yes. The comm

Re: [DISCUSS] FLIP-237: Thrift Format Support in Flink

2022-06-09 Thread Martijn Visser
Hi Chen, Thanks for creating the FLIP and opening the discussion. I have a couple of questions/remarks: * What I'm missing overall, is the section on 'Public Interfaces'. The FLIP has a large Proposed Changes section, but it reads more like your journey when you implemented Thrift in your fork. F

Re: [DISCUSS] FLIP-237: Thrift Format Support in Flink

2022-06-10 Thread Chen Qin
Hi Martjin, Thank you for good feedback! I might not be able to address them all especially around catalog table schema inference design. >* What I'm missing overall, is the section on 'Public Interfaces'. The FLIP has a large Proposed Changes section I updated https://cwiki.apache.org/confluence