Re: [DISCUSS] FLIP-378: Support Avro timestamp with local timezone

Thanks for all of the feedback so far. I will update the FLIP accordingly, and start a vote thread later today. On Tue, Nov 14, 2023 at 6:47 AM Jing Ge wrote: > +1 Thanks for the proposal! > > Best regards, > Jing > > On Tue, Nov 14, 2023 at 8:46 AM Mingliang Liu wrote: > >> +1 on this effort.

Re: [DISCUSS] FLIP-378: Support Avro timestamp with local timezone

+1 Thanks for the proposal! Best regards, Jing On Tue, Nov 14, 2023 at 8:46 AM Mingliang Liu wrote: > +1 on this effort. > > I opened a JIRA sometime ago on this topic [1] and Jagadesh submitted a PR > [2] for review. In the comments, James proposed a different approach from > the PR. I don't t

Re: [DISCUSS] FLIP-378: Support Avro timestamp with local timezone

+1 on this effort. I opened a JIRA sometime ago on this topic [1] and Jagadesh submitted a PR [2] for review. In the comments, James proposed a different approach from the PR. I don't think this topic was well-discussed there by the community and no consensus on how to move forward. Reading the do

Re: [DISCUSS] FLIP-378: Support Avro timestamp with local timezone

+1 I think we can mark the temporary config option as deprecated when we introduce it. So we can remove it after 2 minor releases (1.19, 1.20), i.e., drop in 2.0 release. A minor comment about the config option, I would suggest to use "avro.timestamp-mapping.legacy" instead of "avro.timestamp_map

Re: [DISCUSS] FLIP-378: Support Avro timestamp with local timezone

+1 Gyula On Thu, Nov 2, 2023 at 6:18 AM Martijn Visser wrote: > +1 > > On Thu, Nov 2, 2023 at 12:44 PM Leonard Xu wrote: > > > > > > > Thanks @Leonard Xu . Two minor versions are > definitely needed for flip the configs. > > > > Sorry, Peter. I thought the next minor

Re: [DISCUSS] FLIP-378: Support Avro timestamp with local timezone

+1 On Thu, Nov 2, 2023 at 12:44 PM Leonard Xu wrote: > > > > Thanks @Leonard Xu . Two minor versions are > > definitely needed for flip the configs. > > Sorry, Peter. I thought the next minor versions are 1.19、2.0， but actually it > should be 1.19、1.20、2.0 from current

Re: [DISCUSS] FLIP-378: Support Avro timestamp with local timezone

> Thanks @Leonard Xu . Two minor versions are > definitely needed for flip the configs. Sorry, Peter. I thought the next minor versions are 1.19、2.0， but actually it should be 1.19、1.20、2.0 from current community version plan IIUC, so remove the config in 2.0 should b

Re: [DISCUSS] FLIP-378: Support Avro timestamp with local timezone

Thanks @Leonard Xu . Two minor versions are definitely needed for flip the configs. On Mon, Oct 30, 2023 at 8:55 PM Leonard Xu wrote: > Thanks @Peter for driving this FLIP > > +1 from my side, the timestamp semantics mapping looks good to me. > > > In the end, the legacy behavior will be droppe

Re: [DISCUSS] FLIP-378: Support Avro timestamp with local timezone

Thanks @Peter for driving this FLIP +1 from my side, the timestamp semantics mapping looks good to me. > In the end, the legacy behavior will be dropped in > Flink 2.0 > I don’t think we can drop this option which introduced in 1.19 and drop in > 2.0, the API removal requires at least two minor

[DISCUSS] FLIP-378: Support Avro timestamp with local timezone

Hi Devs, Currently, Flink Avro Format doesn't support the Avro time (milli/micros) with local timezone type. Although the Avro timestamp (millis/micros) type is supported and is mapped to flink timestamp without timezone, it is not compliant to semantics defined in Consistent timestamp types in Ha