Re: [DISCUSS] FLIP-90: Support SQL 2016-2017 JSON functions in Flink SQL

hi，Dann，Thanks you very much. Best, Forward Danny Chan 于2020年1月8日周三 下午2:25写道： > Thanks Forward ~ > > I would help to view code from the Calcite side. > > Best, > Danny Chan > 在 2020年1月7日 +0800 PM2:01，Forward Xu ，写道： > > Thanks Jark for checking the doc. hi,Timo, please help to check to see if >

Re: [DISCUSS] FLIP-90: Support SQL 2016-2017 JSON functions in Flink SQL

Thanks Forward ~ I would help to view code from the Calcite side. Best, Danny Chan 在 2020年1月7日 +0800 PM2:01，Forward Xu ，写道： > Thanks Jark for checking the doc. hi,Timo, please help to check to see if > there is anything else to add. > > Best, > Forward > > Jark Wu 于2020年1月6日周一 下午2:58写道： > > > Th

Re: [DISCUSS] FLIP-90: Support SQL 2016-2017 JSON functions in Flink SQL

Thanks Jark for checking the doc. hi,Timo, please help to check to see if there is anything else to add. Best, Forward Jark Wu 于2020年1月6日周一 下午2:58写道： > Thanks Forward for the updating. It is much more clearer now about the > returning type, especially JSON_VALUE. > The design doc looks good to

Re: [DISCUSS] FLIP-90: Support SQL 2016-2017 JSON functions in Flink SQL

Thanks Forward for the updating. It is much more clearer now about the returning type, especially JSON_VALUE. The design doc looks good to me now. Best, Jark On Fri, 3 Jan 2020 at 21:42, Forward Xu wrote: > Hi Timo, Jack, > Well, I added additional column to describe the return type of each > f

Re: [DISCUSS] FLIP-90: Support SQL 2016-2017 JSON functions in Flink SQL

Hi Timo, Jack, Well, I added additional column to describe the return type of each function and updated the google doc. Best, Forward Jark Wu 于2020年1月3日周五 下午5:48写道： > Hi Timo, > > That's a good point. > We didn't introduce any new types. We will use the function definition > defined by Calcite[

Re: [DISCUSS] FLIP-90: Support SQL 2016-2017 JSON functions in Flink SQL

Hi Timo, That's a good point. We didn't introduce any new types. We will use the function definition defined by Calcite[1]. So all the functions return STRING/BOOLEAN. Hi Forward, I think we may need an additional column to describe the return type of each function. Best, Jark [1]: https://gith

Re: [DISCUSS] FLIP-90: Support SQL 2016-2017 JSON functions in Flink SQL

Hi, sorry for jumping into the discussion so late. I had a quick look at the FLIP. It looks very nice and detailed. I have one question that I could not find in the FLIP itself. Maybe it is hidden in the long discussion thread. What are the return types of all functions? Do we introduce new

Re: [DISCUSS] FLIP-90: Support SQL 2016-2017 JSON functions in Flink SQL

Thanks a lot for the update. +1 to start a vote. On Tue, Dec 31, 2019 at 2:38 PM Forward Xu wrote: > Hi Jark, Hequn, > > I have updated the documentation. > > Best, > > Forward > > Forward Xu 于2019年12月29日周日 下午4:01写道： > > > Hi Jark, Hequn, > > > > Thank you very much, Introducing new `TableSymbo

Re: [DISCUSS] FLIP-90: Support SQL 2016-2017 JSON functions in Flink SQL

Hi Jark, Hequn, I have updated the documentation. Best, Forward Forward Xu 于2019年12月29日周日 下午4:01写道： > Hi Jark, Hequn, > > Thank you very much, Introducing new `TableSymbol`s sounds like a good > idea. +1 for the proposal. > > I think this idea is good, I will add this in the documentation. >

Re: [DISCUSS] FLIP-90: Support SQL 2016-2017 JSON functions in Flink SQL

Hi Jark, Hequn, Thank you very much, Introducing new `TableSymbol`s sounds like a good idea. +1 for the proposal. I think this idea is good, I will add this in the documentation. Best, Forward Hequn Cheng 于2019年12月29日周日 下午3:41写道： > Hi Jark, > > Introducing new `TableSymbol`s sounds like a go

Re: [DISCUSS] FLIP-90: Support SQL 2016-2017 JSON functions in Flink SQL

Hi Jark, Introducing new `TableSymbol`s sounds like a good idea. +1 for the proposal. @ForwardXu what do you think? Would be great if the document can be updated accordingly. Best, Hequn On Fri, Dec 27, 2019 at 4:14 PM Jark Wu wrote: > Thanks for looking into the design Hequn. I agree it woul

Re: [DISCUSS] FLIP-90: Support SQL 2016-2017 JSON functions in Flink SQL

Thanks for looking into the design Hequn. I agree it would be great to have a full story design. For the ON ERROR and ON EMPTY clause in Table API, some initial thoughts in my mind is that we can introduce some new `TableSymbol`s as the second parameter of json function, e.g. `JsonErrorStrategy`.

Re: [DISCUSS] FLIP-90: Support SQL 2016-2017 JSON functions in Flink SQL

Hi Jark & ForwardXu, The design doc looks very nice! Only some minor feedback from my side. As calcite has already implemented the JSON functions, I would suppose the semantics and implementation are right for SQL. For TableAPI, I think the most important is to keep align with the SQL(which has

Re: [DISCUSS] FLIP-90: Support SQL 2016-2017 JSON functions in Flink SQL

Hi Forward, Thanks for creating the FLIP. +1 to start a vote. @Hequn Cheng @Kurt Young , could you help to review the design doc too? Best, Jark On Mon, 23 Dec 2019 at 10:10, tison wrote: > modified: > > https://lists.apache.org/x/thread.html/b3c0265cc2b660fe11ce550b84a831a7606de12908ff7f

Re: [DISCUSS] FLIP-90: Support SQL 2016-2017 JSON functions in Flink SQL

modified: https://lists.apache.org/x/thread.html/b3c0265cc2b660fe11ce550b84a831a7606de12908ff7ff0959a4794@%3Cdev.flink.apache.org%3E

Re: [DISCUSS] FLIP-90: Support SQL 2016-2017 JSON functions in Flink SQL

FYI the previous discussion is here[1]. Best, tison. [1] https://lists.apache.org/x/thread.html/e259aa70432e4003e1598e8f8db844813a869a0dd96accfc1b73deb6@%3Cdev.flink.apache

[DISCUSS] FLIP-90: Support SQL 2016-2017 JSON functions in Flink SQL

Hi everybody, I'd like to kick off a discussion on FLIP-90: Support SQL 2016-2017 JSON functions in Flink SQL. Implement Support SQL 2016-2017 JSON functions in Flink SQL[1]. Would love to hear your thoughts. [1] https://cwiki.apache.org/confluence/display/FLINK/FLIP-90%3A+Support+SQL+2016

[DISCUSS] FLIP-90: Support SQL 2016-2017 JSON functions in Flink SQL

Hi everybody, I'd like to kick off a discussion on FLIP-90: Support SQL 2016-2017 JSON functions in Flink SQL. Implement Support SQL 2016-2017 JSON functions in Flink SQL[1]. Would love to hear your thoughts. [1] https://cwiki.apache.org/confluence/display/FLINK/FLIP-90%3A+Support+SQL+2016