[DISCUSS] Flink should rely on flink-shaded SNAPSHOT artifacts

2021-04-12 Thread Chesnay Schepler
Hello all, I would like to propose a change in how the Flink master interacts with Flink-shaded. TL;DR: Release snapshot artifacts for flink-shaded, and have the Flink master rely on specific snapshot versions for earlier dependency bumps. Aa a project we have come to the general conclusio

Re: [DISCUSS] Flink should rely on flink-shaded SNAPSHOT artifacts

2021-04-12 Thread Konstantin Knauf
Sounds good. +1 On Mon, Apr 12, 2021 at 1:23 PM Chesnay Schepler wrote: > Hello all, > > I would like to propose a change in how the Flink master interacts with > Flink-shaded. > > TL;DR: Release snapshot artifacts for flink-shaded, and have the Flink > master rely on specific snapshot versions

Re: [DISCUSS] Flink should rely on flink-shaded SNAPSHOT artifacts

2021-04-12 Thread Robert Metzger
Thanks a lot for your proposal, I'm generally open to the idea I have a few questions: a) Does this mean that we are changing flink-shaded to deploy snapshot artifacts to Apache's snapshot maven repository, and change Flink's parent pom to point to this snapshot repo? b) How do you plan to generat

Re: [DISCUSS] Flink should rely on flink-shaded SNAPSHOT artifacts

2021-04-12 Thread Chesnay Schepler
a) yes. b) maven by default adds a timestamp to snapshot artifacts that we can use. The apache repository retains the last 2 snapshots, so we do need to keep things in sync a fair bit, but there are rarely commits made in flink-shaded that I don't think this will be a problem. c) a-SNAPSHOT-un

Re: [DISCUSS] Flink should rely on flink-shaded SNAPSHOT artifacts

2021-04-13 Thread Robert Metzger
Thanks a lot for your responses. I didn't know that you can explicitly refer to the timestamped snapshots of the artifacts. The limitation to the last 2 snapshots means that a push to flink-shaded can break our main CI? This sounds very fragile to me, given that the setup itself is probably a bit

Re: [DISCUSS] Flink should rely on flink-shaded SNAPSHOT artifacts

2021-04-13 Thread Till Rohrmann
Thanks for creating this proposal Chesnay. I do understand the problem you want to fix. What I am wondering is why we don't release flink-shaded more often. Does the release process cause too much overhead? If this is the case, then we could look into what is causing the overhead and whether we ca

Re: [DISCUSS] Flink should rely on flink-shaded SNAPSHOT artifacts

2021-04-13 Thread Chesnay Schepler
@Robert We can workaround the snapshot limit issue fairly easily; this limit is imposed per version, so if we modify the version to include the commit hash this limit does not apply. This should also make it easier to work with from the Flink side because a commit hash is easier to copy&paste t