+1 on Timo's proposal. Bash script can be difficult to extend, debug
and maintain as the end-to-end tests become larger and more complex. I
would favor Java comparing to Bash script.
Another option would be to use scala, it's JVM based and work with Java,
but at the same time much more concise.
O
+1 using Java for implementing e2e testing. I have already seem many bash
tests reuse logics written in Java from example modules. However creating
and maintaining the bash script to extend upon these example cases for
testing is kind of painful.
Maybe we can start extending the logics for e2e tes
+1 for Timo's proposal. Bash scripts can be difficult to maintain and more
complex logic can be hard to express with bash. Thus, implementing logic in
Java or Python is a good idea and will help to reuse code. I would also
favour Java at the moment, because the rest of Flink is also written in
Java
At this moment, +1 from my side for maintaining bash scripts.
Mingleizhang
> 在 2018年3月27日，下午9:42，Piotr Nowojski 写道：
>
> +1
>
> I would personally go with Python, but I see a reason to Kostas’s arguments
> in favour of Java. Regardless, based on my experience with maintaining bash
> scripts,
Hi Timo,
Thank you for providing so many information.
- I have some my thoughts on end to end tests. I think such as Kafka, and
elastic search . We can not run end to end tests in the IDE for debugging and
set breakpoints. For those, we still need implement its logic in bash scripts
like dow
+1
I would personally go with Python, but I see a reason to Kostas’s arguments in
favour of Java. Regardless, based on my experience with maintaining bash
scripts, both of those options (Java/python) are much better in the long run.
Piotrek
> On 27 Mar 2018, at 15:38, Kostas Kloudas wrote:
Hi Timo,
Thanks for opening this.
I agree that bash is not the best tool for all the reasons that you mention
plus:
1) it is difficult to write re-usable code
2) there are a lot of ways to express the same thing and difficult to build
“best practices” (as it should be
in a community proj
Hi everyone,
after reviewing a bunch of end-to-end tests, I'm wondering if we should
really continue implementing everything in bash scripts. Wouldn't it be
nicer to implement them in Java code that just calls the interfaces of
Flink (e.g. "./bin/flink run" or REST API)?
Here are some though
