Re: [DISCUSS] Java Record support

2023-10-05 Thread Gyula Fóra
Hi, I have opened a draft PR [1] that shows the minimal required changes and a suggested unit test setup for Java version specific tests. There is still some work to be done (run all benchmarks, add more tests for compatibility/migration) If you have time please review / comment on the approach he

Re: [DISCUSS] Java Record support

2023-10-04 Thread Peter Huang
+1 for the convenience of users. On Wed, Oct 4, 2023 at 8:05 AM Matthias Pohl wrote: > +1 Sounds like a good idea. > > On Wed, Oct 4, 2023 at 5:04 PM Gyula Fóra wrote: > > > I will share my initial implementation soon, it seems to be pretty > > straightforward. > > > > Biggest challenge so far

Re: [DISCUSS] Java Record support

2023-10-04 Thread Matthias Pohl
+1 Sounds like a good idea. On Wed, Oct 4, 2023 at 5:04 PM Gyula Fóra wrote: > I will share my initial implementation soon, it seems to be pretty > straightforward. > > Biggest challenge so far is setting tests so we can still compile against > older versions but have tests for records . But I h

Re: [DISCUSS] Java Record support

2023-10-04 Thread Gyula Fóra
I will share my initial implementation soon, it seems to be pretty straightforward. Biggest challenge so far is setting tests so we can still compile against older versions but have tests for records . But I have working proposal for that as well. Gyula On Wed, 4 Oct 2023 at 16:45, Chesnay Schep

Re: [DISCUSS] Java Record support

2023-10-04 Thread Chesnay Schepler
Kryo isn't required for this; newer versions do support records but we want something like a PojoSerializer for records to be performant. The core challenges are a) detecting records during type extraction b) ensuring parameters are passed to the constructor in the right order. From what I reme

Re: [DISCUSS] Java Record support

2023-10-04 Thread Őrhidi Mátyás
+1 This would be great On Wed, Oct 4, 2023 at 7:04 AM Gyula Fóra wrote: > Hi All! > > Flink 1.18 contains experimental Java 17 support but it misses out on Java > records which can be one of the nice benefits of actually using newer java > versions. > > There is already a Jira to track this feat

[DISCUSS] Java Record support

2023-10-04 Thread Gyula Fóra
Hi All! Flink 1.18 contains experimental Java 17 support but it misses out on Java records which can be one of the nice benefits of actually using newer java versions. There is already a Jira to track this feature [1] but I am not aware of any previous efforts so far. Since records have pretty s