Dear All
Currently, we found the implementations of AppendingState#add are not the
same, taking some as example:
- HeapReducingState will clear state if add null element
- RocksDBReducingState will add null element if serializer can serialize
null
- Both HeapListState and RocksDBList
Hi,
As I said in the discussion on the Jira issue, I’m in favour of this change!
This is the Jira Issue, for reference:
https://issues.apache.org/jira/browse/FLINK-15424
Best,
Aljoscha
> On 8. Jan 2020, at 15:16, Congxian Qiu wrote:
>
> Dear All
>
>
> Currently, we found the implementation
+1 for unifying the behavior to refusing adding null element. Nice catch
and thanks for bringing up the discussion!
Best Regards,
Yu
On Wed, 8 Jan 2020 at 22:50, Aljoscha Krettek wrote:
> Hi,
>
> As I said in the discussion on the Jira issue, I’m in favour of this
> change!
>
> This is the Jir
-docs-stable/dev/stream/operators/windows.html#reducefunction
Best
Yun Tang
From: Yu Li
Sent: Thursday, January 9, 2020 14:09
To: dev
Subject: Re: [DISCUSS] Make AppendingState#add refuse to add null element
+1 for unifying the behavior to refusing adding null element
nction
Best
Yun Tang
From: Yu Li
Sent: Thursday, January 9, 2020 14:09
To: dev
Subject: Re: [DISCUSS] Make AppendingState#add refuse to add null element
+1 for unifying the behavior to refusing adding null element. Nice catch
and thanks for bringing up the discussion!
Best Regards,
Yu
On Wed
Subject: Re: [DISCUSS] Make AppendingState#add refuse to add null element
This is mostly a remnant from the previous state API, see [1] for
reference. The behaviour was basically copied to the new state
implementations, which was a mistake, in hindsight. Also see [2] where I
added AppendingState, here I
