Re: [DISCUSS] Release flink-shaded 19.0

2024-06-27 Thread Dawid Wysakowicz
I’ve seen fixes for the blocker has been merged. Thank you! I’ll proceed with my original plan and prepare a release tomorrow if there are no further concerns. On Thu, 27 Jun 2024 at 15:06, Zakelly Lan wrote: > Hi Sergey, > > FYI we also meet the regression of stringRead or stringWrite when

Re: [DISCUSS] Release flink-shaded 19.0

2024-06-27 Thread Zakelly Lan
Hi Sergey, FYI we also meet the regression of stringRead or stringWrite when upgrading the JMH[1]. I guess it is caused by JIT. I'd suggest accepting it if JIT is so sensitive to 'unrelated' change in codebase, since this probably won't be a problem in production environment. I recommend we do

Re: [DISCUSS] Release flink-shaded 19.0

2024-06-27 Thread Sergey Nuyanzin
Thanks for starting this discussion Dawid In general I'm +1 for the release IIRC there is one blocker for flink-shaded[1] which was the reason of downgrading it from 18 to 17[2] I would suggest to resolve it first [1] https://issues.apache.org/jira/browse/FLINK-34234 [2]

[DISCUSS] Release flink-shaded 19.0

2024-06-27 Thread Dawid Wysakowicz
Hi, I'd like to propose releasing flink-shaded 19.0. I suggest it has a very limited scope and include just shading of com.jayway.jsonpath:json-path[1] This would let us fix FLINK-35696[2] If there are no objections, I'd prepare a release. [1]