[DISCUSS] Stop adding new bash-based e2e tests to Flink

2020-11-17 Thread Robert Metzger
Hi all, Since we are currently testing the 1.12 release, and potentially adding more automated e2e tests, I would like to bring up our end to end tests for discussion. Some time ago, we introduced a Java-based testing framework, with the idea of replacing the current bash-based end to end tests.

Re: [DISCUSS] Stop adding new bash-based e2e tests to Flink

2020-11-17 Thread Yang Wang
Thanks for starting this discussion. In general, I agree with you that a java-based testing framework is better than the bash-based. It will help a lot for the commons and utilities. Since I am trying to add a new bash-based Kubernetes HA test, I have some quick questions. * I am not sure where t

Re: [DISCUSS] Stop adding new bash-based e2e tests to Flink

2020-11-18 Thread Till Rohrmann
Big +1 for your proposal Robert. I think the decision to use bash for our e2e tests already fired back on us several times. Hence, I believe it is time for a serious effort to get away from it. The e2e test framework can be found here [1]. When using the e2e test framework, it should be possible

Re: [DISCUSS] Stop adding new bash-based e2e tests to Flink

2020-11-18 Thread Jark Wu
+1 to use the Java-based testing framework and +1 for using docker images in the future. IIUC, the Java-based testing framework refers to the `flink-end-to-end-tests-common` module. The java-based framework helped us a lot when debugging the unstable e2e tests. Best, Jark On Wed, 18 Nov 2020 at 1

Re: [DISCUSS] Stop adding new bash-based e2e tests to Flink

2020-11-18 Thread Arvid Heise
Also +1 for java-based testing framework; bash just disrupts development flow too much. +1 to use docker as much as possible, ideally with testcontainers [1]. [1] https://www.testcontainers.org/ On Wed, Nov 18, 2020 at 10:23 AM Jark Wu wrote: > +1 to use the Java-based testing framework and +1

Re: [DISCUSS] Stop adding new bash-based e2e tests to Flink

2020-11-18 Thread Yang Wang
Thanks till and Jark for sharing the information. I am also +1 for this proposal and glad to wire the new introduced K8s HA e2e tests to java based framework. Best, Yang Jark Wu 于2020年11月18日周三 下午5:23写道: > +1 to use the Java-based testing framework and +1 for using docker images > in the future

Re: [DISCUSS] Stop adding new bash-based e2e tests to Flink

2020-11-18 Thread Aljoscha Krettek
+1 And I want to second Arvid's mention of testcontainers [1]. [1] https://www.testcontainers.org/ On 18.11.20 10:43, Yang Wang wrote: Thanks till and Jark for sharing the information. I am also +1 for this proposal and glad to wire the new introduced K8s HA e2e tests to java based framework.

Re: [DISCUSS] Stop adding new bash-based e2e tests to Flink

2020-11-18 Thread Leonard Xu
+1 to stop using bash scripts, and I also have experienced the bash scripts that is really hard to maintain and debug, thanks @Robert for the great work again. I think testcontainers is a nice candidate. Best, Leonard > 在 2020年11月18日,19:46,Aljoscha Krettek 写道: > > +1 > > And I want to seco

Re: [DISCUSS] Stop adding new bash-based e2e tests to Flink

2020-11-18 Thread Rui Li
Big +1 to java-based e2e tests. It'll be much easier to write/debug these tests. On Wed, Nov 18, 2020 at 9:44 PM Leonard Xu wrote: > +1 to stop using bash scripts, > and I also have experienced the bash scripts that is really hard to > maintain and debug, thanks @Robert for the great work again.

Re: [DISCUSS] Stop adding new bash-based e2e tests to Flink

2020-11-18 Thread Xingbo Huang
Big +1 for java-based e2e tests. Currently PyFlink related tests each take ~15minutes in bash e2e tests because we are using a secured YARN cluster which is the only convenient way of starting a YARN cluster in the bash e2e tests. I think if we migrate these tests to the java-based testing framewor

Re: [DISCUSS] Stop adding new bash-based e2e tests to Flink

2020-11-18 Thread Yun Tang
downloading. Best Yun Tang From: Xingbo Huang Sent: Thursday, November 19, 2020 12:09 To: dev Subject: Re: [DISCUSS] Stop adding new bash-based e2e tests to Flink Big +1 for java-based e2e tests. Currently PyFlink related tests each take ~15minutes in bash e2e

Re: [DISCUSS] Stop adding new bash-based e2e tests to Flink

2020-11-23 Thread Kevin Kwon
Hi :) For me, it's a bit unclear what it means by not using Docker in e2e tests in K8S context, since K8S require Docker by default Also, for for K8S test orchestration, wouldn't vanilla Python suffice? It has all the K8S, Docker client libraries supported natively by them Might just need to wri

Re: [DISCUSS] Stop adding new bash-based e2e tests to Flink

2020-11-27 Thread Matthias Pohl
ng. > > Best > Yun Tang > > From: Xingbo Huang > Sent: Thursday, November 19, 2020 12:09 > To: dev > Subject: Re: [DISCUSS] Stop adding new bash-based e2e tests to Flink > > Big +1 for java-based e2e tests. Currently PyFlink related test

Re: [DISCUSS] Stop adding new bash-based e2e tests to Flink

2020-11-27 Thread Jark Wu
Yun Tang > > ________ > > From: Xingbo Huang > > Sent: Thursday, November 19, 2020 12:09 > > To: dev > > Subject: Re: [DISCUSS] Stop adding new bash-based e2e tests to Flink > > > > Big +1 for java-based e2e tests. Currently P

Re: [DISCUSS] Stop adding new bash-based e2e tests to Flink

2020-11-27 Thread Xingbo Huang
docker image improvement, I think we should be more cautious as >>> developers at China might suffer with the network issue, or at least we >>> should ensure or find some guides to speed up the image downloading. >>> >>> Best >>> Yun Tang >>> ___