[DISCUSS] Temporarily remove support for job rescaling via CLI action "modify"

2019-04-23 Thread Gary Yao
Hi all, As the subject states, I am proposing to temporarily remove support for changing the parallelism of a job via the following syntax [1]: ./bin/flink modify [job-id] -p [new-parallelism] This is an experimental feature that we introduced with the first rollout of FLIP-6 (Flink 1.5). Ho

Re: [DISCUSS] Temporarily remove support for job rescaling via CLI action "modify"

2019-04-23 Thread Stephan Ewen
Sounds reasonable to me. If it is a broken feature, then there is not much value in it. On Tue, Apr 23, 2019 at 7:50 PM Gary Yao wrote: > Hi all, > > As the subject states, I am proposing to temporarily remove support for > changing the parallelism of a job via the following syntax [1]: > >

Re: [DISCUSS] Temporarily remove support for job rescaling via CLI action "modify"

2019-04-24 Thread Paul Lam
Hi Gary, + 1 to remove it for now. Actually some users are not aware of that it’s still experimental, and ask quite a lot about the problem it causes. Best, Paul Lam > 在 2019年4月24日,14:49,Stephan Ewen 写道: > > Sounds reasonable to me. If it is a broken feature, then there is not much > value i

Re: [DISCUSS] Temporarily remove support for job rescaling via CLI action "modify"

2019-04-24 Thread Till Rohrmann
+1 for temporarily removing support for the modify command. Eventually, we have to add it again in order to support auto scaling. The next time we add it, we should address the known limitations. Cheers, Till On Wed, Apr 24, 2019 at 9:06 AM Paul Lam wrote: > Hi Gary, > > + 1 to remove it for n

Re: [DISCUSS] Temporarily remove support for job rescaling via CLI action "modify"

2019-04-24 Thread Shuai Xu
Will we only remove command support in client side or the code in job master will also be removed? Till Rohrmann 于2019年4月24日周三 下午4:12写道: > +1 for temporarily removing support for the modify command. > > Eventually, we have to add it again in order to support auto scaling. The > next time we add

Re: [DISCUSS] Temporarily remove support for job rescaling via CLI action "modify"

2019-04-24 Thread Gary Yao
The idea is to also remove the rescaling code in the JobMaster. This will make it easier to remove the ExecutionGraph reference from the JobMaster which is needed for the scheduling rework [1]. [1] https://issues.apache.org/jira/browse/FLINK-12231 On Wed, Apr 24, 2019 at 12:14 PM Shuai Xu wrote:

Re: [DISCUSS] Temporarily remove support for job rescaling via CLI action "modify"

2019-04-29 Thread Gary Yao
Since there were no objections so far, I will proceed with removing the code [1]. [1] https://issues.apache.org/jira/browse/FLINK-12312 On Wed, Apr 24, 2019 at 1:38 PM Gary Yao wrote: > The idea is to also remove the rescaling code in the JobMaster. This will > make > it easier to remove the Ex