; > > Jinzhong Li
> > > >
> > > > On Mon, Feb 26, 2024 at 11:29 AM Yanfei Lei
> > wrote:
> > > >
> > > > > @Yun Tang
> > > > > Thanks for the information, +1 for marking
> > > > > `Configura
t; > >
> > > > Yun Tang 于2024年2月23日周五 19:54写道：
> > > > >
> > > > > Hi Jinzhong,
> > > > >
> > > > > Thanks for driving this topic, and +1 for fixing the lack of
> > > annotation.
> > > > >
> > > > > @Yanfei the `Configura
gt; > > > @Yanfei the `ConfigurableRocksDBOptionsFactory` interface is
> introduced
> > > for user extension, you can refer to the doc[1], which shows an example
> > of
> > > how to use this interface.
> > > >
> > > >
> > > >
> > >
> > > Best
> > > Yun Tang
> > >
> > > From: Yanfei Lei
> > > Sent: Thursday, February 22, 2024 15:39
> > > To: dev@flink.apache.org
> > > Subject: Re: [DISCUSS]FLIP-420: Add API annotations
/docs/ops/state/large_state_tuning/#tuning-rocksdb-memory
> >
> >
> > Best
> > Yun Tang
> > ____
> > From: Yanfei Lei
> > Sent: Thursday, February 22, 2024 15:39
> > To: dev@flink.apache.org
> > Subject: Re: [DISCUSS]
rocksdb-memory
>
>
> Best
> Yun Tang
>
> From: Yanfei Lei
> Sent: Thursday, February 22, 2024 15:39
> To: dev@flink.apache.org
> Subject: Re: [DISCUSS]FLIP-420: Add API annotations for RocksDB StateBackend
> user-facing classes
&
://nightlies.apache.org/flink/flink-docs-master/docs/ops/state/large_state_tuning/#tuning-rocksdb-memory
Best
Yun Tang
From: Yanfei Lei
Sent: Thursday, February 22, 2024 15:39
To: dev@flink.apache.org
Subject: Re: [DISCUSS]FLIP-420: Add API annotations for RocksDB StateBackend
user
Hi Jinzhong,
Thanks for driving this!
1. I'm wondering if `ConfigurableRocksDBOptionsFactory` will be used
by users, currently it looks like only developers use it in rocksdb
state backend module. And Its only non-testing subclass
"DefaultConfigurableOptionsFactory" is marked @Deprecated.
2. Rega
Hi Zakelly,
Thanks for your comments!
1）I agree that almost no user would use "RocksDBStateUploader" and
"RocksDBStateDownloader" to do something. It's fine for me to keep them
unmarked.
2）Regarding "SingleStateIterator", I think it's acceptable to either leave
it unmarked or mark it as @Internal
Hi Jinzhong.
Thanks for driving this!
Some suggestions:
1. As RocksDBStateBackend marked as Deprecated, We should also
mark RocksDBStateBackendFactory as Deprecated
2. Since 1.19 will be freezed in 1.26. Let's adjust the target version to
1.20
On Wed, Jan 24, 2024 at 11:50 PM Zakelly Lan wrote:
Hi Jinzhong,
Thanks for driving this! +1 for fixing the lack of annotation.
I'm wondering if we really need to annotate *RocksDBStateUploader* and
*RocksDBStateDownloader
*with @Internal, as they seem to be ordinary classes without interacting
with other modules.
Also, I have reservations about a
Hi devs,
I’m opening this thread to discuss about FLIP-420: Add API annotations for
RocksDB StateBackend user-facing classes[1].
As described in FLINK-18255[2] , several user-facing classes in
flink-statebackend-rocksdb module don't have any API annotations, not even
@PublicEvolving. This FLIP wi
12 matches
Mail list logo
