Re: [DISCUSSION] Improved USER/SYSTEM exception wrapping in Flink code base

2023-06-11 Thread Panagiotis Garefalakis
Hey Hong, Keep in mind that Flink 2.0 is also under discussion and breaking changes could be introduced -- lets just make sure there is real value in a cleaner exception hierarchy (which I believe there is). Cheers, Panagiotis On Sat, Jun 10, 2023 at 4:22 AM Teoh, Hong wrote: > Thanks for the

Re: [DISCUSSION] Improved USER/SYSTEM exception wrapping in Flink code base

2023-06-10 Thread Teoh, Hong
Thanks for the engagement on the thread! Sorry for the late reply, was off on holidays for a bit. @Paul Thanks for linking the historical discussion. Yes I would agree that using classloading to determine if the exception type has come from a User classloader rather than System classloader

Re: [DISCUSSION] Improved USER/SYSTEM exception wrapping in Flink code base

2023-06-05 Thread Panagiotis Garefalakis
Thanks for bringing this up Hong! Classifying exceptions was also the main driving factor behind pluggable failure enrichers . However, we could do a much better job maintaining a hierarchy of System and User exceptions thus making the

Re: [DISCUSSION] Improved USER/SYSTEM exception wrapping in Flink code base

2023-05-31 Thread Paul Lam
Hi Hong, Thanks for starting the discussion! I believe the exception classification between user exceptions and system exceptions has been long-awaited. It's worth mentioning that years ago there was a related discussion [1], FYI. I’m in favor of the heuristic approach to classify the

[DISCUSSION] Improved USER/SYSTEM exception wrapping in Flink code base

2023-05-25 Thread Teoh, Hong
Hi all, This discussion thread is to gauge community opinion and gather feedback on implementing a better exception hierarchy in Flink to identify exceptions that come from running “User job code” and exceptions coming from “Flink engine code”. Problem: Flink provides a distributed processing