Thanks Jiabao for the quick response.
Best,
Yuxin
Jiabao Sun 于2023年11月23日周四 11:25写道：
> Thanks Yuxin for you reminder,
>
> I will complete it today.
>
> Best,
> Jiabao
>
>
> > 2023年11月22日 16:26，Yuxin Tan 写道：
> >
> > Hi, Leonard, jiabao
> >
> > Thanks for migrating the test classes.
> >
> > I h
Thanks Yuxin for you reminder,
I will complete it today.
Best,
Jiabao
> 2023年11月22日 16:26，Yuxin Tan 写道：
>
> Hi, Leonard, jiabao
>
> Thanks for migrating the test classes.
>
> I have noticed that many test classes (e.g., FlinkCalciteCatalogReaderTest)
> in flink-table (including flink-table-
Hi, Leonard, jiabao
Thanks for migrating the test classes.
I have noticed that many test classes (e.g., FlinkCalciteCatalogReaderTest)
in flink-table (including flink-table-planner) have been updated to use
AssertJ.
However, their dependent test classes still utilize org.junit.Test or
org.junit.B
Thanks Leonard and Jiabao for your tremendous efforts in this regard!
Best,
Jane
On Wed, Nov 22, 2023 at 2:42 PM Leonard Xu wrote:
> Hi, all
>
> There are a lot of JUnit4 tests in flink-table-planner module, but now
> Jiabao and I have just migrated all tests to JUnit5 through FLINK-29451[1].
>
Hi, all
There are a lot of JUnit4 tests in flink-table-planner module, but now Jiabao
and I have just migrated all tests to JUnit5 through FLINK-29451[1].
Please use JUnit5 tests when submitting new PRs for flink-table-planner module.
The opened PRs for flink-table-planner module need to rebase
