[VOTE] Add JSON encoding to Avro serialization

2023-10-25 Thread Ryan Skraba
Hello! I'm reviewing a new feature of another contributor (Dale Lane) on FLINK-33058 that adds JSON-encoding in addition to the binary Avro serialization format. He addressed my original objections that JSON encoding isn't _generally_ a best practice for Avro messages. The discussion is pretty w

Re: [VOTE] Add JSON encoding to Avro serialization

2023-10-25 Thread David Radley
Looks good to me +1 From: Ryan Skraba Date: Wednesday, 25 October 2023 at 17:19 To: dev@flink.apache.org Subject: [EXTERNAL] [VOTE] Add JSON encoding to Avro serialization Hello! I'm reviewing a new feature of another contributor (Dale Lane) on FLINK-33058 that adds JSON-encoding in add

Re: [VOTE] Add JSON encoding to Avro serialization

2023-10-26 Thread Jing Ge
L] [VOTE] Add JSON encoding to Avro serialization > Hello! > > I'm reviewing a new feature of another contributor (Dale Lane) on > FLINK-33058 that adds JSON-encoding in addition to the binary Avro > serialization format. He addressed my original objections that JSON > encoding i

Re: [VOTE] Add JSON encoding to Avro serialization

2023-10-26 Thread Alexander Fedulov
to me +1 > > > > From: Ryan Skraba > > Date: Wednesday, 25 October 2023 at 17:19 > > To: dev@flink.apache.org > > Subject: [EXTERNAL] [VOTE] Add JSON encoding to Avro serialization > > Hello! > > > > I'm reviewing a new feature of another