[RESULT][VOTE] FLIP-405: Migrate string configuration key to ConfigOption

2024-01-14 Thread Xuannan Su
Hi devs, I'm happy to announce that FLIP-405: Migrate string configuration key to ConfigOption [1] has been accepted with 4 approving votes (3 binding) [2]: - Rui Fan (binding) - Hang Ruan (non-binding) - Xintong Song (binding) - Zhu Zhu (binding) There are no disapproving votes. Thanks again

Re: [VOTE] FLIP-405: Migrate string configuration key to ConfigOption

2024-01-14 Thread Xuannan Su
Hi all, Thank you all! Closing the vote. The result will be announced in a separate email. Best regards, Xuannan On Fri, Jan 12, 2024 at 2:44 PM Zhu Zhu wrote: > > +1 (binding) > > Thanks, > Zhu > > Xuannan Su 于2024年1月12日周五 14:24写道: > > > Hi all, > > > > I would like to clarify the statement

Re: [VOTE] FLIP-405: Migrate string configuration key to ConfigOption

2024-01-11 Thread Zhu Zhu
+1 (binding) Thanks, Zhu Xuannan Su 于2024年1月12日周五 14:24写道: > Hi all, > > I would like to clarify the statement regarding the first improvement > from the previous email, as it was incomplete. To be more specific, we > will also deprecate the getClass(String key, Class > defaultValue,

Re: [VOTE] FLIP-405: Migrate string configuration key to ConfigOption

2024-01-11 Thread Xuannan Su
Hi all, I would like to clarify the statement regarding the first improvement from the previous email, as it was incomplete. To be more specific, we will also deprecate the getClass(String key, Class defaultValue, ClassLoader classLoader) and setClass(String key, Class klazz), as they are

Re: [VOTE] FLIP-405: Migrate string configuration key to ConfigOption

2024-01-11 Thread Xuannan Su
Hi all, During voting, we identified two improvements we'd like to make to the FLIP: - We will mark the getBytes(String key, byte[] defaultValue) and setBytes(String key, byte[] bytes) methods as @Internal, as they are intended for internal use only. - In addition to marking all

Re: [VOTE] FLIP-405: Migrate string configuration key to ConfigOption

2024-01-08 Thread Xintong Song
+1 (binding) Best, Xintong On Mon, Jan 8, 2024 at 1:48 PM Hang Ruan wrote: > +1(non-binding) > > Best, > Hang > > Rui Fan <1996fan...@gmail.com> 于2024年1月8日周一 13:04写道: > > > +1(binding) > > > > Best, > > Rui > > > > On Mon, Jan 8, 2024 at 1:00 PM Xuannan Su wrote: > > > > > Hi everyone, > >

Re: [VOTE] FLIP-405: Migrate string configuration key to ConfigOption

2024-01-07 Thread Hang Ruan
+1(non-binding) Best, Hang Rui Fan <1996fan...@gmail.com> 于2024年1月8日周一 13:04写道: > +1(binding) > > Best, > Rui > > On Mon, Jan 8, 2024 at 1:00 PM Xuannan Su wrote: > > > Hi everyone, > > > > Thanks for all the feedback about the FLIP-405: Migrate string > > configuration key to ConfigOption [1]

Re: [VOTE] FLIP-405: Migrate string configuration key to ConfigOption

2024-01-07 Thread Rui Fan
+1(binding) Best, Rui On Mon, Jan 8, 2024 at 1:00 PM Xuannan Su wrote: > Hi everyone, > > Thanks for all the feedback about the FLIP-405: Migrate string > configuration key to ConfigOption [1] [2]. > > I'd like to start a vote for it. The vote will be open for at least 72 > hours(excluding

[VOTE] FLIP-405: Migrate string configuration key to ConfigOption

2024-01-07 Thread Xuannan Su
Hi everyone, Thanks for all the feedback about the FLIP-405: Migrate string configuration key to ConfigOption [1] [2]. I'd like to start a vote for it. The vote will be open for at least 72 hours(excluding weekends,until Jan 11, 12:00AM GMT) unless there is an objection or an insufficient number