[RESULT][VOTE] FLIP-78: Flink Python UDF Environment and Dependency Management

2019-10-28 Thread Wei Zhong
Hi all, The voting time for FLIP-78 has passed. I'm closing the vote now. There were 6 +1 votes, 4 of which are binding: - Jincheng (binding) - Hequn (binding) - Thomas (binding) - Maximilian (binding) - Dian (non-binding) - Jeff (non-binding) There were no disapproving votes. Thus, FLIP-78

Re: [VOTE] FLIP-78: Flink Python UDF Environment and Dependency Management

2019-10-28 Thread Wei Zhong
Thanks everyone for the votes! I’ll summarize the voting result in a separate email. Best, Wei > 在 2019年10月28日,11:38,jincheng sun 写道: > > Hi Max, > > Thanks for your feedback. You are right, we really need a more generic > solution, I volunteer to draft an init solution design doc, and bring

Re: [VOTE] FLIP-78: Flink Python UDF Environment and Dependency Management

2019-10-27 Thread jincheng sun
Hi Max, Thanks for your feedback. You are right, we really need a more generic solution, I volunteer to draft an init solution design doc, and bring up the discussion in Beam @dev ASAP. (Maybe after release of Flink 1.10). Thank you for the voting. Best, Jincheng Maximilian Michels

Re: [VOTE] FLIP-78: Flink Python UDF Environment and Dependency Management

2019-10-25 Thread Maximilian Michels
Hi Wei, hi Jincheng, +1 on the current approach. I agree it would be nice to allow for the Beam artifact staging to use Flink's BlobServer. However, the current implementation which uses the distributed file system is more generic, since the BlobServer is only available on the TaskManager

Re: [VOTE] FLIP-78: Flink Python UDF Environment and Dependency Management

2019-10-24 Thread Wei Zhong
Hi Max, Is there any other concerns from your side? I appreciate if you can give some feedback and vote on this. Best, Wei > 在 2019年10月25日,09:33,jincheng sun 写道: > > Hi Thomas, > > Thanks for your explanation. I understand your original intention. I will > seriously consider this issue.

Re: [VOTE] FLIP-78: Flink Python UDF Environment and Dependency Management

2019-10-24 Thread jincheng sun
Hi Thomas, Thanks for your explanation. I understand your original intention. I will seriously consider this issue. After I have the initial solution, I will bring up a further discussion in Beam ML. Thanks for your voting. :) Best, Jincheng Thomas Weise 于2019年10月25日周五 上午7:32写道: > Hi

Re: [VOTE] FLIP-78: Flink Python UDF Environment and Dependency Management

2019-10-24 Thread Thomas Weise
Hi Jincheng, Yes, this topic can be further discussed on the Beam ML. The only reason I brought it up here is that it would be desirable from Beam Flink runner perspective for the artifact staging mechanism that you work on to be reusable. Stage 1 in Beam is also up to the runner, artifact

Re: [VOTE] FLIP-78: Flink Python UDF Environment and Dependency Management

2019-10-21 Thread jincheng sun
Hi Thomas, Thanks for sharing your thoughts. I think improve and solve the limitations of the Beam artifact staging is good topic(For beam). As I understand it as follows: For Beam(data): Stage1: BeamClient --> JobService (data will be upload to DFS). Stage2: JobService(FlinkClient)

Re: [VOTE] FLIP-78: Flink Python UDF Environment and Dependency Management

2019-10-21 Thread Thomas Weise
Beam artifact staging currently relies on shared file system and there are limitations, for example when running locally with Docker and local FS. It sounds like a distributed cache based implementation might be a good (better?) option for artifact staging even for the Beam Flink runner? If so,

Re: [VOTE] FLIP-78: Flink Python UDF Environment and Dependency Management

2019-10-21 Thread jincheng sun
Hi Max, Sorry for the late reply. Regarding the issue you mentioned above, I'm glad to share my thoughts: > For process-based execution we use Flink's cache distribution instead of Beam's artifact staging. In current design, we use Flink's cache distribution to upload users' files from client

Re: [VOTE] FLIP-78: Flink Python UDF Environment and Dependency Management

2019-10-16 Thread Maximilian Michels
I'm also late to the party here :) When I saw the first draft, I was thinking how exactly the design doc would tie in with Beam. Thanks for the update. A couple of comments with this regard: Flink has provided a distributed cache mechanism and allows users to upload their files using

Re: [VOTE] FLIP-78: Flink Python UDF Environment and Dependency Management

2019-10-15 Thread Wei Zhong
Hi Thomas, Thanks a lot for your suggestion! As you can see from the section "Goals" that this FLIP focuses on the dependency management in process mode. However, the APIs and design proposed in this FLIP also applies for the docker mode. So it makes sense to me to also describe how this

Re: [VOTE] FLIP-78: Flink Python UDF Environment and Dependency Management

2019-10-14 Thread Thomas Weise
Sorry for joining the discussion late. The Beam environment already supports artifact staging, it works out of the box with the Docker environment. I think it would be helpful to explain in the FLIP how this proposal relates to what Beam offers / how it would be integrated. Thanks, Thomas On

Re: [VOTE] FLIP-78: Flink Python UDF Environment and Dependency Management

2019-10-14 Thread Jeff Zhang
+1 Hequn Cheng 于2019年10月14日周一 下午10:55写道: > +1 > > Good job, Wei! > > Best, Hequn > > On Mon, Oct 14, 2019 at 2:54 PM Dian Fu wrote: > > > Hi Wei, > > > > +1 (non-binding). Thanks for driving this. > > > > Thanks, > > Dian > > > > > 在 2019年10月14日,下午1:40,jincheng sun 写道: > > > > > > +1 > > > >

Re: [VOTE] FLIP-78: Flink Python UDF Environment and Dependency Management

2019-10-14 Thread Hequn Cheng
+1 Good job, Wei! Best, Hequn On Mon, Oct 14, 2019 at 2:54 PM Dian Fu wrote: > Hi Wei, > > +1 (non-binding). Thanks for driving this. > > Thanks, > Dian > > > 在 2019年10月14日,下午1:40,jincheng sun 写道: > > > > +1 > > > > Wei Zhong 于2019年10月12日周六 下午8:41写道: > > > >> Hi all, > >> > >> I would like

Re: [VOTE] FLIP-78: Flink Python UDF Environment and Dependency Management

2019-10-14 Thread Dian Fu
Hi Wei, +1 (non-binding). Thanks for driving this. Thanks, Dian > 在 2019年10月14日,下午1:40,jincheng sun 写道: > > +1 > > Wei Zhong 于2019年10月12日周六 下午8:41写道: > >> Hi all, >> >> I would like to start the vote for FLIP-78[1] which is discussed and >> reached consensus in the discussion thread[2].

Re: [VOTE] FLIP-78: Flink Python UDF Environment and Dependency Management

2019-10-14 Thread jincheng sun
+1 Wei Zhong 于2019年10月12日周六 下午8:41写道: > Hi all, > > I would like to start the vote for FLIP-78[1] which is discussed and > reached consensus in the discussion thread[2]. > > The vote will be open for at least 72 hours. I'll try to close it by > 2019-10-16 18:00 UTC, unless there is an objection

[VOTE] FLIP-78: Flink Python UDF Environment and Dependency Management

2019-10-12 Thread Wei Zhong
Hi all, I would like to start the vote for FLIP-78[1] which is discussed and reached consensus in the discussion thread[2]. The vote will be open for at least 72 hours. I'll try to close it by 2019-10-16 18:00 UTC, unless there is an objection or not enough votes. Thanks, Wei [1]