Re: [VOTE] Release 1.10.1, release candidate #1

Thanks for the tip! I checked it and you are right :) On Thu, 30 Apr 2020 at 15:08, Chesnay Schepler wrote: > flink-sql-connector-elasticsearch6 isn't bundling com.carrotsearch:hppc, > nor does it have dependencies on org.elasticsearch:elasticsearch-geo, >

Re: [VOTE] Release 1.10.1, release candidate #1

flink-sql-connector-elasticsearch6 isn't bundling com.carrotsearch:hppc, nor does it have dependencies on org.elasticsearch:elasticsearch-geo, org.elasticsearch.plugin:lang-mustache-client nor com.github.spullara.mustache.java:compiler (and thus is also not bundling them). You can check this

Re: [VOTE] Release 1.10.1, release candidate #1

Hi Chesnay, I mean `flink-sql-connector-elasticsearch6`. Because this dependency change on elasticserch7 [1] is totally following how elasticsearch6 does. And they have the almost same dependencies. Best, Jark [1]:

Re: [VOTE] Release 1.10.1, release candidate #1

ES6 isn't bundling these dependencies. On 29/04/2020 17:29, Jark Wu wrote: Looks like the ES NOTICE problem is a long-standing problem, because the ES6 sql connector NOTICE also misses these dependencies. Best, Jark On Wed, 29 Apr 2020 at 17:26, Robert Metzger wrote: Thanks for taking a

Re: [VOTE] Release 1.10.1, release candidate #1

Thanks for all the efforts checking the license. The vote is hereby canceled, will prepare the next RC after license issues resolved. Best Regards, Yu On Wed, 29 Apr 2020 at 23:29, Jark Wu wrote: > Looks like the ES NOTICE problem is a long-standing problem, because the > ES6 sql connector

Re: [VOTE] Release 1.10.1, release candidate #1

Looks like the ES NOTICE problem is a long-standing problem, because the ES6 sql connector NOTICE also misses these dependencies. Best, Jark On Wed, 29 Apr 2020 at 17:26, Robert Metzger wrote: > Thanks for taking a look Chesnay. Then let me officially cancel the > release: > > -1 (binding) > >

Re: [VOTE] Release 1.10.1, release candidate #1

Thanks for taking a look Chesnay. Then let me officially cancel the release: -1 (binding) Another question that I had while checking the release was the "apache-flink-1.10.1.tar.gz" binary, which I suppose is the python distribution. It does not contain a LICENSE and NOTICE file at the root

Re: [VOTE] Release 1.10.1, release candidate #1

Thanks a lot for creating a release candidate for 1.10.1! +1 from my side checked - md5/gpg, ok - source does not contain any binaries, ok - pom points to the same version 1.10.1, ok - README file does not contain anything unexpected, ok - maven clean package -DskipTests, ok - maven clean

Re: [VOTE] Release 1.10.1, release candidate #1

Yes, this is a reason to cancel the RC. Looking at the ES commit, there may also be other dependencies missing, like mustache and elasticsearch-geo. On 29/04/2020 08:54, Robert Metzger wrote: Thanks a lot for creating a release candidate for 1.10.1! I'm not sure, but I think found a

Re: [VOTE] Release 1.10.1, release candidate #1

Thanks a lot for creating a release candidate for 1.10.1! I'm not sure, but I think found a potential issue in the release while checking dependency changes on the ElasticSearch7 connector:

[VOTE] Release 1.10.1, release candidate #1

Hi everyone, Please review and vote on the release candidate #1 for version 1.10.1, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes [1], *