[VOTE] Release flink-shaded 7.0, release candidate 1

2019-05-08 Thread jincheng sun
Hi everyone, Please review and vote on the release candidate #1 for the version 7.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes [1], * t

Re: [VOTE] Release flink-shaded 7.0, release candidate 1

2019-05-10 Thread Chesnay Schepler
-1 We forgot to account for the dependencyManagement section of the root pom when moving the modules. Multiple dependencies are now no longer matching. Just to reduce the risk of something breaking I think we should make sure that the dependency set remains the same. On 08/05/2019 15:39, jin

Re: [VOTE] Release flink-shaded 7.0, release candidate 1

2019-05-13 Thread jincheng sun
Thanks for your vote! @Chesnay Schepler ! When moving the modules, we copy the dependency version of the dependencyManagement in the `flink-parent` pom in the specific sub-module inside the `flink-shaded`, do you meant that we should add `dependencyManagement` section in flink-shaded? I don't full

Re: [VOTE] Release flink-shaded 7.0, release candidate 1

2019-05-15 Thread Chesnay Schepler
I've opened a JIRA: https://issues.apache.org/jira/browse/FLINK-12515 On 13/05/2019 12:03, jincheng sun wrote: Thanks for your vote! @Chesnay Schepler ! When moving the modules, we copy the dependency version of the dependencyManagement in the `flink-parent` pom in the specific sub-module insid

Re: [VOTE] Release flink-shaded 7.0, release candidate 1

2019-05-15 Thread jincheng sun
Thanks a lot for open the JIRA @Chesnay Schepler , I will try to fix it ASAP. :) Chesnay Schepler 于2019年5月15日周三 下午5:40写道: > I've opened a JIRA: https://issues.apache.org/jira/browse/FLINK-12515 > > On 13/05/2019 12:03, jincheng sun wrote: > > Thanks for your vote! @Chesnay Schepler ! > > > > W

Re: [VOTE] Release flink-shaded 7.0, release candidate 1

2019-05-16 Thread jincheng sun
Hi All, Currently, https://issues.apache.org/jira/browse/FLINK-11580 has merged by @Chesnay Schepler ! Great thanks! And I have opened the PR(https://github.com/apache/flink-shaded/pull/62 ) for FLINK-12515 . I appreciate if you can review the c

Re: [VOTE] Release flink-shaded 7.0, release candidate 1

2019-05-19 Thread jincheng sun
Hi All, I’m hereby canceling the vote for RC1 of Flink flink-shaded 7.0 because of FLINK-12414 and FLINK-11580 already merged and no other issues jump up. And the RC2 of flink-shaded 7.0 will be coming! Regards, Jincheng jincheng sun 于2019年5月16日周四 下午4:42写道: > Hi All, > > Currently, https://i