Honestly, I'm not sure whether FLINK-12598 should be treated as a
blocker nonetheless: Although it does not affect the usage of
flink-shaded, it may affect Flink + Flink job developers during bug
hunting sessions where they need to debug into the source code. In this
scenario, you'll definitely
ok, agreed - I created a PR just in case another RC is needed anyway ;)
This is not only about the shaded hadoop sources though...for me
personally, it affects Netty - should affect anything we relocate
On 27/05/2019 11:08, Chesnay Schepler wrote:
> That would've been a good workaround, but RC3
It always worked for netty, why would it no longer do so?
On 27/05/2019 11:22, Nico Kruber wrote:
ok, agreed - I created a PR just in case another RC is needed anyway ;)
This is not only about the shaded hadoop sources though...for me
personally, it affects Netty - should affect anything we
That would've been a good workaround, but RC3 is already out.
I wouldn't wanna delay the release any further because of something one
can work around,
especially so since this only affects people who want the shaded hadoop
sources.
For this you'd probably get by with using the original ones
Thanks for your quickly merged the PR! @Chesnay Schepler
!
I’m hereby canceling the VOTE for RC2 of flink-shaded 7.0 release, because
of the aforementioned issues.
I’ll create an RC3 for flink-shaded 7.0 release ASAP. due to all issues are
already resolved! :)
Thanks,
Jincheng
jincheng sun
I found we should also add the `slf4j-api` as a `provided` dependency for
`flink-shaded-hadoop-2`.
@Nico, Thanks for your check, and the https://issues.apache.org/jira/browse/
FLINK-12598 is not the blocker.
@Chesnay, I remember where we already discussed this issue, the problems
caused by
I found another issue:
1. jackson is bundled twice in the uber jar.
2. javax annotations are included in the slim jar
As for 1), I messed up and modified the shading patterns only for
hadoop-uber, resulting in 2 different shading patterns for jackson.
(jackson is pulled into both jars
Worked for me; could you try again without parallel builds?
Which maven version are you using?
On 23/05/2019 09:24, Nico Kruber wrote:
Thanks Jincheng,
unfortunately, I think, I found a blocker:
-1 (non-binding)
# not working:
- https://issues.apache.org/jira/browse/FLINK-12598
# ok:
-
Thanks Jincheng,
unfortunately, I think, I found a blocker:
-1 (non-binding)
# not working:
- https://issues.apache.org/jira/browse/FLINK-12598
# ok:
- checked release notes
- verified signatures (sha512, asc)
- verified "mvn clean package -Pinclude-netty-tcnative-static"
On 22/05/2019 07:32,
Thank you Jincheng for the release!
+1 (non-binding)
- Release notes are correct.
- Built from source archive successfully.
- Signatures and hash are correct.
- All artifacts(11 artifacts including flink-shaded) have been deployed to
the maven central repository.
One minor comment for the
Hi everyone,
Please review and vote on the release candidate #2 for the version 7.0, as
follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)
The complete staging area is available for your review, which includes:
* JIRA release notes [1],
*
11 matches
Mail list logo
