[VOTE] Reverting sink metric name changes made in 1.15

Hi devs, I'd like to start a vote about reverting sink metric name changes made in 1.15 considering compatibility issues. These metrics include: - numRecordsSend -> numRecordsOut - numRecordsSendPerSecond -> numRecordsOutPerSecond - numBytesSend -> numBytesOut - numBytesSendPerSecond -> numBytesO

Re: [VOTE] Reverting sink metric name changes made in 1.15

Do we have a PoC that achieves this without re-introducing the bug where the numRecordsOut was simply wrong because it counted both records written to the external system and the downstream committer? It's gonna be quite the dirty hack I assume. On 13/10/2022 19:24, Qingsheng Ren wrote: Hi dev

Re: [VOTE] Reverting sink metric name changes made in 1.15

+1 from me (non-binding). The documents about these Kafka sink metrics( Flink metrics and Kafka sink monitoring

Re: [VOTE] Reverting sink metric name changes made in 1.15

Thanks a lot for driving this, Qingsheng! +1 (binding) Best, Jark On Fri, 14 Oct 2022 at 10:16, Hang Ruan wrote: > +1 from me (non-binding). > > The documents about these Kafka sink metrics( Flink metrics > < > https://nightlies.apache.org/flink/flink-docs-release-1.15/docs/ops/metrics//#scop

Re: [VOTE] Reverting sink metric name changes made in 1.15

+1 (binding) Best, Xintong On Fri, Oct 14, 2022 at 11:19 AM Jark Wu wrote: > Thanks a lot for driving this, Qingsheng! > > +1 (binding) > > > Best, > Jark > > On Fri, 14 Oct 2022 at 10:16, Hang Ruan wrote: > > > +1 from me (non-binding). > > > > The documents about these Kafka sink metrics(

Re: [VOTE] Reverting sink metric name changes made in 1.15

+1 Best, Xingbo Xintong Song 于2022年10月14日周五 11:42写道： > +1 (binding) > > Best, > > Xintong > > > > On Fri, Oct 14, 2022 at 11:19 AM Jark Wu wrote: > > > Thanks a lot for driving this, Qingsheng! > > > > +1 (binding) > > > > > > Best, > > Jark > > > > On Fri, 14 Oct 2022 at 10:16, Hang Ruan wro

Re: [VOTE] Reverting sink metric name changes made in 1.15

Thanks for the reply Chesnay! I made a POC [1] just now, and I created a draft PR [2] so that it's easier for everyone to leave comments on it. [1] https://github.com/PatrickRen/flink/tree/FLINK-29567-POC [2] https://github.com/apache/flink/pull/21065 Best, Qingsheng On Fri, Oct 14, 2022 at 1:

Re: [VOTE] Reverting sink metric name changes made in 1.15

+1 The voting title might cause confusion. Technically to say, it is a further modification on top of the current status rather than a reverting after considering the backward compatibility. Best regards, Jing On Fri, Oct 14, 2022 at 10:41 AM Qingsheng Ren wrote: > Thanks for the reply Chesnay

Re: [VOTE] Reverting sink metric name changes made in 1.15

t: Re: [VOTE] Reverting sink metric name changes made in 1.15 +1 The voting title might cause confusion. Technically to say, it is a further modification on top of the current status rather than a reverting after considering the backward compatibility. Best regards, Jing On Fri, Oct 14, 2022 at

[RESULT][VOTE] Reverting sink metric name changes made in 1.15

Hi everyone, I'm happy to announce that the vote about reverting sink metric name changes has passed [1]: +1 votes: - Hang Ruan (non-binding) - Jark Wu (binding) - Xintong Song (binding) - Xingbo Huang (binding) - Jing Ge (non-binding) - Yun Tang (binding) There are no disapproving votes. Than