Jark Wu created FLINK-19824: ------------------------------- Summary: Refactor and merge SupportsComputedColumnPushDown and SupportsWatermarkPushDown interfaces Key: FLINK-19824 URL: https://issues.apache.org/jira/browse/FLINK-19824 Project: Flink Issue Type: Sub-task Components: Table SQL / API Reporter: Jark Wu
As discussed in mailing list [1], the existing SupportsComputedColumnPushDown and SupportsWatermarkPushDown are confusing and hard to implement for connectors. The {{SupportsComputedColumnPushDown}} only used for watermark push down. Therefore, combining them into a single interface {{SupportsWatermarkPushDown}} would be better and also work. The proposed interface looks like this: {code:java} public interface SupportsWatermarkPushDown { void applyWatermark(org.apache.flink.table.sources.wmstrategies.WatermarkStrategy<RowData> watermarkStrategy); } {code} [1]: http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/Merge-SupportsComputedColumnPushDown-and-SupportsWatermarkPushDown-td44387.html -- This message was sent by Atlassian Jira (v8.3.4#803005)