回复: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

Thanks to everyone who discussed here, I really appreciate it. I've updated the FLIP to change all occurrences of "location" to "endpoint" instead. Given that we've reached consensus on the topic, I'll restart the voting. Best, Zhanghao Chen 发件人: Rui Fan 发送时间: 2

回复: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

Hi Jing, Thanks for the clarification, I now see the point. +1 for using endpoint now. @fan...@apache.org WDYT? Best, Zhanghao Chen 发件人: Yangze Guo 发送时间: 2023年9月19日 11:18 收件人: dev@flink.apache.org 主题: Re: [DISCUSS] FLIP-363: Unify the

回复: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

Hi all, I've updated the FLIP to incorporate Yangze's advice: 1. Add a new string formatter method to TaskManagerLocation and ArchivedTaskManagerLocation that prints in the form of "${hostname}:${port}" to align the string formatter used by REST API. 2. Highlight that the old host field will be

回复: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

Hi Yangze, Thanks for the input, totally agree with you, will take the advice. Best, Zhanghao Chen 发件人: Yangze Guo 发送时间: 2023年9月15日 17:26 收件人: dev@flink.apache.org 主题: Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web

回复: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

Hi Jing, Thanks for the suggestion. Endpoint is indeed a more professional word in the networking world but I think location is more suited here for two reasons: 1. The term here is for uniquely identifying the TaskManager where the task is deployed while providing the host machine info as w

回复: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

Hi Fan Rui, Thanks for clarifying the definition of "public interfaces", that helps a lot! Best, Zhanghao Chen 发件人: Rui Fan <1996fan...@gmail.com> 发送时间: 2023年9月11日 11:18 收件人: dev@flink.apache.org 主题: Re: [DISCUSS] FLIP-363: Unify the Representation of TaskManager

回复: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

Hi Weihua, Thanks for the suggestion on keeping the host field. However, I think the location field can serve the needs for finding host-aggregative tasks as well and I'm not sure if a separate host field is still needed. The fields in REST API are mainly used under two scenarios, UI & code pro

回复: [DISCUSS] FLIP-363: Unify the Representation of TaskManager Location in REST API and Web UI

Hi Shammon, I think all REST API response messages (e.g. SubtaskExecutionAttemptDetailsInfo) should be considered as part of the public APIs and therefore be marked as @Public. It is true though none of them are marked as @public yet. Maybe we should do that. ccing @chesnay