Re: Flink JDK compatibility problem.

2020-07-01 Thread Chesnay Schepler
My understanding is that you can only remove the exports by either a) removing all usages or b) migrating the project to modules and declare the JDK dependencies that way. a) is not viable AFAIK and in at least one case would require dropping features (the JMX reporter), while b) appears to be

Re: Flink JDK compatibility problem.

2020-07-01 Thread Niels Basjes
Hi, I've been fiddling around to try to see if this really works when compiling with Java 14. I have the simplest form of this fix working and I've put up a pull request for just that. https://github.com/apache/flink/pull/12799 I also found that there are two different values for java.version that

Re: Flink JDK compatibility problem.

2020-07-01 Thread Chesnay Schepler
oh cool, yes that should work nicely then. On 01/07/2020 10:50, Niels Basjes wrote: Hi, > This is difficult to do since you cannot have multiple jdk activations for a single profile in maven Well actually you can have multiple versions of JDK activate the java11 profile. http://maven.apach

Re: Flink JDK compatibility problem.

2020-07-01 Thread Niels Basjes
Hi, > This is difficult to do since you cannot have multiple jdk activations for a single profile in maven Well actually you can have multiple versions of JDK activate the java11 profile. http://maven.apache.org/guides/introduction/introduction-to-profiles.html quote: 1. 2. 3. [1.3,1

Re: Flink JDK compatibility problem.

2020-06-30 Thread Chesnay Schepler
This is difficult to do since you cannot have multiple jdk activations for a single profile in maven, and duplicating the entire profile for all jdk versions isn't an option. We _maybe_ could invert the behavior such that the Java 11 behavior is the default, with a JDK 8 profile, but there may

Re: Flink JDK compatibility problem.

2020-06-30 Thread Niels Basjes
Hi Chesnay, Ok, so if someone uses a non-LTS version of Java (like 14) then how about simply "pinning" it to the Java 11 compatibility? I'm assuming no one uses Java 9 and/or 10 anymore so I'm ignoring those. Then building with Java 8 will result in Java 8 code. Building with Java 11, 12, 13, 14,

Re: Flink JDK compatibility problem.

2020-06-30 Thread Chesnay Schepler
What is the Java version Apache Flink is supposed to work with? 8 and 11. Non-LTS Java11+ releases _should work_, but we don't put in effort to make it as convenient as for LTS releases. As such you have to manually enable the java11 profile when compiling Flink. I set the target version to

Flink JDK compatibility problem.

2020-06-30 Thread Niels Basjes
Hi, I have both JDK 8 and 14 on my system and yesterday I ran into this exception (I put the info I have in this ticket https://issues.apache.org/jira/browse/FLINK-18455 ) : java.lang.NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer; >From digging around ( https://st