Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-06-06 Thread Lajith Koova
> assume that in your proposal when jobReady is true, then > UpgradeCompleted > > condition would not be present and ClusterReady would always be true? I > > know conditions do not need to be orthogonal, but I wanted to check what > > your thoughts are. > >

Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-06-03 Thread Lajith Koova
related readiness condition related to it’s > > health would be useful; you suggest it be user configurable – this seems > > closer to a liveliness / readiness probe. > > > > Kind regards, David. > > > > From: Mate Czagany > > Date: Thursday, 30 May 2024 at 10:39

Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-06-02 Thread Thomas Weise
gt; closer to a liveliness / readiness probe. > > Kind regards, David. > > From: Mate Czagany > Date: Thursday, 30 May 2024 at 10:39 > To: dev@flink.apache.org > Cc: morh...@apache.org > Subject: [EXTERNAL] Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD > Hi, > > I

RE: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-05-31 Thread David Radley
and ClusterReady would always be true? I > > know conditions do not need to be orthogonal, but I wanted to check what > > your thoughts are. > > > > Kind regards, David. > > > > > > > > > > From: Gyula Fóra > > Date: Wednesday, 29 May 2024

Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-05-30 Thread Mate Czagany
always be true? I > > know conditions do not need to be orthogonal, but I wanted to check what > > your thoughts are. > > > > Kind regards, David. > > > > > > > > > > From: Gyula Fóra > > Date: Wednesday, 29 May 2024 at 15:28 &

Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-05-30 Thread Gyula Fóra
om: Gyula Fóra > Date: Wednesday, 29 May 2024 at 15:28 > To: dev@flink.apache.org > Cc: morh...@apache.org > Subject: [EXTERNAL] Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD > Hi David! > > This change definitely warrants a FLIP even if the code ch

RE: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-05-29 Thread David Radley
thoughts are. Kind regards, David. From: Gyula Fóra Date: Wednesday, 29 May 2024 at 15:28 To: dev@flink.apache.org Cc: morh...@apache.org Subject: [EXTERNAL] Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD Hi David! This change definitely warrants a FLIP even if the code change

Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-05-29 Thread Gyula Fóra
Hi David! This change definitely warrants a FLIP even if the code change is not huge, there are quite some implications going forward. Looping in @morh...@apache.org for this discussion. I have some questions / suggestions regarding the condition's meaning and naming. In your proposal you

Re: [DISCUSS] FLIP-XXX Add K8S conditions to Flink CRD

2024-05-29 Thread David Radley
Hi, Thanks Lajith for raising this discussion thread under the Flip title. To summarise the concerns from the other discussion thread. “ - I echo Gyula that including some examples and further explanations might ease reader's work. With the current version, the FLIP is a bit hard to follow. -