Re: Re: [DISCUSS] FLIP-331: Support EndOfStreamWindows and isOutputOnEOF operator attribute to optimize task deployment

2024-01-29 Thread weijie guo
Thanks Dong and Xuannan, The updated FLIP LGTM. Best regards, Weijie Xuannan Su 于2024年1月30日周二 11:10写道: > Hi all, > > Thanks for the comments and suggestions. If there are no further > comments, I will open the voting thread tomorrow. > > Best regards, > Xuannan > On Fri, Jan 26, 2024 at

Re: Re: [DISCUSS] FLIP-331: Support EndOfStreamWindows and isOutputOnEOF operator attribute to optimize task deployment

2024-01-29 Thread Xuannan Su
Hi all, Thanks for the comments and suggestions. If there are no further comments, I will open the voting thread tomorrow. Best regards, Xuannan On Fri, Jan 26, 2024 at 3:16 PM Dong Lin wrote: > > Thanks Xuannan for the update! > > +1 (binding) > > On Wed, Jan 10, 2024 at 5:54 PM Xuannan Su

Re: Re: [DISCUSS] FLIP-331: Support EndOfStreamWindows and isOutputOnEOF operator attribute to optimize task deployment

2024-01-25 Thread Dong Lin
Thanks Xuannan for the update! +1 (binding) On Wed, Jan 10, 2024 at 5:54 PM Xuannan Su wrote: > Hi all, > > After several rounds of offline discussions with Xingtong and Jinhao, > we have decided to narrow the scope of the FLIP. It will now focus on > introducing OperatorAttributes that

Re: Re: [DISCUSS] FLIP-331: Support EndOfStreamWindows and isOutputOnEOF operator attribute to optimize task deployment

2024-01-23 Thread Xintong Song
Sorry, I just sent an incomplete email draft by mistake. Thanks for reviving this, Xuannan. The updated FLIP LGTM. +1 for it. Best, Xintong On Tue, Jan 23, 2024 at 5:51 PM Xintong Song wrote: > Thanks > > Best, > > Xintong > > > > On Wed, Jan 10, 2024 at 5:56 PM Xuannan Su wrote: > >> Hi

Re: Re: [DISCUSS] FLIP-331: Support EndOfStreamWindows and isOutputOnEOF operator attribute to optimize task deployment

2024-01-23 Thread Xintong Song
Thanks Best, Xintong On Wed, Jan 10, 2024 at 5:56 PM Xuannan Su wrote: > Hi all, > > After several rounds of offline discussions with Xingtong and Jinhao, > we have decided to narrow the scope of the FLIP. It will now focus on > introducing OperatorAttributes that indicate whether an

Re: Re: [DISCUSS] FLIP-331: Support EndOfStreamWindows and isOutputOnEOF operator attribute to optimize task deployment

2024-01-10 Thread Xuannan Su
Hi all, After several rounds of offline discussions with Xingtong and Jinhao, we have decided to narrow the scope of the FLIP. It will now focus on introducing OperatorAttributes that indicate whether an operator emits records only after inputs have ended. We will also use the attribute to

Re: Re: [DISCUSS] FLIP-331: Support EndOfStreamWindows and isOutputOnEOF operator attribute to optimize task deployment

2023-09-25 Thread Dong Lin
Hi all, Thanks for the review! Becket and I discussed this FLIP offline and we agreed on several things that need to be improved with this FLIP. I will summarize our discussion with the problems and TODOs. We will update the FLIP and let you know once the FLIP is ready for review again. 1)

Re: Re: [DISCUSS] FLIP-331: Support EndOfStreamWindows and isOutputOnEOF operator attribute to optimize task deployment

2023-09-18 Thread Yuxin Tan
Hi, Dong, Thanks for your efforts. +1 to this proposal, I believe this will improve the performance in some mixture circumstances of bounded and unbounded workloads. Best, Yuxin Xintong Song 于2023年9月18日周一 10:56写道: > Thanks for addressing my comments, Dong. > > LGTM. > > Best, > > Xintong > >

Re: Re: [DISCUSS] FLIP-331: Support EndOfStreamWindows and isOutputOnEOF operator attribute to optimize task deployment

2023-09-17 Thread Xintong Song
Thanks for addressing my comments, Dong. LGTM. Best, Xintong On Sat, Sep 16, 2023 at 3:34 PM Wencong Liu wrote: > Hi Dong & Jinhao, > > Thanks for your clarification! +1 > > Best regards, > Wencong > > > > > > > > > > > > > > > > > > At 2023-09-15 11:26:16, "Dong Lin" wrote: > >Hi

Re: [DISCUSS] FLIP-331: Support EndOfStreamWindows and isOutputOnEOF operator attribute to optimize task deployment

2023-09-14 Thread Dong Lin
Hi Xintong, Thanks for the comments! Please see my reply inline. On Thu, Sep 14, 2023 at 4:17 PM Xintong Song wrote: > Thanks for preparing this FLIP, Dong & Jinhao. > > I'm overall +1 to this proposal. This is helpful for some cases that we are > dealing with. > - Wencong and I are preparing

Re: [DISCUSS] FLIP-331: Support EndOfStreamWindows and isOutputOnEOF operator attribute to optimize task deployment

2023-09-14 Thread Dong Lin
Hi Wencong, Thanks for your comments! Please see my reply inline. On Thu, Sep 14, 2023 at 12:30 PM Wencong Liu wrote: > Dear Dong, > > I have thoroughly reviewed the proposal for FLIP-331 and believe it would > be > a valuable addition to Flink. However, I do have a few questions that I >

Re: [DISCUSS] FLIP-331: Support EndOfStreamWindows and isOutputOnEOF operator attribute to optimize task deployment

2023-09-14 Thread Xintong Song
Thanks for preparing this FLIP, Dong & Jinhao. I'm overall +1 to this proposal. This is helpful for some cases that we are dealing with. - Wencong and I are preparing guidelines for migrating from DataSet API to DataStream API. We noticed that users have to define a custom trigger in order to

Re:[DISCUSS] FLIP-331: Support EndOfStreamWindows and isOutputOnEOF operator attribute to optimize task deployment

2023-09-13 Thread Wencong Liu
Dear Dong, I have thoroughly reviewed the proposal for FLIP-331 and believe it would be a valuable addition to Flink. However, I do have a few questions that I would like to discuss: 1. The FLIP-331 proposed the EndOfStreamWindows that is implemented by TimeWindow with maxTimestamp =