Re: [DISCUSS] Removing deprecated methods from DataStream API

2020-08-28 Thread Dawid Wysakowicz
pache.org/jira/browse/FLINK-19035 > > Best, > Yun Tang > > From: Aljoscha Krettek > Sent: Thursday, August 27, 2020 16:45 > To: dev@flink.apache.org > Subject: Re: [DISCUSS] Removing deprecated methods from DataStream API > > Did

Re: [DISCUSS] Removing deprecated methods from DataStream API

2020-08-28 Thread Dawid Wysakowicz
r releases (1.0, 2.0, etc.) can >>>> break APIs >>>> with this annotation. Hence, I believe that we cannot simply remove >>>> them >>>> unless the community decides to change the stability guarantees we >>>> give or >>>> by making t

Re: [DISCUSS] Removing deprecated methods from DataStream API

2020-08-28 Thread Yun Tang
://issues.apache.org/jira/browse/FLINK-19035 Best, Yun Tang From: Aljoscha Krettek Sent: Thursday, August 27, 2020 16:45 To: dev@flink.apache.org Subject: Re: [DISCUSS] Removing deprecated methods from DataStream API Did you consider DataStream.project() yet

Re: [DISCUSS] Removing deprecated methods from DataStream API

2020-08-27 Thread Aljoscha Krettek
g 18 03:52:44 2020 *Recipients:*Dawid Wysakowicz *CC:*dev , user *Subject:*Re: [DISCUSS] Removing deprecated methods from DataStream API +1 for removing them. From a quick look, most of them (not all) have been deprecated a long time ago. Cheers, Kostas On Mon, Aug 17, 2020 at 9:3

Re: [DISCUSS] Removing deprecated methods from DataStream API

2020-08-25 Thread Konstantin Knauf
ons, but not available to other >>> commonly used UDF like Source or AsyncFunction[1]. >>> >>> One temporary solution occurs to me is to add a ProcessFunction after >>> the operators want to use side-output. But I think the solution is not very >>> d

Re: [DISCUSS] Removing deprecated methods from DataStream API

2020-08-20 Thread Stephan Ewen
it really works we might add it to the >> document of side-output. >> >> [1] https://issues.apache.org/jira/browse/FLINK-7954 >> >> Best, >> Yun >> >> --Original Mail -- >> *Sender:*Kostas Kloud

Re: [DISCUSS] Removing deprecated methods from DataStream API

2020-08-20 Thread Dawid Wysakowicz
t; *CC:*dev mailto:dev@flink.apache.org>>, > user mailto:u...@flink.apache.org>> > *Subject:*Re: [DISCUSS] Removing deprecated methods from > DataStream API > > +1 for removing them. > > > > From a quick look,

Re: Re: [DISCUSS] Removing deprecated methods from DataStream API

2020-08-18 Thread Till Rohrmann
he.org/jira/browse/FLINK-7954 > > Best, > Yun > > --Original Mail -- > *Sender:*Kostas Kloudas > *Send Date:*Tue Aug 18 03:52:44 2020 > *Recipients:*Dawid Wysakowicz > *CC:*dev , user > *Subject:*Re: [DISCUSS] Removing deprecated methods from DataStrea

Re: Re: [DISCUSS] Removing deprecated methods from DataStream API

2020-08-17 Thread Yun Gao
+1 for removing the methods that are deprecated for a while & have alternative methods. One specific thing is that if we remove the DataStream#split, do we consider enabling side-output in more operators in the future ? Currently it should be only available in ProcessFunctions, but not

Re: [DISCUSS] Removing deprecated methods from DataStream API

2020-08-17 Thread Kostas Kloudas
+1 for removing them. >From a quick look, most of them (not all) have been deprecated a long time ago. Cheers, Kostas On Mon, Aug 17, 2020 at 9:37 PM Dawid Wysakowicz wrote: > > @David Yes, my idea was to remove any use of fold method and all related > classes including WindowedStream#fold >

Re: [DISCUSS] Removing deprecated methods from DataStream API

2020-08-17 Thread Dawid Wysakowicz
@David Yes, my idea was to remove any use of fold method and all related classes including WindowedStream#fold @Klou Good idea to also remove the deprecated enableCheckpointing() & StreamExecutionEnvironment#readFile and alike. I did another pass over some of the classes and thought we could also

Re: [DISCUSS] Removing deprecated methods from DataStream API

2020-08-17 Thread David Anderson
I assume that along with DataStream#fold you would also remove WindowedStream#fold. I'm in favor of going ahead with all of these. David On Mon, Aug 17, 2020 at 10:53 AM Dawid Wysakowicz wrote: > Hi devs and users, > > I wanted to ask you what do you think about removing some of the >

Re: [DISCUSS] Removing deprecated methods from DataStream API

2020-08-17 Thread Kostas Kloudas
Thanks a lot for starting this Dawid, Big +1 for the proposed clean-up, and I would also add the deprecated methods of the StreamExecutionEnvironment like: enableCheckpointing(long interval, CheckpointingMode mode, boolean force) enableCheckpointing() isForceCheckpointing()