+1
I looked at every commit since 1.1.4. The code looks good and we didn’t
introduce any new dependencies, so ,legally speaking, we should be fine.
> On 21 Mar 2017, at 14:40, Stephan Ewen wrote:
>
> +1
>
> - Verified the LICENSE and NOTICE (no dependency updates, update on
+1
- Verified the LICENSE and NOTICE (no dependency updates, update on
RabbitMQ license)
- Release contains no executable binaries
- Build and all integration tests pass forHadoop 2.6.1 , Scala 2.11
@Robert The java8 module has only tests, so it should be fine to not have
it published.
On
+1
- start-local.sh + some example jobs work (logs are fine, web interface
works, scripts are fine)
- files in the staging repo look good (quickstart is correct) (except java8
module is missing, but see comment below)
Side note: The flink-java8 module is not in the staging repository. I first